Skip to content

Commit 7e97bf0

Browse files
committed
. t rename a/b.txt for granularity
1 parent ae5a8cc commit 7e97bf0

File tree

8 files changed

+22
-15
lines changed

8 files changed

+22
-15
lines changed

approvaltests-tests/src/test/java/org/approvaltests/approvers/FileApproverTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ void testCustomError()
7979
""";
8080
try (var old = ApprovalSettings.registerErrorGenerator((r, a) -> new AssertionError("Custom message")))
8181
{
82-
FileApprover fileApprover = new FileApprover(new File("a.txt"), new File("b.txt"), null, null);
82+
FileApprover fileApprover = new FileApprover(new File("a20.txt"), new File("b20.txt"), null, null);
8383
Approvals.verifyException(fileApprover::fail, new Options().inline(expected));
8484
}
8585
}

approvaltests-tests/src/test/java/org/approvaltests/machine_specific_tests/reporters/GenericDiffReporterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ public class GenericDiffReporterTest extends MachineSpecificTest
2020
@Test
2121
public void testTortoiseDiff()
2222
{
23-
approveGenericReporter("a.txt", "b.txt", new TortoiseTextDiffReporter());
23+
approveGenericReporter("a12.txt", "b12.txt", new TortoiseTextDiffReporter());
2424
}
2525
@Disabled("requires windows and WinMerge installed")
2626
@Test
2727
public void testWinMerge()
2828
{
29-
approveGenericReporter("a.txt", "b.txt", new WinMergeReporter());
29+
approveGenericReporter("a3.txt", "b13.txt", new WinMergeReporter());
3030
}
3131
private void approveGenericReporter(String a, String b, GenericDiffReporter reporter)
3232
{

approvaltests-tests/src/test/java/org/approvaltests/reporters/GenericDiffReporterTest.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import com.spun.util.io.FileUtils;
66
import org.approvaltests.Approvals;
77
import org.approvaltests.combinations.CombinationApprovals;
8+
import org.approvaltests.core.Options;
89
import org.approvaltests.reporters.macosx.P4MergeReporter;
910
import org.approvaltests.reporters.macosx.TkDiffReporter;
1011
import org.approvaltests.reporters.macosx.VisualStudioCodeReporter;
@@ -30,22 +31,28 @@ public void testArgumentParsing()
3031
@Test
3132
public void testFileExtensions()
3233
{
33-
assertTrue(new GenericDiffReporter("", "").isFileExtensionHandled("a.txt"));
34+
assertTrue(new GenericDiffReporter("", "").isFileExtensionHandled("a5.txt"));
3435
}
3536
@Test
3637
public void testProgramsExist()
3738
{
38-
assertFalse(new GenericDiffReporter("this_should_never_exist", "").isWorkingInThisEnvironment("a.txt"));
39+
assertFalse(new GenericDiffReporter("this_should_never_exist", "").isWorkingInThisEnvironment("a6.txt"));
3940
}
4041
@Test
4142
public void testTkDiff()
4243
{
43-
approveGenericReporter("a.txt", "b.txt", new TkDiffReporter());
44+
var expected = """
45+
/Applications/TkDiff.app/Contents/MacOS/tkdiff %s %s
46+
""";
47+
approveGenericReporter("a1.txt", "b1.txt", new TkDiffReporter(), expected);
4448
}
4549
@Test
4650
public void testP4Merge()
4751
{
48-
approveGenericReporter("a.png", "b.png", new P4MergeReporter());
52+
var expected = """
53+
/Applications/p4merge.app/Contents/MacOS/p4merge %s %s
54+
""";
55+
approveGenericReporter("a1.png", "b1.png", new P4MergeReporter(), expected);
4956
}
5057
@Test
5158
public void testSpacesInFileNames()
@@ -65,12 +72,12 @@ public String getFileName(String name, Boolean isWindows)
6572
{
6673
return SystemUtils.convertFileForCommandLine(name, isWindows);
6774
}
68-
private void approveGenericReporter(String a, String b, GenericDiffReporter reporter)
75+
private void approveGenericReporter(String a, String b, GenericDiffReporter reporter, String expected)
6976
{
7077
File directory = ClassUtils.getSourceDirectory(getClass());
7178
String aPath = FileUtils.getResolvedPath(new File(directory, a));
7279
String bPath = FileUtils.getResolvedPath(new File(directory, b));
73-
Approvals.verify(new QueryableDiffReporterHarness(reporter, aPath, bPath));
80+
Approvals.verify(new QueryableDiffReporterHarness(reporter, aPath, bPath), new Options().inline(expected));
7481
}
7582
@Test
7683
public void testIsImage()

approvaltests/src/test/java/org/approvaltests/reporters/JUnitReporterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ private void verifyReporter(ApprovalFailureReporter reporter)
3030
try (QuietAutoCloseable l = SimpleLogger.quiet())
3131
{
3232
String a = FileUtils.getResolvedPath(ClassUtils.getAdjacentFile(this.getClass(), "a.txt"));
33-
String b = FileUtils.getResolvedPath(ClassUtils.getAdjacentFile(this.getClass(), "b.txt"));
33+
String r = FileUtils.getResolvedPath(ClassUtils.getAdjacentFile(this.getClass(), "r.txt"));
3434
Approvals.verifyException(() -> {
35-
reporter.report(b, a);
35+
reporter.report(r, a);
3636
});
3737
}
3838
}

approvaltests/src/test/java/org/approvaltests/reporters/JUnitReporterTest.testJUnit3.approved.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ junit.framework.AssertionFailedError: expected:<1
22
a
33
I
44
> but was:<1
5-
b
5+
r
66
I
77
>

approvaltests/src/test/java/org/approvaltests/reporters/JUnitReporterTest.testJUnit4.approved.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ org.junit.ComparisonFailure: expected:<1
22
[a]
33
I
44
> but was:<1
5-
[b]
5+
[r]
66
I
77
>

approvaltests/src/test/java/org/approvaltests/reporters/JUnitReporterTest.testJUnit5.approved.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ org.opentest4j.AssertionFailedError: expected: <1
22
a
33
I
44
> but was: <1
5-
b
5+
r
66
I
77
>
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
1
2-
b
2+
r
33
I

0 commit comments

Comments
 (0)