Skip to content

Commit e212985

Browse files
LarsEckartisidore
andcommitted
B!! Fix problem with cyber dojo not capturing output on linux
Co-Authored-By: Llewellyn Falco <[email protected]>
1 parent 009ef6e commit e212985

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

approvaltests/src/main/java/org/approvaltests/reporters/GenericDiffReporter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ private void launch(String received, String approved)
6565
preventProcessFromClosing(builder);
6666
Process process = builder.start();
6767
processOutput(received, process);
68-
ThreadUtils.sleep(800); //Give program time to start}
68+
ThreadUtils.sleep(800); //Give program time to start
6969
}
7070
catch (Exception e)
7171
{
@@ -75,7 +75,7 @@ private void launch(String received, String approved)
7575
protected void processOutput(String received, Process process)
7676
{
7777
}
78-
private void preventProcessFromClosing(ProcessBuilder builder)
78+
protected void preventProcessFromClosing(ProcessBuilder builder)
7979
{
8080
if (!SystemUtils.isWindowsEnviroment())
8181
{

approvaltests/src/main/java/org/approvaltests/reporters/linux/ReportByCreatingDiffFile.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,9 @@ protected void processOutput(String received, Process process)
2121
String diffFile = received.replace(".received" + extensionWithDot, ".diff");
2222
FileUtils.writeFile(new File(diffFile), process.getInputStream());
2323
}
24+
25+
@Override
26+
protected void preventProcessFromClosing(ProcessBuilder builder) {
27+
// prevent writing to /dev/null
28+
}
2429
}

0 commit comments

Comments
 (0)