Correct default file path

[magicprinc]

Default file path must be
NOT src/test/java/com/foo/bar
BUT src/test/resources/com/foo/bar

Maven/Gradle convenion:
src/test/java for classes
src/test/resources for everything else

🙏

public class PackageSettings {
	public static String ApprovalBaseDirectory = "../resources";
	//public static BeyondCompare4Reporter UseReporter = BeyondCompare4Reporter.INSTANCE;
	public static ApprovalFailureReporter UseReporter = new Junit5Reporter();
}

works 👍
BUT it is so tedious to create such file in every test package 😭

[magicprinc]

also newBase has two file separators between getApprovalBaseDirectory and packagepath

  public String getBaseDirectory()
  {
    String baseDir = info.getSourceFile().getAbsolutePath();
    if (!StringUtils.isEmpty(NamerFactory.getApprovalBaseDirectory()))
    {
      String packageName = info.getFullClassName().substring(0, info.getFullClassName().lastIndexOf("."));
      String packagepath = File.separator + packageName.replace('.', File.separatorChar);
      String currentBase = baseDir.substring(0, baseDir.indexOf(packagepath) + 1);
      String newBase = currentBase + NamerFactory.getApprovalBaseDirectory() + File.separator + packagepath;
      baseDir = ObjectUtils.throwAsError(() -> new File(newBase).getCanonicalPath().toString());
    }
    return baseDir;
  }

fix

String newBase = currentBase + NamerFactory.getApprovalBaseDirectory() + packagepath;

[magicprinc]

Just FYI: Mutable

JDK has java.util.concurrent.atomic.AtomicReference
with the same functionality, but safe for concurrent/multi-thread access.