. F add support for general valid JSON types in VerifyJSONBytes

closes #39

Author: hownowstephen

approvals.go

@@ -138,7 +138,7 @@ func VerifyJSONStruct(t core.Failable, obj interface{}, opts ...VerifyOptions) {
 //	VerifyJSONBytes(t, []byte("{ \"Greeting\": \"Hello\" }"))
 func VerifyJSONBytes(t core.Failable, bs []byte, opts ...VerifyOptions) {
 	t.Helper()
-	var obj map[string]interface{}
+	var obj interface{}
 	err := json.Unmarshal(bs, &obj)
 	if err != nil {
 		message := fmt.Sprintf("error while parsing JSON\nerror:\n  %s\nJSON:\n  %s\n", err, string(bs))

approvals_test.go

@@ -141,6 +141,26 @@ func TestVerifyJSONBytesWithScrubbedIds(t *testing.T) {
 	VerifyJSONBytes(t, jsonb, Options().WithScrubber(scrubber))
 }
 
+func TestVerifyJSONBytesAcceptsValidJSONTypes(t *testing.T) {
+	t.Parallel()
+	for _, tc := range []struct {
+		json string
+	}{
+		{json: "[1, 2, 3]"},
+		{json: "{\"foo\": \"bar\"}"},
+		{json: "1"},
+		{json: "1.0"},
+		{json: "1.0e10"},
+		{json: "true"},
+		{json: "false"},
+		{json: "null"},
+	} {
+		t.Run(tc.json, func(t *testing.T) {
+			VerifyJSONBytes(t, []byte(tc.json))
+		})
+	}
+}
+
 func TestVerifyMap(t *testing.T) {
 	t.Parallel()
 	m := map[string]string{

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.1.0.approved.json

@@ -0,0 +1 @@
+1

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.1.0e10.approved.json

@@ -0,0 +1 @@
+10000000000

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.1.approved.json

@@ -0,0 +1 @@
+1

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.[1,_2,_3].approved.json

@@ -0,0 +1,5 @@
+[
+  1,
+  2,
+  3
+]

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.false.approved.json

@@ -0,0 +1 @@
+false

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.null.approved.json

@@ -0,0 +1 @@
+null

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.true.approved.json

@@ -0,0 +1 @@
+true

testdata/approvals_test.TestVerifyJSONBytesAcceptsValidJSONTypes.{"foo":_"bar"}.approved.json

@@ -0,0 +1,3 @@
+{
+  "foo": "bar"
+}