Improve error message

tamalsaha · tamalsaha · commit 43603afd3644 · 2025-02-01T22:55:50.000+06:00
Signed-off-by: Tamal Saha &lt;tamal@appscode.com&gt;
diff --git a/pkg/server/utils.go b/pkg/server/utils.go
@@ -17,7 +17,6 @@ limitations under the License.
 package server
 
 import (
-	"errors"
 	"fmt"
 	"net"
 	"net/http"
@@ -33,10 +32,10 @@ import (
 func DomainWithMXRecord(domain string) error {
 	records, err := net.LookupMX(domain)
 	if err != nil {
-		return err
+		return fmt.Errorf("no MX records for domain %s: %w", domain, err)
 	}
 	if len(records) == 0 {
-		return errors.New("no MX records")
+		return fmt.Errorf("no MX records for domain %s", domain)
 	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ limitations under the License.`
`17`	`17`	`package server`
`18`	`18`
`19`	`19`	`import (`
`20`		`- "errors"`
`21`	`20`	`"fmt"`
`22`	`21`	`"net"`
`23`	`22`	`"net/http"`
`@@ -33,10 +32,10 @@ import (`
`33`	`32`	`func DomainWithMXRecord(domain string) error {`
`34`	`33`	`records, err := net.LookupMX(domain)`
`35`	`34`	`if err != nil {`
`36`		`- return err`
	`35`	`+ return fmt.Errorf("no MX records for domain %s: %w", domain, err)`
`37`	`36`	`}`
`38`	`37`	`if len(records) == 0 {`
`39`		`- return errors.New("no MX records")`
	`38`	`+ return fmt.Errorf("no MX records for domain %s", domain)`
`40`	`39`	`}`
`41`	`40`	`return nil`
`42`	`41`	`}`