Fix linter warnings

tamalsaha · tamalsaha · commit f00236ade8a2 · 2020-05-21T02:24:54.000-07:00
Signed-off-by: Tamal Saha &lt;tamal@appscode.com&gt;
diff --git a/Makefile b/Makefile
@@ -47,8 +47,8 @@ endif
 ### These variables should not need tweaking.
 ###
 
-SRC_PKGS := cmds context *.go
-SRC_DIRS := $(SRC_PKGS) hack/gendocs # directories which hold app source (not vendored)
+SRC_PKGS := cmds context
+SRC_DIRS := $(SRC_PKGS) *.go hack/gendocs # directories which hold app source (not vendored)
 
 DOCKER_PLATFORMS := linux/amd64 linux/arm linux/arm64
 BIN_PLATFORMS    := $(DOCKER_PLATFORMS) windows/amd64 darwin/amd64
diff --git a/cmds/config/config.go b/cmds/config/config.go
@@ -25,7 +25,7 @@ func NewCmdConfig() *cobra.Command {
 		Example:           "osm config view",
 		DisableAutoGenTag: true,
 		Run: func(cmd *cobra.Command, args []string) {
-			cmd.Help()
+			_ = cmd.Help()
 		},
 	}
 
diff --git a/cmds/config/current.go b/cmds/config/current.go
@@ -32,7 +32,7 @@ func newCmdCurrent() *cobra.Command {
 		DisableAutoGenTag: true,
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) > 0 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 			currentContext(otx.GetConfigPath(cmd))
diff --git a/cmds/config/get.go b/cmds/config/get.go
@@ -34,7 +34,7 @@ func newCmdGet() *cobra.Command {
 		DisableAutoGenTag: true,
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) > 0 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 			getContexts(otx.GetConfigPath(cmd))
diff --git a/cmds/config/set.go b/cmds/config/set.go
@@ -71,10 +71,10 @@ func newCmdSet() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide context name as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/config/use.go b/cmds/config/use.go
@@ -33,10 +33,10 @@ func newCmdUse() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide context name as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/config/view.go b/cmds/config/view.go
@@ -33,7 +33,7 @@ func newCmdView() *cobra.Command {
 		DisableAutoGenTag: true,
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) > 0 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 			viewContext(otx.GetConfigPath(cmd))
diff --git a/cmds/lc.go b/cmds/lc.go
@@ -39,7 +39,7 @@ func NewCmdListContainers() *cobra.Command {
 		DisableAutoGenTag: true,
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/ls.go b/cmds/ls.go
@@ -43,10 +43,10 @@ func NewCmdListIetms() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide container name as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/mc.go b/cmds/mc.go
@@ -39,10 +39,10 @@ func NewCmdMakeContainer() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide container name as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/pull.go b/cmds/pull.go
@@ -45,10 +45,10 @@ func NewCmdPull() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) < 2 {
 				term.Errorln("Provide source item and destination path as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 2 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
@@ -91,7 +91,8 @@ func pull(req *itemPullRequest, configPath string) {
 				term.ExitOnError(err)
 
 				f := filepath.Join(req.destPath, r)
-				os.MkdirAll(filepath.Dir(f), 0755)
+				err = os.MkdirAll(filepath.Dir(f), 0755)
+				term.ExitOnError(err)
 				pullItem(item, f, item.ID())
 			}
 			cursor = next
diff --git a/cmds/push.go b/cmds/push.go
@@ -43,10 +43,10 @@ func NewCmdPush() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) < 2 {
 				term.Errorln("Provide source path and destination item as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 2 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/rc.go b/cmds/rc.go
@@ -41,10 +41,10 @@ func NewCmdRemoveContainer() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide container name as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
@@ -75,7 +75,8 @@ func removeContainer(req *containerRemoveRequest, configPath string) {
 			term.ExitOnError(err)
 			for _, item := range items {
 				term.Warningln("Removing item: " + item.ID())
-				c.RemoveItem(item.ID())
+				err = c.RemoveItem(item.ID())
+				term.ExitOnError(err)
 			}
 			cursor = next
 			if stow.IsCursorEnd(cursor) {
diff --git a/cmds/rm.go b/cmds/rm.go
@@ -41,10 +41,10 @@ func NewCmdRemove() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide item id as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/cmds/root.go b/cmds/root.go
@@ -36,15 +36,15 @@ func NewCmdOsm() *cobra.Command {
 			cli.SendAnalytics(c, v.Version.Version)
 		},
 		Run: func(c *cobra.Command, args []string) {
-			c.Help()
+			_ = c.Help()
 		},
 	}
 	rootCmd.PersistentFlags().AddGoFlagSet(flag.CommandLine)
 	rootCmd.PersistentFlags().String("osmconfig", filepath.Join(homedir.HomeDir(), ".osm", "config"), "Path to osm config")
 	rootCmd.PersistentFlags().BoolVar(&cli.EnableAnalytics, "enable-analytics", cli.EnableAnalytics, "Send usage events to Google Analytics")
 
 	rootCmd.PersistentFlags().BoolVar(&cli.EnableAnalytics, "analytics", cli.EnableAnalytics, "Send usage events to Google Analytics")
-	rootCmd.PersistentFlags().MarkDeprecated("analytics", "use --enable-analytics")
+	_ = rootCmd.PersistentFlags().MarkDeprecated("analytics", "use --enable-analytics")
 
 	rootCmd.AddCommand(cfgCmd.NewCmdConfig())
 
diff --git a/cmds/stat.go b/cmds/stat.go
@@ -42,10 +42,10 @@ func NewCmdStat() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
 				term.Errorln("Provide item id as argument. See examples:")
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			} else if len(args) > 1 {
-				cmd.Help()
+				_ = cmd.Help()
 				os.Exit(1)
 			}
 
diff --git a/context/lib.go b/context/lib.go
@@ -53,7 +53,10 @@ func LoadConfig(configPath string) (*OSMConfig, error) {
 	if _, err := os.Stat(configPath); err != nil {
 		return nil, err
 	}
-	os.Chmod(configPath, 0600)
+	err := os.Chmod(configPath, 0600)
+	if err != nil {
+		return nil, err
+	}
 
 	config := &OSMConfig{}
 	bytes, err := ioutil.ReadFile(configPath)
@@ -73,7 +76,10 @@ func (config *OSMConfig) Save(configPath string) error {
 	if err != nil {
 		return err
 	}
-	os.MkdirAll(filepath.Dir(configPath), 0755)
+	err = os.MkdirAll(filepath.Dir(configPath), 0755)
+	if err != nil {
+		return err
+	}
 	if err := ioutil.WriteFile(configPath, data, 0600); err != nil {
 		return err
 	}
diff --git a/hack/gendocs/main.go b/hack/gendocs/main.go
@@ -107,7 +107,10 @@ func main() {
 	linkHandler := func(name string) string {
 		return "/docs/reference/" + name
 	}
-	doc.GenMarkdownTreeCustom(rootCmd, dir, filePrepender, linkHandler)
+	err = doc.GenMarkdownTreeCustom(rootCmd, dir, filePrepender, linkHandler)
+	if err != nil {
+		log.Fatalln(err)
+	}
 
 	index := filepath.Join(dir, "_index.md")
 	f, err := os.OpenFile(index, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ func NewCmdConfig() *cobra.Command {`
`25`	`25`	`Example: "osm config view",`
`26`	`26`	`DisableAutoGenTag: true,`
`27`	`27`	`Run: func(cmd *cobra.Command, args []string) {`
`28`		`- cmd.Help()`
	`28`	`+ _ = cmd.Help()`
`29`	`29`	`},`
`30`	`30`	`}`
`31`	`31`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ func newCmdCurrent() *cobra.Command {`
`32`	`32`	`DisableAutoGenTag: true,`
`33`	`33`	`Run: func(cmd *cobra.Command, args []string) {`
`34`	`34`	`if len(args) > 0 {`
`35`		`- cmd.Help()`
	`35`	`+ _ = cmd.Help()`
`36`	`36`	`os.Exit(1)`
`37`	`37`	`}`
`38`	`38`	`currentContext(otx.GetConfigPath(cmd))`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func newCmdGet() *cobra.Command {`
`34`	`34`	`DisableAutoGenTag: true,`
`35`	`35`	`Run: func(cmd *cobra.Command, args []string) {`
`36`	`36`	`if len(args) > 0 {`
`37`		`- cmd.Help()`
	`37`	`+ _ = cmd.Help()`
`38`	`38`	`os.Exit(1)`
`39`	`39`	`}`
`40`	`40`	`getContexts(otx.GetConfigPath(cmd))`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func newCmdView() *cobra.Command {`
`33`	`33`	`DisableAutoGenTag: true,`
`34`	`34`	`Run: func(cmd *cobra.Command, args []string) {`
`35`	`35`	`if len(args) > 0 {`
`36`		`- cmd.Help()`
	`36`	`+ _ = cmd.Help()`
`37`	`37`	`os.Exit(1)`
`38`	`38`	`}`
`39`	`39`	`viewContext(otx.GetConfigPath(cmd))`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func NewCmdListContainers() *cobra.Command {`
`39`	`39`	`DisableAutoGenTag: true,`
`40`	`40`	`Run: func(cmd *cobra.Command, args []string) {`
`41`	`41`	`if len(args) > 1 {`
`42`		`- cmd.Help()`
	`42`	`+ _ = cmd.Help()`
`43`	`43`	`os.Exit(1)`
`44`	`44`	`}`
`45`	`45`