Commit 7282f64
authored
feat: skip license page for cloud billing users (#41102)
## Description
This PR enhances the signup success flow to automatically skip the
license page when cloud billing is enabled, providing a smoother
onboarding experience for cloud users.
## Key Changes
### 🚀 New Features
- Added cloud billing detection using `useIsCloudBillingEnabled()` hook
- Implemented automatic license page skipping for cloud billing users
- Enhanced redirect logic with proper async/await handling
### 🔧 Improvements
- Added redirect state management to prevent race conditions
- Improved error handling in redirect flow with try-catch blocks
- Extracted redirect conditions into `shouldAutoRedirect` variable for
better readability
- Added redirect protection to prevent multiple simultaneous redirects
### 🛠️ Technical Details
- Added `isMultiOrgEnabled` flag to signup redirect parameters
- Made `redirectUsingQueryParam` and `onGetStarted` functions async
- Implemented `isRedirecting` state to track redirect status
- Added proper dependency management in useEffect and useCallback hooks
## Impact
- **Cloud billing users** will now bypass the license page automatically
- **Improved UX** with more robust redirect handling and loading states
- **Better performance** by preventing unnecessary redirect attempts
- **Enhanced reliability** with proper error handling and state
management
## Automation
/ok-to-test tags="@tag.Sanity, @tag.Authentication,
@tag.LicenseAndBilling"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/16167808138>
> Commit: ab4247c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16167808138&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Authentication, @tag.LicenseAndBilling`
> Spec:
> <hr>Wed, 09 Jul 2025 12:00:44 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved signup success experience with smarter automatic redirection
based on user status and organization settings.
* Added a loading spinner during redirection for better user feedback.
* **Bug Fixes**
* Prevented multiple redirects from occurring at the same time.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent 3981590 commit 7282f64
1 file changed
+57
-36
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
38 | | - | |
39 | | - | |
40 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
41 | 49 | | |
42 | 50 | | |
43 | 51 | | |
44 | 52 | | |
45 | 53 | | |
| 54 | + | |
46 | 55 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
57 | 70 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
62 | 81 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
72 | 101 | | |
73 | 102 | | |
74 | 103 | | |
| |||
78 | 107 | | |
79 | 108 | | |
80 | 109 | | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
| 110 | + | |
90 | 111 | | |
91 | 112 | | |
92 | 113 | | |
| |||
0 commit comments