Skip to content

Commit c9ef50c

Browse files
authored
fix: Corrected message for REDEPLOY_APP_WARNING. Also not showing Redeploy when Pull button is shown in GIT Modal. (#41474) (#41475)
1 parent 9800c40 commit c9ef50c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

app/client/src/ce/constants/messages.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1055,7 +1055,7 @@ export const CURRENT_PAGE_DISCARD_WARNING = (page: string) =>
10551055
export const DISCARD_MESSAGE = () =>
10561056
`Some changes may reappear after discarding them, these changes support new features in Appsmith. You can safely commit them to your repository.`;
10571057
export const REDEPLOY_APP_WARNING = () =>
1058-
"The deployed version of this app is not using the latest versions of some packages. Redeploy to apply the latest package versions to the app.";
1058+
"The deployed version of this app may be out of sync with what you see in edit mode. Redeploy to apply the latest state.";
10591059

10601060
// GIT DEPLOY end
10611061

app/client/src/git/components/OpsModal/TabDeploy/TabDeployView.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,6 @@ function TabDeployView({
147147
!isCommitLoading &&
148148
!isDiscarding;
149149

150-
const shouldShowRedeploy =
151-
!isFetchStatusLoading && !hasChangesToCommit && !!redeployTrigger;
152-
153150
const isCommitting =
154151
!!commitButtonLoading &&
155152
(commitRequired || showCommitButton) &&
@@ -171,6 +168,12 @@ function TabDeployView({
171168
((pullRequired && !isConflicting) ||
172169
(statusBehindCount > 0 && statusIsClean));
173170

171+
const shouldShowRedeploy =
172+
!isFetchStatusLoading &&
173+
!hasChangesToCommit &&
174+
!showPullButton &&
175+
!!redeployTrigger;
176+
174177
const isCommitSuccess = useMemo(() => {
175178
return hasSubmitted && !isCommitLoading;
176179
}, [isCommitLoading, hasSubmitted]);

0 commit comments

Comments
 (0)