Dismissal animation glitch

[fl034]

I slowed down the animation to make this glitch better visible.
It happens at the handover of the view from the interactive and non-interactive part of the transition.

I assume the problem lies around here, but I can't figure it out

appstore-card-transition/AppstoreTransition/AppstoreTransition/DismissCardAnimator.swift

Lines 61 to 69 in 4e98e9d

	// Card fills inside animated container view
	cardDetailView.edges(to: animatedContainerView)
	animatedContainerView.centerXAnchor.constraint(equalTo: container.centerXAnchor).isActive = true
	let animatedContainerTopConstraint = animatedContainerView.topAnchor.constraint(equalTo: container.topAnchor, constant: params.settings.cardContainerInsets.top)
	let animatedContainerWidthConstraint = animatedContainerView.widthAnchor.constraint(equalToConstant: cardDetailView.frame.width - (params.settings.cardContainerInsets.left + params.settings.cardContainerInsets.right))
	let animatedContainerHeightConstraint = animatedContainerView.heightAnchor.constraint(equalToConstant: cardDetailView.frame.height - (params.settings.cardContainerInsets.top + params.settings.cardContainerInsets.bottom))
	NSLayoutConstraint.activate([animatedContainerTopConstraint, animatedContainerWidthConstraint, animatedContainerHeightConstraint])

[chelemen-razvan]

I'll look into it, but right now fixing the ios 13 issues are more important. If you think you can fix it yourself feel free to make a pull request.

[fl034]

Maybe I find time to look into it. It looks okay for now if the animation is now too slow ;)
In general your code works fine on iOS 13, btw.

[chelemen-razvan]

Not if you compile it with XCode 11

[fl034]

I'm was using Xcode 11 and 11.1 and it's working fine (except my two issues). What do you mean?

[chelemen-razvan]

I don't know yet, but the insets behaviour seem to be different.

[Abhi-philips]

I slowed down the animation to make this glitch better visible.
It happens at the handover of the view from the interactive and non-interactive part of the transition.

I assume the problem lies around here, but I can't figure it out

appstore-card-transition/AppstoreTransition/AppstoreTransition/DismissCardAnimator.swift

Lines 61 to 69 in 4e98e9d

	// Card fills inside animated container view
	cardDetailView.edges(to: animatedContainerView)
	animatedContainerView.centerXAnchor.constraint(equalTo: container.centerXAnchor).isActive = true
	let animatedContainerTopConstraint = animatedContainerView.topAnchor.constraint(equalTo: container.topAnchor, constant: params.settings.cardContainerInsets.top)
	let animatedContainerWidthConstraint = animatedContainerView.widthAnchor.constraint(equalToConstant: cardDetailView.frame.width - (params.settings.cardContainerInsets.left + params.settings.cardContainerInsets.right))
	let animatedContainerHeightConstraint = animatedContainerView.heightAnchor.constraint(equalToConstant: cardDetailView.frame.height - (params.settings.cardContainerInsets.top + params.settings.cardContainerInsets.bottom))
	NSLayoutConstraint.activate([animatedContainerTopConstraint, animatedContainerWidthConstraint, animatedContainerHeightConstraint])

did you solved dismissal animation glitch

[Abhi-philips]

I am also facing the same issue

[fl034]

@Abhi-philips I couldn't fix it. I speeded up the animation so it didn't bother me anymore :D. But would be cool if this would be fixed, maybe by @chelemen-razvan