Add using unsigned numbers where they are needed

Author: Artem Labazin

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 - Add more unit and integration tests.
 
+## [0.3.3](https://github.com/appulse-projects/epmd-java/releases/tag/0.3.3) - 2018-02-09
+
+Minor fix, using unsigned numbers where they are needed
+
 ## [0.3.2](https://github.com/appulse-projects/epmd-java/releases/tag/0.3.2) - 2018-01-31
 
 ### Added

client/README.md

@@ -14,7 +14,7 @@ Include the dependency to your project's pom.xml file:
     <dependency>
         <groupId>io.appulse.epmd.java</groupId>
         <artifactId>client</artifactId>
-        <version>0.3.2</version>
+        <version>0.3.3</version>
     </dependency>
     ...
 </dependencies>
@@ -23,7 +23,7 @@ Include the dependency to your project's pom.xml file:
 or Gradle:
 
 ```groovy
-compile 'io.appulse.epmd.java:client:0.3.2'
+compile 'io.appulse.epmd.java:client:0.3.3'
 ```
 
 ### Create client

client/pom.xml

@@ -25,7 +25,7 @@ limitations under the License.
   <parent>
     <groupId>io.appulse</groupId>
     <artifactId>epmd-java</artifactId>
-    <version>0.3.2</version>
+    <version>0.3.3</version>
   </parent>
 
   <groupId>io.appulse.epmd.java</groupId>

client/src/test/java/io/appulse/epmd/java/client/LocalEpmdClientTest.java

@@ -84,7 +84,7 @@ public void twoRegisters () throws Exception {
 
   @Test
   public void register () throws Exception {
-    val creation = client.register("register", 8971, R3_ERLANG, TCP, R6, R6);
+    val creation = client.register("register", 61_123, R3_ERLANG, TCP, R6, R6);
     assertThat(creation).isNotEqualTo(0);
 
     val optional = client.lookup("register");
@@ -94,7 +94,7 @@ public void register () throws Exception {
     SoftAssertions.assertSoftly(softly -> {
       softly.assertThat(nodeInfo.getPort())
           .isPresent()
-          .hasValue(8971);
+          .hasValue(61_123);
 
       softly.assertThat(nodeInfo.getType())
           .isPresent()

core/pom.xml

@@ -25,7 +25,7 @@ limitations under the License.
   <parent>
     <groupId>io.appulse</groupId>
     <artifactId>epmd-java</artifactId>
-    <version>0.3.2</version>
+    <version>0.3.3</version>
   </parent>
 
   <groupId>io.appulse.epmd.java</groupId>

core/src/main/java/io/appulse/epmd/java/core/model/request/Registration.java

@@ -85,7 +85,7 @@ public void write (@NonNull Bytes bytes) {
 
   @Override
   public void read (@NonNull Bytes bytes) {
-    port = bytes.getShort();
+    port = bytes.getUnsignedShort();
     type = NodeType.of(bytes.getByte());
     protocol = Protocol.of(bytes.getByte());
     high = Version.of(bytes.getShort());

core/src/main/java/io/appulse/epmd/java/core/model/response/EpmdDump.java

@@ -62,7 +62,7 @@ public class EpmdDump implements DataSerializable {
 
   @Override
   public void write (@NonNull Bytes bytes) {
-    bytes.put(port);
+    bytes.put4B(port);
 
     if (nodes.isEmpty()) {
       bytes.put(new byte[0]);

core/src/main/java/io/appulse/epmd/java/core/model/response/EpmdInfo.java

@@ -62,7 +62,7 @@ public class EpmdInfo implements DataSerializable {
 
   @Override
   public void write (@NonNull Bytes bytes) {
-    bytes.put(port);
+    bytes.put4B(port);
 
     if (nodes.isEmpty()) {
       bytes.put(new byte[0]);

core/src/main/java/io/appulse/epmd/java/core/model/response/NodeInfo.java

@@ -111,7 +111,7 @@ public void read (@NonNull Bytes bytes) {
     }
 
     ok = true;
-    port = of((int) bytes.getShort());
+    port = of(bytes.getUnsignedShort());
     type = of(bytes.getByte()).map(NodeType::of);
     protocol = of(bytes.getByte()).map(Protocol::of);
     high = of(bytes.getShort()).map(Version::of);

core/src/main/java/io/appulse/epmd/java/core/model/response/RegistrationResult.java

@@ -63,7 +63,7 @@ public void write (@NonNull Bytes bytes) {
   public void read (@NonNull Bytes bytes) {
     ok = bytes.getByte() == 0;
     if (ok) {
-      creation = bytes.getShort();
+      creation = bytes.getUnsignedShort();
     }
   }
 }