add new release

Author: Artem Labazin

CHANGELOG.md

@@ -12,6 +12,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Add more tests.
 - Add `JavaDoc`.
 
+## [1.16.4](https://github.com/appulse-projects/utils-java/releases/tag/1.16.4) - 2019-12-05
+
+### Changed
+
+- Added `AutoCloseable` interface to `BytesPool`;
+- Refactored initialization for `BytesPool`.
+
 ## [1.16.3](https://github.com/appulse-projects/utils-java/releases/tag/1.16.3) - 2019-05-29
 
 ### Changed

pom.xml

@@ -24,7 +24,7 @@ limitations under the License.
 
   <groupId>io.appulse</groupId>
   <artifactId>utils-java</artifactId>
-  <version>1.16.3</version>
+  <version>1.16.4</version>
   <packaging>jar</packaging>
 
   <properties>
@@ -66,7 +66,7 @@ limitations under the License.
     <url>https://github.com/appulse-projects/utils-java</url>
     <connection>scm:git:https://github.com/appulse-projects/utils-java.git</connection>
     <developerConnection>scm:git:https://github.com/appulse-projects/utils-java.git</developerConnection>
-    <tag>1.16.3</tag>
+    <tag>1.16.4</tag>
   </scm>
 
   <distributionManagement>

src/main/java/io/appulse/utils/BytesPool.java

@@ -44,7 +44,7 @@
  * @since 1.15.0
  */
 @FieldDefaults(level = PRIVATE, makeFinal = true)
-public class BytesPool {
+public class BytesPool implements AutoCloseable {
 
   private static final int DEFAULT_INITIAL_BUFFERS_COUNT = 2;
 
@@ -66,6 +66,10 @@ public class BytesPool {
 
   Lock createNewLock;
 
+  public BytesPool () {
+    this(null, null, null, null);
+  }
+
   @Builder
   BytesPool (Integer initialBuffersCount,
              Integer maximumBuffersCount,
@@ -74,7 +78,6 @@ public class BytesPool {
   ) {
     int initialBuffers = ofNullable(initialBuffersCount)
         .filter(it -> it >= 0)
-        .filter(it -> it <= maximumBuffersCount)
         .orElse(DEFAULT_INITIAL_BUFFERS_COUNT);
 
     this.maximumBuffersCount = ofNullable(maximumBuffersCount)
@@ -86,14 +89,15 @@ public class BytesPool {
         .filter(it -> it > 0)
         .orElse(DEFAULT_INITIAL_BUFFER_SIZE);
 
-    this.bufferCreateFunction = bufferCreateFunction;
+    this.bufferCreateFunction = ofNullable(bufferCreateFunction)
+        .orElse(Bytes::resizableArray);
 
     totalElements = new LongAdder();
     acquiredBuffersCount = new LongAdder();
     createNewLock = new ReentrantLock(true);
 
     buffers = IntStream.range(0, initialBuffers)
-        .mapToObj(it -> bufferCreateFunction.apply(initialBufferSizeBytes))
+        .mapToObj(it -> this.bufferCreateFunction.apply(this.initialBufferSizeBytes))
         .peek(it -> totalElements.increment())
         .collect(toCollection(LinkedBlockingQueue::new));
   }
@@ -170,6 +174,16 @@ public int getTotalCount () {
     return totalElements.intValue();
   }
 
+  @Override
+  public void close () {
+    createNewLock.lock();
+    try {
+      buffers.clear();
+    } finally {
+      createNewLock.unlock();
+    }
+  }
+
   private Bytes getOrCreateBuffer () throws InterruptedException {
     val buffer = buffers.poll();
     if (buffer != null) {

src/test/java/io/appulse/utils/BytesPoolTest.java

@@ -102,4 +102,12 @@ void twoPools () {
         .isInstanceOf(IllegalArgumentException.class)
         .hasMessage("The buffer not from this pool");
   }
+
+  @Test
+  void instantiation () {
+    try (val pool = new BytesPool()) {
+      val buffer = pool.acquire(16);
+      assertThat(buffer.capacity()).isGreaterThanOrEqualTo(16);
+    }
+  }
 }