Speed-up unsigned functions

Author: xxlabaza

CHANGELOG.md

@@ -12,6 +12,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Add more tests.
 - Add `JavaDoc`.
 
+## [1.5.2](https://github.com/appulse-projects/utils-java/releases/tag/1.5.2) - 2018-04-22
+
+Speed-up unsigned functions execution.
+
+### Changed
+
+- byte/short/int unsigned functions became more fast.
+- Catched exception in `ExecutorServiceWithClientTraceTest` rethrows again.
+
 ## [1.5.1](https://github.com/appulse-projects/utils-java/releases/tag/1.5.1) - 2018-04-07
 
 Add fancy logging for `ExecutorServiceWithClientTraceTest`.

pom.xml

@@ -24,7 +24,7 @@ limitations under the License.
 
   <groupId>io.appulse</groupId>
   <artifactId>utils-java</artifactId>
-  <version>1.5.1</version>
+  <version>1.5.2</version>
   <packaging>jar</packaging>
 
   <properties>

src/main/java/io/appulse/utils/BytesUtils.java

@@ -93,7 +93,7 @@ public static byte[] asBytes (double value) {
    * @since 1.3.1
    */
   public static short asUnsignedByte (byte value) {
-    return asUnsignedByte(new byte[] { value });
+    return (short) (value & 0xff);
   }
 
   /**
@@ -111,15 +111,28 @@ public static short asUnsignedByte (@NonNull byte[] bytes) {
 
   public static short asShort (@NonNull byte[] bytes) {
     val aligned = align(bytes, Short.BYTES);
-    return (short) ((aligned[0] <<  8) | (aligned[1] & 0xff));
+    return (short) ((aligned[0] << 8) | (aligned[1] & 0xff));
+  }
+
+  /**
+   * Transforms byte array to unsigned short integer value as integer.
+   *
+   * @param value signed short value
+   *
+   * @return unsigned short as integer
+   *
+   * @since 1.5.2
+   */
+  public static int asUnsignedShort (short value) {
+    return value & 0xFFFF;
   }
 
   /**
    * Transforms byte array to unsigned short integer value as integer.
    *
    * @param bytes byte array
    *
-   * @return unsigned short integer
+   * @return unsigned short as integer
    *
    * @since 1.3.1
    */
@@ -129,23 +142,36 @@ public static int asUnsignedShort (@NonNull byte[] bytes) {
 
   public static char asChar (@NonNull byte[] bytes) {
     val aligned = align(bytes, Short.BYTES);
-    return (char) ((aligned[0] <<  8) | (aligned[1] & 0xff));
+    return (char) ((aligned[0] << 8) | (aligned[1] & 0xff));
   }
 
   public static int asInteger (@NonNull byte[] bytes) {
     val aligned = align(bytes, Integer.BYTES);
     return (aligned[0] << 24)
            | ((aligned[1] & 0xff) << 16)
-           | ((aligned[2] & 0xff) <<  8)
+           | ((aligned[2] & 0xff) << 8)
            | (aligned[3] & 0xff);
   }
 
+  /**
+   * Transforms byte array to unsigned integer value as long integer.
+   *
+   * @param value signed integer value
+   *
+   * @return unsigned integer as long
+   *
+   * @since 1.5.2
+   */
+  public static long asUnsignedInteger (int value) {
+    return value & 0x00000000FFFFFFFFL;
+  }
+
   /**
    * Transforms byte array to unsigned integer value as long integer.
    *
    * @param bytes byte array
    *
-   * @return unsigned integer
+   * @return unsigned integer as long
    *
    * @since 1.3.1
    */
@@ -161,7 +187,7 @@ public static long asLong (@NonNull byte[] bytes) {
            | (((long) aligned[3] & 0xff) << 32)
            | (((long) aligned[4] & 0xff) << 24)
            | (((long) aligned[5] & 0xff) << 16)
-           | (((long) aligned[6] & 0xff) <<  8)
+           | (((long) aligned[6] & 0xff) << 8)
            | ((long) aligned[7] & 0xff);
   }
 

src/main/java/io/appulse/utils/threads/executor/ExecutorServiceWithClientTrace.java

@@ -48,6 +48,7 @@ public void execute (@NonNull Runnable command) {
       } catch (Exception ex) {
         log.error("Exception during task execution submitted from thread '{}'",
                   threadName, merge(clientStack, ex));
+        throw ex;
       }
     });
   }

src/test/java/io/appulse/utils/BytesUtilsTest.java

@@ -117,6 +117,9 @@ public void asUnsignedShort () {
 
     assertThat(BytesUtils.asUnsignedShort(bytes))
         .isEqualTo(62994);
+
+    assertThat(BytesUtils.asUnsignedShort((short) -1))
+        .isEqualTo(65535);
   }
 
   @Test
@@ -164,6 +167,9 @@ public void asUnsignedInteger () {
 
     assertThat(BytesUtils.asUnsignedInteger(bytes))
         .isEqualTo(4_100_000_000L);
+
+    assertThat(BytesUtils.asUnsignedInteger(-1))
+        .isEqualTo(4_294_967_295L);
   }
 
   @Test