chore: changing the name of the fields from inbound_rules -> inbound

Author: gambol99

examples/nacls/main.tf

@@ -26,7 +26,7 @@ module "vpc" {
 
   nacl_rules = {
     private = {
-      inbound_rules = [
+      inbound = [
         {
           cidr_block  = "10.100.0.0/24"
           from_port   = 22
@@ -36,7 +36,7 @@ module "vpc" {
           rule_number = 50
         }
       ]
-      outbound_rules = [
+      outbound = [
         {
           cidr_block  = "10.100.0.0/24"
           from_port   = 22

main.tf

@@ -22,13 +22,13 @@ module "nacls" {
   for_each = var.nacl_rules
   source   = "./modules/nacls"
 
-  inbound_rules  = var.nacl_rules[each.key].inbound_rules
-  name           = each.key
-  outbound_rules = var.nacl_rules[each.key].outbound_rules
-  subnet_count   = var.availability_zones
-  subnet_ids     = local.all_subnets_by_name[each.key].ids
-  tags           = local.tags
-  vpc_id         = module.vpc.vpc_attributes.id
+  inbound      = var.nacl_rules[each.key].inbound
+  name         = each.key
+  outbound     = var.nacl_rules[each.key].outbound
+  subnet_count = var.availability_zones
+  subnet_ids   = local.all_subnets_by_name[each.key].ids
+  tags         = local.tags
+  vpc_id       = module.vpc.vpc_attributes.id
 
   depends_on = [module.vpc]
 }

modules/nacls/locals.tf

@@ -1,7 +1,7 @@
 locals {
   inbound = merge([
     for idx in range(var.subnet_count) : {
-      for rule_idx, rule in try(var.inbound_rules, []) :
+      for rule_idx, rule in try(var.inbound, []) :
       "${idx}-${rule_idx}" => {
         id   = var.subnet_ids[idx]
         rule = rule
@@ -11,7 +11,7 @@ locals {
 
   outbound = merge([
     for idx in range(var.subnet_count) : {
-      for rule_idx, rule in try(var.outbound_rules, []) :
+      for rule_idx, rule in try(var.outbound, []) :
       "${idx}-${rule_idx}" => {
         id   = var.subnet_ids[idx]
         rule = rule

modules/nacls/variables.tf

@@ -19,7 +19,7 @@ variable "subnet_ids" {
   type        = list(string)
 }
 
-variable "inbound_rules" {
+variable "inbound" {
   description = "The inbound rules to apply to the NACL"
   type = list(object({
     cidr_block      = string
@@ -35,7 +35,7 @@ variable "inbound_rules" {
   default = []
 }
 
-variable "outbound_rules" {
+variable "outbound" {
   description = "The outbound rules to apply to the NACL"
   type = list(object({
     cidr_block      = string

tests/nacls.tftest.hcl

@@ -30,7 +30,7 @@ run "check_nacl" {
 
     nacl_rules = {
       private = {
-        inbound_rules = [
+        inbound = [
           {
             cidr_block  = "10.100.0.0/24"
             from_port   = 22
@@ -40,7 +40,7 @@ run "check_nacl" {
             rule_number = 100
           }
         ]
-        outbound_rules = [
+        outbound = [
           {
             cidr_block  = "10.100.0.0/24"
             from_port   = 22
@@ -79,7 +79,7 @@ run "check_nacl_rules" {
     vpc_id       = "vpc-1234567890"
     subnet_count = 3
     subnet_ids   = ["subnet-1234567890", "subnet-1234567891", "subnet-1234567892"]
-    inbound_rules = [
+    inbound = [
       {
         cidr_block  = "10.100.0.0/24"
         from_port   = 22
@@ -89,7 +89,7 @@ run "check_nacl_rules" {
         rule_number = 100
       }
     ]
-    outbound_rules = [
+    outbound = [
       {
         cidr_block  = "10.100.0.0/24"
         from_port   = 22

variables.tf

@@ -162,27 +162,27 @@ variable "transit_subnet_tags" {
 variable "nacl_rules" {
   description = "Map of NACL rules to apply to different subnet types. Each rule requires from_port, to_port, protocol, rule_action, cidr_block, and rule_number"
   type = map(object({
-    inbound_rules = list(object({
+    inbound = list(object({
       cidr_block      = string
-      from_port       = number
+      from_port       = optional(number, null)
       icmp_code       = optional(number, 0)
       icmp_type       = optional(number, 0)
       ipv6_cidr_block = optional(string, null)
       protocol        = optional(number, -1)
-      rule_action     = string
+      rule_action     = optional(string, "allow")
       rule_number     = number
-      to_port         = number
+      to_port         = optional(number, null)
     }))
-    outbound_rules = list(object({
+    outbound = list(object({
       cidr_block      = string
-      from_port       = number
+      from_port       = optional(number, null)
       icmp_code       = optional(number, 0)
       icmp_type       = optional(number, 0)
       ipv6_cidr_block = optional(string, null)
       protocol        = optional(number, -1)
-      rule_action     = string
+      rule_action     = optional(string, "allow")
       rule_number     = number
-      to_port         = number
+      to_port         = optional(number, null)
     }))
   }))
   default = {}