Skip to content

Commit 27f89ef

Browse files
committed
fix:removed onMount
1 parent d610260 commit 27f89ef

File tree

7 files changed

+29
-33
lines changed

7 files changed

+29
-33
lines changed
Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,12 @@
11
<script lang="ts">
2-
import { onMount } from 'svelte';
32
import { InputTextarea } from '$lib/elements/forms';
43
import { feedbackData } from '$lib/stores/feedback';
5-
6-
onMount(() => {
7-
setTimeout(() => {
8-
const textarea = document.getElementById('feedback') as HTMLTextAreaElement;
9-
if (textarea) {
10-
textarea.focus();
11-
}
12-
}, 150);
13-
});
144
</script>
155

166
<InputTextarea
177
required
188
id="feedback"
19-
autofocus={true}
9+
autofocus
2010
bind:value={$feedbackData.message}
2111
label="Tell us more about your experience"
2212
placeholder="Share your suggestions and feature requests..." />

src/lib/components/navbar.svelte

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
import { base } from '$app/paths';
5252
import { logout } from '$lib/helpers/logout';
5353
import { app } from '$lib/stores/app';
54-
import { isTabletViewport } from '$lib/stores/viewport';
54+
import { isTabletViewport, isSmallViewport } from '$lib/stores/viewport';
5555
import { isCloud } from '$lib/system.js';
5656
import { user } from '$lib/stores/user';
5757
import { Click, trackEvent } from '$lib/actions/analytics';
@@ -166,20 +166,22 @@
166166
>Upgrade</Button.Anchor>
167167
{/if}
168168

169-
<DropList show={$feedback.show} class="extended-width">
170-
<Button.Button
171-
type="button"
172-
variant="compact"
173-
on:click={() => {
174-
toggleFeedback();
175-
trackEvent(Click.FeedbackSubmitClick, { source: 'top_nav' });
176-
}}
177-
>Feedback
178-
</Button.Button>
179-
<svelte:fragment slot="other">
180-
<Feedback />
181-
</svelte:fragment>
182-
</DropList>
169+
{#if !$isSmallViewport}
170+
<DropList show={$feedback.show} class="extended-width">
171+
<Button.Button
172+
type="button"
173+
variant="compact"
174+
on:click={() => {
175+
toggleFeedback();
176+
trackEvent(Click.FeedbackSubmitClick, { source: 'top_nav' });
177+
}}
178+
>Feedback
179+
</Button.Button>
180+
<svelte:fragment slot="other">
181+
<Feedback />
182+
</svelte:fragment>
183+
</DropList>
184+
{/if}
183185
<DropList
184186
noArrow
185187
scrollable

src/lib/components/sidebar.svelte

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import MobileSupportModal from '$routes/(console)/wizard/support/mobileSupportModal.svelte';
3636
import MobileFeedbackModal from '$routes/(console)/wizard/feedback/mobileFeedbackModal.svelte';
3737
import { getSidebarState, updateSidebarState } from '$lib/helpers/sidebar';
38-
import { isTabletViewport } from '$lib/stores/viewport';
38+
import { isTabletViewport, isSmallViewport } from '$lib/stores/viewport';
3939
import { Click, trackEvent } from '$lib/actions/analytics';
4040
4141
import type { HTMLAttributes } from 'svelte/elements';
@@ -269,7 +269,9 @@
269269
>Feedback
270270
</Button.Button>
271271
<svelte:fragment slot="other">
272-
<MobileFeedbackModal />
272+
{#if $isSmallViewport}
273+
<MobileFeedbackModal />
274+
{/if}
273275
</svelte:fragment>
274276
</DropList>
275277

@@ -329,7 +331,9 @@
329331
><span>Feedback</span>
330332
</Button.Button>
331333
<svelte:fragment slot="other">
332-
<MobileFeedbackModal />
334+
{#if $isSmallViewport}
335+
<MobileFeedbackModal />
336+
{/if}
333337
</svelte:fragment>
334338
</DropList>
335339

src/routes/(console)/project-[region]-[project]/auth/createUser.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
</script>
5757

5858
<Modal title="Create user" {error} bind:show={showCreate} onSubmit={create}>
59-
<InputText autofocus={true} id="name" label="Name" placeholder="Enter name" bind:value={name} />
59+
<InputText autofocus id="name" label="Name" placeholder="Enter name" bind:value={name} />
6060
<InputEmail id="email" label="Email" placeholder="Enter email" bind:value={mail} />
6161
<InputPhone id="phone" label="Phone" placeholder="Enter phone" bind:value={phone} />
6262
<InputPassword id="password" label="Password" placeholder="Enter password" bind:value={pass} />

src/routes/(console)/project-[region]-[project]/messaging/create-[type]/(type)/push.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
id="title"
117117
label="Title"
118118
required
119-
autofocus={true}
119+
autofocus
120120
placeholder="Enter title"
121121
bind:value={title}>
122122
</InputText>

src/routes/(console)/project-[region]-[project]/messaging/create-[type]/(type)/sms.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
id="message"
9797
label="Message"
9898
required
99-
autofocus={true}
99+
autofocus
100100
maxlength={900}
101101
placeholder="Type here..."
102102
bind:value={content}>

src/routes/(console)/project-[region]-[project]/storage/create.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
label="Name"
5656
placeholder="New bucket"
5757
bind:value={name}
58-
autofocus={true}
58+
autofocus
5959
required />
6060

6161
{#if !showCustomId}

0 commit comments

Comments
 (0)