Skip to content

Commit 9e9662d

Browse files
authored
Merge pull request #2179 from HarshMN2345/feat-SER-127-Delete-Modal-for-env-var
2 parents 4cf8baa + e75c0a8 commit 9e9662d

File tree

1 file changed

+20
-7
lines changed

1 file changed

+20
-7
lines changed

src/routes/(console)/project-[region]-[project]/updateVariables.svelte

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import { page } from '$app/state';
3939
import UpdateVariablesModal from './updateVariablesModal.svelte';
4040
import SecretVariableModal from './secretVariableModal.svelte';
41+
import { Confirm } from '$lib/components';
4142
4243
export let variableList: Models.VariableList;
4344
export let globalVariableList: Models.VariableList | undefined = undefined;
@@ -64,6 +65,8 @@
6465
let showEditorModal = false;
6566
let showUpdate = false;
6667
let showSecretModal = false;
68+
let showDeleteModal = false;
69+
let deleteError: string;
6770
let offset = 0;
6871
const limit = 10;
6972
@@ -134,9 +137,11 @@
134137
}
135138
}
136139
137-
async function handleVariableDeleted(variable: Models.Variable) {
140+
async function handleVariableDeleted() {
138141
try {
139-
await sdkDeleteVariable(variable.$id);
142+
await sdkDeleteVariable(selectedVar.$id);
143+
showDeleteModal = false;
144+
selectedVar = null;
140145
addNotification({
141146
type: 'success',
142147
message: `${$project.name} ${
@@ -145,10 +150,7 @@
145150
});
146151
trackEvent(Submit.VariableDelete);
147152
} catch (error) {
148-
addNotification({
149-
type: 'error',
150-
message: error.message
151-
});
153+
deleteError = error.message;
152154
trackError(error, Submit.VariableDelete);
153155
}
154156
}
@@ -402,7 +404,8 @@
402404
status="danger"
403405
trailingIcon={IconTrash}
404406
on:click={async (e) => {
405-
handleVariableDeleted(variable);
407+
selectedVar = variable;
408+
showDeleteModal = true;
406409
toggle(e);
407410
}}>
408411
Delete
@@ -480,3 +483,13 @@
480483
{variableList}
481484
bind:show={showVariablesUpload} />
482485
{/if}
486+
487+
{#if showDeleteModal}
488+
<Confirm
489+
title="Delete variable"
490+
bind:open={showDeleteModal}
491+
bind:error={deleteError}
492+
onSubmit={handleVariableDeleted}>
493+
<p>Are you sure you want to delete this variable? This action is irreversible.</p>
494+
</Confirm>
495+
{/if}

0 commit comments

Comments
 (0)