Skip to content

Commit d785a09

Browse files
committed
fix: update messaging provider popover when changing providers
Make the popover content reactive so that the tooltip popover updates when the provider changes. Otherwise, the popover content remains static and does not reflect the current provider's settings.
1 parent c8057c8 commit d785a09

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

src/routes/(console)/project-[region]-[project]/messaging/providers/settingsFormInput.svelte

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,6 @@
4343
| FCMProviderParams
4444
| APNSProviderParams
4545
>;
46-
const popover = input.popover ? PopoverContent : null;
47-
const popoverProps = getPopoverProps(input);
48-
49-
function getPopoverProps(input: ProviderInput) {
50-
if (!input.popover) {
51-
return {};
52-
}
53-
return {
54-
lines: input.popover,
55-
image: input.popoverImage
56-
};
57-
}
5846
5947
function handleInvalid(e: CustomEvent) {
6048
const reason = e.detail?.reason ?? '';
@@ -71,6 +59,14 @@
7159
});
7260
}
7361
}
62+
63+
$: popover = input.popover ? PopoverContent : null;
64+
$: popoverProps = !input.popover
65+
? {}
66+
: {
67+
lines: input.popover,
68+
image: input.popoverImage
69+
};
7470
</script>
7571

7672
{#if input.type === 'text'}

0 commit comments

Comments
 (0)