Skip to content

Commit f4edba6

Browse files
authored
Merge pull request #2102 from HarshMN2345/fix-SER-51-fix-permissions-dialog
2 parents a4849e7 + e305717 commit f4edba6

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

src/lib/components/permissions/actions.svelte

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
export let showTeam: boolean;
1313
export let showLabel: boolean;
1414
export let showCustom: boolean;
15-
export let hideOnClick: boolean = false;
1615
export let groups: Writable<Map<string, Permission>>;
1716
1817
const dispatch = createEventDispatcher();
@@ -25,46 +24,46 @@
2524
<ActionMenu.Item.Button
2625
disabled={$groups.has('any')}
2726
on:click={(e) => {
28-
if (hideOnClick) hide(e);
27+
hide(e);
2928
dispatch('create', ['any']);
3029
}}>
3130
Any
3231
</ActionMenu.Item.Button>
3332
<ActionMenu.Item.Button
3433
disabled={$groups.has('guests')}
3534
on:click={(e) => {
36-
if (hideOnClick) hide(e);
35+
hide(e);
3736
dispatch('create', ['guests']);
3837
}}>
3938
All guests
4039
</ActionMenu.Item.Button>
4140
<ActionMenu.Item.Button
4241
disabled={$groups.has('users')}
4342
on:click={(e) => {
44-
if (hideOnClick) hide(e);
43+
hide(e);
4544
dispatch('create', ['users']);
4645
}}>
4746
All users
4847
</ActionMenu.Item.Button>
4948
<ActionMenu.Item.Button
5049
on:click={(e) => {
5150
showUser = true;
52-
if (hideOnClick) hide(e);
51+
hide(e);
5352
}}>Select users</ActionMenu.Item.Button>
5453
<ActionMenu.Item.Button
5554
on:click={(e) => {
5655
showTeam = true;
57-
if (hideOnClick) hide(e);
56+
hide(e);
5857
}}>Select teams</ActionMenu.Item.Button>
5958
<ActionMenu.Item.Button
6059
on:click={(e) => {
6160
showLabel = true;
62-
if (hideOnClick) hide(e);
61+
hide(e);
6362
}}>Label</ActionMenu.Item.Button>
6463
<ActionMenu.Item.Button
6564
on:click={(e) => {
6665
showCustom = true;
67-
if (hideOnClick) hide(e);
66+
hide(e);
6867
}}>Custom permission</ActionMenu.Item.Button>
6968
</ActionMenu.Root>
7069
</svelte:fragment>

src/lib/components/permissions/permissions.svelte

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import { Card } from '$lib/components';
2323
2424
export let withCreate = false;
25-
export let hideOnClick = false;
2625
export let permissions: string[] = [];
2726
2827
let showUser = false;
@@ -197,7 +196,6 @@
197196
bind:showTeam
198197
bind:showUser
199198
{groups}
200-
{hideOnClick}
201199
on:create={create}
202200
let:toggle>
203201
<Button secondary on:click={toggle}>
@@ -215,7 +213,6 @@
215213
bind:showTeam
216214
bind:showUser
217215
{groups}
218-
{hideOnClick}
219216
on:create={create}
220217
let:toggle>
221218
<Button secondary icon on:click={toggle}>

src/lib/components/permissions/team.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
offset = 0;
3535
search = '';
3636
selected.clear();
37+
show = false;
3738
}
3839
3940
function create() {

src/lib/components/permissions/user.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
offset = 0;
3838
search = '';
3939
selected.clear();
40+
show = false;
4041
}
4142
4243
function create() {

0 commit comments

Comments
 (0)