updates regarding review

Author: phaus

.gitignore

@@ -17,7 +17,7 @@ tests/tmp
 # exception to the rule
 !examples/.gitkeep 
 
-.DS_Store
+**/.DS_Store
 templates/swift/example/.build
 templates/swift/example/Example.xcodeproj/project.xcworkspace/xcuserdata
 templates/swift/example/Example.xcodeproj/xcuserdata

templates/go/client.go.twig

@@ -22,6 +22,7 @@ import (
 
 const (
 	fileNameKey = "file"
+	defaultTimeout = 10 * time.Second
 )
 
 // {{ spec.title | caseUcfirst }}Error represents an error of a client request
@@ -60,19 +61,19 @@ type Client struct {
 }
 
 // NewClient initializes a new {{ spec.title | caseUcfirst }} client with a given timeout
-func NewClient(timeout time.Duration) Client {
+func NewClient() Client {
 	headers := map[string]string{
 {% for key,header in spec.global.defaultHeaders %}
 		"{{key}}" : "{{header}}",
 		"x-sdk-version": "{{ sdk.gitUserName|url_encode }}:go:{{sdk.version}}",
 {% endfor %}
 	}
-	httpClient, err := getDefaultClient(timeout)
+	httpClient, err := getDefaultClient(defaultTimeout)
 	if err != nil { panic(err) }
 	return Client {
 		endpoint: "https://{{ sdk.gitUserName|url_encode }}.io/v1",
 		client: httpClient,
-		timeout: timeout,
+		timeout: defaultTimeout,
 		headers: headers,
 	}
 }
@@ -92,6 +93,14 @@ func getDefaultClient(timeout time.Duration) (*http.Client, error) {
 	}, nil
 }
 
+func (clt *Client) SetTimeout(timeout time.Duration) error {
+	clt.timeout = timeout
+	httpClient, err := getDefaultClient(timeout)
+	if err != nil { return err }
+	clt.client = httpClient
+	return nil
+}
+
 // SetEndpoint sets the default endpoint to which the Client connects to
 func (clt *Client) SetEndpoint(endpoint string) {
 	clt.endpoint = endpoint

templates/go/docs/example.md.twig

@@ -7,7 +7,7 @@ import (
 )
 
 func main() {
-    var client := {{ spec.title | caseLower }}.NewClient(10 * time.Second)
+    client := {{ spec.title | caseLower }}.NewClient()
 
 {% if method.security|length > 0 %}
     client.SetEndpoint("https://[HOSTNAME_OR_IP]/v1") // Your API Endpoint

templates/go/main.go.twig

@@ -14,38 +14,25 @@ const (
 	EmptyParentPropertyType = ""
 )
 
-const (
-	EmptyParentDocument     = ""
-	EmptyParentProperty     = ""
-	EmptyParentPropertyType = ""
-)
-
-const (
-	EmptyParentDocument     = ""
-	EmptyParentProperty     = ""
-	EmptyParentPropertyType = ""
-)
-
 func main() {
 	var EmptyArray = []interface{}{}
 
-	client := {{ sdk.gitUserName|url_encode }}.NewClient(10 * time.Second)
+	client := {{ sdk.gitUserName|url_encode }}.NewClient()
 	client.SetEndpoint(os.Getenv("YOUR_ENDPOINT"))
 	client.SetProject(os.Getenv("YOUR_PROJECT_ID"))
 	client.SetKey(os.Getenv("YOUR_KEY"))
+	client.SetTimeout(10 * time.Second)
 
 	db := {{ sdk.gitUserName|url_encode }}.NewDatabase(client)
 	data := map[string]string{
 		"hello": "world",
 	}
 	doc, err := db.CreateDocument(
 		os.Getenv("COLLECTION_ID"),
+		EmptyParentDocument,
 		data,
 		EmptyArray,
 		EmptyArray,
-		EmptyParentDocument,
-		EmptyParentProperty,
-		EmptyParentPropertyType,
 	)
 	if err != nil {
 		log.Printf("Error creating document: %v", err)

tests/languages/go/tests.go

@@ -11,7 +11,11 @@ import (
 func main() {
 	stringInArray := []interface{}{"string in array"}
 
-	client := appwrite.NewClient(10 * time.Second)
+	client := appwrite.NewClient()
+	err := client.SetTimeout(10 * time.Second)
+	if err != nil {
+		panic(err)
+	}
 	client.SetEndpoint("https://appwrite.io/v1")
 	client.AddHeader("Origin", "http://localhost")
 	fmt.Print("\n\nTest Started\n")