refactor: reviews

Author: byawitz

templates/cli/base/requests/api.twig

@@ -17,7 +17,7 @@
     fs.writeFileSync(destination, response);
     {%~ endif %}
     if (parseOutput) {
-    {%~ if methodHaveConsolePreview(method.name,service.name) %}
+    {%~ if hasConsolePreview(method.name,service.name) %}
         if(console) {
             showConsoleLink('{{service.name}}', '{{ method.name }}'
         {%- for parameter in method.parameters.path -%}{%- set param = (parameter.name | caseCamel | escapeKeyword)  -%}{%- if param  ends with 'Id' -%}, {{ param }} {%- endif -%}{%- endfor -%}

templates/cli/lib/commands/command.js.twig

@@ -70,7 +70,7 @@ const {{ service.name | caseLower }}{{ method.name | caseUcfirst }} = async ({
         {%- if 'multipart/form-data' in method.consumes -%},onProgress = () => {}{%- endif -%}
 
         {%- if method.type == 'location' -%}, destination{%- endif -%}
-        {% if methodHaveConsolePreview(method.name,service.name) %}, console{%- endif -%}
+        {% if hasConsolePreview(method.name,service.name) %}, console{%- endif -%}
 }) => {
 {%~ endblock %}
     let client = !sdk ? await {% if service.name == "projects" %}sdkForConsole(){% else %}sdkForProject(){% endif %} :
@@ -95,7 +95,7 @@ const {{ service.name | caseLower }}{{ method.name | caseUcfirst }} = async ({
 {% if method.type == 'location' %}
     .requiredOption(`--destination <path>`, `output file path.`)
 {% endif %}
-{% if methodHaveConsolePreview(method.name,service.name) %}
+{% if hasConsolePreview(method.name,service.name) %}
     .option(`--console`, `Get the resource console url`)
 {% endif %}
 {% endautoescape %}

templates/cli/lib/commands/generic.js.twig

@@ -186,10 +186,10 @@ const logout = new Command("logout")
             }
         }
 
-        const leftSessions = globalConfig.getSessions();
+        const remainingSessions  = globalConfig.getSessions();
 
-        if (leftSessions.length > 0 && leftSessions.filter(session => session.id === current).length !== 1) {
-            const accountId = leftSessions[0].id;
+        if (remainingSessions .length > 0 && remainingSessions .filter(session => session.id === current).length !== 1) {
+            const accountId = remainingSessions [0].id;
             globalConfig.setCurrentSession(accountId);
 
             success(`Current account is ${accountId}`);

templates/cli/lib/utils.js.twig

@@ -1,9 +1,7 @@
 const fs = require("fs");
 const path = require("path");
 const { localConfig, globalConfig } = require("./config");
-const { success, log, error } = require('./parser')
-const readline = require('readline');
-const cp = require('child_process');
+const { success } = require('./parser')
 
 function getAllFiles(folder) {
     const files = [];