Merge pull request #321 from KhaleelSH/add-linting-rules

Author: lohanidamodar

src/SDK/Language/Dart.php

@@ -101,7 +101,8 @@ public function getKeywords()
             "set",
             "yield",
             "required",
-            "default"
+            "extension",
+            "late"
         ];
     }
 

templates/flutter/lib/services/service.dart.twig

@@ -52,7 +52,7 @@ class {{ service.name | caseUcfirst }} extends Service {
         });
 
         Uri endpoint = Uri.parse(client.endPoint);
-        Uri url = new Uri(scheme: endpoint.scheme,
+        Uri url = Uri(scheme: endpoint.scheme,
           host: endpoint.host,
           port: endpoint.port,
           path: endpoint.path + path,

templates/flutter/lib/src/client_base.dart.twig

@@ -7,17 +7,23 @@ abstract class ClientBase implements Client {
 {% if header.description %}
     /// {{header.description}}
 {% endif %}
+  @override
   ClientBase set{{header.key | caseUcfirst}}(value);
 {% endfor %}
 
+  @override
   ClientBase setSelfSigned({bool status = true});
 
+  @override
   ClientBase setEndpoint(String endPoint);
 
+  @override
   Client setEndPointRealtime(String endPoint);
 
+  @override
   ClientBase addHeader(String key, String value);
 
+  @override
   Future<Response> call(
     HttpMethod method, {
     String path = '',

templates/flutter/lib/src/client_browser.dart.twig

@@ -17,10 +17,12 @@ ClientBase createClient({
 class ClientBrowser extends ClientBase with ClientMixin {
   String _endPoint;
   Map<String, String>? _headers;
+  @override
   late Map<String, String> config;
   late BrowserClient _httpClient;
   String? _endPointRealtime;
 
+  @override
   String? get endPointRealtime => _endPointRealtime;
 
   ClientBrowser({
@@ -46,23 +48,27 @@ class ClientBrowser extends ClientBase with ClientMixin {
     init();
   }
 
+  @override
   String get endPoint => _endPoint;
 
 {% for header in spec.global.headers %}
 {% if header.description %}
      /// {{header.description}}
 {% endif %}
+    @override
     ClientBrowser set{{header.key | caseUcfirst}}(value) {
         config['{{ header.key | caseCamel }}'] = value;
         addHeader('{{header.name}}', value);
         return this;
     }
 {% endfor %}
 
+  @override
   ClientBrowser setSelfSigned({bool status = true}) {
     return this;
   }
 
+  @override
   ClientBrowser setEndpoint(String endPoint) {
     this._endPoint = endPoint;
     _endPointRealtime = endPoint
@@ -71,17 +77,20 @@ class ClientBrowser extends ClientBase with ClientMixin {
     return this;
   }
 
+  @override
   ClientBrowser setEndPointRealtime(String endPoint) {
     _endPointRealtime = endPoint;
     return this;
   }
 
+  @override
   ClientBrowser addHeader(String key, String value) {
     _headers![key] = value;
 
     return this;
   }
 
+  @override
   Future init() async {
     if (html.window.localStorage.keys.contains('cookieFallback')) {
       addHeader('x-fallback-cookies',

templates/flutter/lib/src/client_io.dart.twig

@@ -27,27 +27,29 @@ ClientBase createClient({
 class ClientIO extends ClientBase with ClientMixin {
   String _endPoint;
   Map<String, String>? _headers;
+  @override
   late Map<String, String> config;
   bool selfSigned;
   bool _initialized = false;
   String? _endPointRealtime;
   late http.Client _httpClient;
   late HttpClient _nativeClient;
   late CookieJar _cookieJar;
-  List<Interceptor> _interceptors = [];
+  final List<Interceptor> _interceptors = [];
 
   bool get initialized => _initialized;
   CookieJar get cookieJar => _cookieJar;
+  @override
   String? get endPointRealtime => _endPointRealtime;
 
   ClientIO({
     String endPoint = 'https://appwrite.io/v1',
     this.selfSigned = false,
   }) : _endPoint = endPoint {
-    _nativeClient = new HttpClient()
+    _nativeClient = HttpClient()
       ..badCertificateCallback =
           ((X509Certificate cert, String host, int port) => selfSigned);
-    _httpClient = new IOClient(_nativeClient);
+    _httpClient = IOClient(_nativeClient);
     _endPointRealtime = endPoint
         .replaceFirst('https://', 'wss://')
         .replaceFirst('http://', 'ws://');
@@ -66,12 +68,13 @@ class ClientIO extends ClientBase with ClientMixin {
     init();
   }
 
+  @override
   String get endPoint => _endPoint;
 
   Future<Directory> _getCookiePath() async {
     final directory = await getApplicationDocumentsDirectory();
     final path = directory.path;
-    final Directory dir = new Directory('$path/cookies');
+    final Directory dir = Directory('$path/cookies');
     await dir.create();
     return dir;
   }
@@ -80,20 +83,23 @@ class ClientIO extends ClientBase with ClientMixin {
 {% if header.description %}
      /// {{header.description}}
 {% endif %}
+    @override
     ClientIO set{{header.key | caseUcfirst}}(value) {
         config['{{ header.key | caseCamel }}'] = value;
         addHeader('{{header.name}}', value);
         return this;
     }
 {% endfor %}
 
+  @override
   ClientIO setSelfSigned({bool status = true}) {
     this.selfSigned = status;
     _nativeClient.badCertificateCallback =
         ((X509Certificate cert, String host, int port) => status);
     return this;
   }
 
+  @override
   ClientIO setEndpoint(String endPoint) {
     this._endPoint = endPoint;
     _endPointRealtime = endPoint
@@ -102,11 +108,13 @@ class ClientIO extends ClientBase with ClientMixin {
     return this;
   }
 
+  @override
   ClientIO setEndPointRealtime(String endPoint) {
     _endPointRealtime = endPoint;
     return this;
   }
 
+  @override
   ClientIO addHeader(String key, String value) {
     _headers![key] = value;
 
@@ -116,7 +124,7 @@ class ClientIO extends ClientBase with ClientMixin {
   Future init() async {
     // if web skip cookie implementation and origin header as those are automatically handled by browsers
     final Directory cookieDir = await _getCookiePath();
-    _cookieJar = new PersistCookieJar(storage: FileStorage(cookieDir.path));
+    _cookieJar = PersistCookieJar(storage: FileStorage(cookieDir.path));
     this._interceptors.add(CookieManager(_cookieJar));
     PackageInfo packageInfo = await PackageInfo.fromPlatform();
     addHeader('Origin',
@@ -191,6 +199,7 @@ class ClientIO extends ClientBase with ClientMixin {
     return response;
   }
 
+  @override
   Future webAuth(Uri url) {
     return FlutterWebAuth.authenticate(
       url: url.toString(),
@@ -203,7 +212,7 @@ class ClientIO extends ClientBase with ClientMixin {
         throw {{spec.title | caseUcfirst}}Exception(
             "Invalid OAuth2 Response. Key and Secret not available.", 500);
       }
-      Cookie cookie = new Cookie(key, secret);
+      Cookie cookie = Cookie(key, secret);
       cookie.domain = Uri.parse(_endPoint).host;
       cookie.httpOnly = true;
       cookie.path = '/';
@@ -213,6 +222,7 @@ class ClientIO extends ClientBase with ClientMixin {
     });
   }
 
+  @override
   Future<Response> call(
     HttpMethod method, {
     String path = '',

templates/flutter/lib/src/client_mixin.dart.twig

@@ -67,9 +67,7 @@ class ClientMixin {
   }
 
   Response prepareResponse(http.Response res, {ResponseType? responseType}) {
-    if (responseType == null) {
-      responseType = ResponseType.json;
-    }
+    responseType ??= ResponseType.json;
     if (res.statusCode >= 400) {
       if ((res.headers['content-type'] ?? '').contains('application/json')) {
         final response = json.decode(res.body);
@@ -82,7 +80,7 @@ class ClientMixin {
         throw {{spec.title | caseUcfirst}}Exception(res.body);
       }
     }
-    var data;
+    dynamic data;
     if ((res.headers['content-type'] ?? '').contains('application/json')) {
       if (responseType == ResponseType.json) {
         data = json.decode(res.body);
@@ -103,7 +101,7 @@ class ClientMixin {
 
   Future<http.Response> toResponse(http.StreamedResponse streamedResponse) async {
     if(streamedResponse.statusCode == 204) {
-        return new http.Response('',
+        return http.Response('',
           streamedResponse.statusCode,
           headers: streamedResponse.headers.map((k,v) => k.toLowerCase()=='content-type' ? MapEntry(k, 'text/plain') : MapEntry(k,v)),
           request: streamedResponse.request,

templates/flutter/lib/src/cookie_manager.dart.twig

@@ -19,7 +19,7 @@ class CookieManager extends Interceptor {
         .then((cookies) {
       var cookie = getCookies(cookies);
       if (cookie.isNotEmpty) {
-        request..headers.addAll({HttpHeaders.cookieHeader: cookie});
+        request.headers.addAll({HttpHeaders.cookieHeader: cookie});
       }
       return request;
     }).catchError((e, stackTrace) {

templates/flutter/lib/src/exception.dart.twig

@@ -4,7 +4,8 @@ class {{spec.title | caseUcfirst}}Exception implements Exception {
   final dynamic response;
 
   {{spec.title | caseUcfirst}}Exception([this.message = "", this.code, this.response]);
-  
+
+  @override
   String toString() {
     if (message == null) return "{{spec.title | caseUcfirst}}Exception";
     return "{{spec.title | caseUcfirst}}Exception: $message (${code ?? 0})";

templates/flutter/lib/src/realtime_base.dart.twig

@@ -2,5 +2,6 @@ import 'realtime_subscription.dart';
 import 'realtime.dart';
 
 abstract class RealtimeBase implements Realtime {
+  @override
   RealtimeSubscription subscribe(List<String> channels);
 }

templates/flutter/lib/src/realtime_browser.dart.twig

@@ -34,6 +34,7 @@ class RealtimeBrowser extends RealtimeBase with RealtimeMixin {
     return null;
   }
 
+  @override
   RealtimeSubscription subscribe(List<String> channels) {
     return subscribeTo(channels);
   }