Skip to content

Commit 3c95f21

Browse files
committed
fix bugs in ruby refactor
1 parent 17075c7 commit 3c95f21

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

templates/ruby/base/params.twig

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,9 @@
1-
{% if method.parameters.all | length %}
2-
{% for parameter in method.parameters.all %}
3-
{% if parameter.required %}
4-
if {% if parameter.isGlobal %}@{% endif %}{{ parameter.name | caseSnake | escapeKeyword }}.nil?
5-
raise {{spec.title | caseUcfirst}}::Exception.new('Missing required parameter: "{{ parameter.name | caseCamel | escapeKeyword }}"')
6-
end
7-
8-
{% endif %}
9-
{% endfor %}
10-
{% for parameter in method.parameters.path %}
11-
.gsub('{{ '{' }}{{ parameter.name }}{{ '}' }}', {% if parameter.isGlobal %}@{% endif %}{{ parameter.name | caseSnake | escapeKeyword }})
12-
{% endfor %}
13-
141
params = {
152
{% for parameter in method.parameters.query | merge(method.parameters.body) %}
163
{{ parameter.name }}: {% if parameter.isGlobal %}@{% endif %}{{ parameter.name | caseSnake | escapeKeyword }},
174
{% endfor %}
185
}
19-
6+
207
headers = {
218
{% for parameter in method.parameters.header %}
229
"{{ parameter.name }}": {{ parameter.name | caseCamel | escapeKeyword }},
@@ -25,4 +12,16 @@
2512
"{{ key }}": '{{ header }}',
2613
{% endfor %}
2714
}
15+
{% if method.parameters.all | length %}
16+
{% for parameter in method.parameters.all %}
17+
{% if parameter.required %}
18+
if {% if parameter.isGlobal %}@{% endif %}{{ parameter.name | caseSnake | escapeKeyword }}.nil?
19+
raise {{spec.title | caseUcfirst}}::Exception.new('Missing required parameter: "{{ parameter.name | caseCamel | escapeKeyword }}"')
20+
end
21+
22+
{% endif %}
23+
{% endfor %}
24+
{% for parameter in method.parameters.path %}
25+
.gsub('{{ '{' }}{{ parameter.name }}{{ '}' }}', {% if parameter.isGlobal %}@{% endif %}{{ parameter.name | caseSnake | escapeKeyword }})
26+
{% endfor %}
2827
{% endif %}

templates/ruby/lib/container/services/service.rb.twig

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,16 @@ module {{spec.title | caseUcfirst}}
2727
def {{ method.name | caseSnake }}({% for parameter in method.parameters.all | filter((param) => not param.isGlobal) %}{{ parameter.name | caseSnake | escapeKeyword }}:{% if not parameter.required %} nil{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, on_progress: nil{% endif %})
2828

2929
path = '{{ method.path }}'
30+
3031
{{ include('ruby/base/params.twig')}}
3132
{% if 'multipart/form-data' in method.consumes %}
3233
{{ include('ruby/base/requests/file.twig')}}
3334
{% else %}
3435
{{ include('ruby/base/requests/api.twig')}}
35-
end
3636
{% endif %}
37+
end
38+
39+
3740
{% endfor %}
3841
end
3942
end

0 commit comments

Comments
 (0)