Merge pull request #129 from lohanidamodar/feat-python-exception

Feat python exception

Author: eldadfux

src/SDK/Language/Python.php

@@ -146,6 +146,12 @@ public function getFiles()
                 'template'      => '/python/package/client.py.twig',
                 'minify'        => false,
             ],
+            [
+                'scope'         => 'default',
+                'destination'   => '{{ spec.title | caseSnake}}/exception.py',
+                'template'      => '/python/package/exception.py.twig',
+                'minify'        => false,
+            ],
             [
                 'scope'         => 'default',
                 'destination'   => '{{ spec.title | caseSnake}}/service.py',

templates/python/package/client.py.twig

@@ -1,5 +1,6 @@
 import io
 import requests
+from .exception import {{spec.title | caseUcfirst}}Exception
 
 class Client:
     def __init__(self):
@@ -63,26 +64,32 @@ class Client:
                 if isinstance(data[key], io.BufferedIOBase):
                     files[key] = data[key]
                     del data[key]
-
-        response = requests.request(  # call method dynamically https://stackoverflow.com/a/4246075/2299554
-            method=method,
-            url=self._endpoint + path,
-            params=self.flatten(params),
-            data=self.flatten(data),
-            json=json,
-            files=files,
-            headers=headers,
-            verify=self._self_signed,
-        )
-
-        response.raise_for_status()
-
-        content_type = response.headers['Content-Type']
-
-        if content_type.startswith('application/json'):
-            return response.json()
-
-        return response._content
+        response = None
+        try:
+            response = requests.request(  # call method dynamically https://stackoverflow.com/a/4246075/2299554
+                method=method,
+                url=self._endpoint + path,
+                params=self.flatten(params),
+                data=self.flatten(data),
+                json=json,
+                files=files,
+                headers=headers,
+                verify=self._self_signed,
+            )
+
+            response.raise_for_status()
+
+            content_type = response.headers['Content-Type']
+
+            if content_type.startswith('application/json'):
+                return response.json()
+
+            return response._content
+        except Exception as e:
+            if response.json():
+                raise {{spec.title | caseUcfirst}}Exception(response.json()['message'], response.status_code, response.json())
+            else:
+                raise {{spec.title | caseUcfirst}}Exception(e)
 
     def flatten(self, data, prefix=''):
         output = {}

templates/python/package/exception.py.twig

@@ -0,0 +1,6 @@
+class {{spec.title | caseUcfirst}}Exception(Exception):
+    def __init__(self, message, code = 0, response = None):
+        self.message = message
+        self.code = code
+        self.response = response
+        super().__init__(self.message)

tests/SDKTest.php

@@ -158,7 +158,7 @@ class SDKTest extends TestCase
                 // 'python-3.2' => 'docker run --rm -v $(pwd):/app -w /app --env PIP_TARGET=tests/sdks/python/vendor --env PYTHONPATH=tests/sdks/python/vendor python:3.2 python tests/sdks/python/test.py',
                 // 'python-3.1' => 'docker run --rm -v $(pwd):/app -w /app --env PIP_TARGET=tests/sdks/python/vendor --env PYTHONPATH=tests/sdks/python/vendor python:3.1 python tests/sdks/python/test.py',
             ],
-            'supportException' => false,
+            'supportException' => true,
         ],
     ];
 

tests/languages/python/tests.py

@@ -2,6 +2,7 @@
 from appwrite.services.foo import Foo
 from appwrite.services.bar import Bar
 from appwrite.services.general import General
+from appwrite.exception import AppwriteException
 import os.path
 
 
@@ -52,3 +53,13 @@
 
 response = general.upload('string', 123, ['string in array'], open('./tests/resources/file.png', 'rb'))
 print(response['result'])
+
+try:
+    response = general.error400()
+except AppwriteException as e:
+    print(e.message)
+
+try:
+    response = general.error500()
+except AppwriteException as e:
+    print(e.message)