Merge pull request #124 from lohanidamodar/feat-deno-exceptions

Feat Deno SDK exception

Author: eldadfux

src/SDK/Language/Deno.php

@@ -36,6 +36,12 @@ public function getFiles()
                 'template'      => '/deno/src/service.ts.twig',
                 'minify'        => false,
             ],
+            [
+                'scope'         => 'default',
+                'destination'   => '/src/exception.ts',
+                'template'      => '/deno/src/exception.ts.twig',
+                'minify'        => false,
+            ],
             [
                 'scope'         => 'service',
                 'destination'   => '/src/services/{{service.name | caseDash}}.ts',

templates/deno/mod.ts.twig

@@ -1,10 +1,12 @@
 import { Client } from "./src/client.ts";
+import { {{spec.title | caseUcfirst}}Exception } from "./src/exception.ts";
 {% for service in spec.services %}
 import { {{service.name | caseUcfirst}} } from "./src/services/{{service.name | caseDash}}.ts";
 {% endfor %}
 
 export {
     Client,
+    {{spec.title | caseUcfirst}}Exception,
 {% for service in spec.services %}
     {{service.name | caseUcfirst}},
 {% endfor %}

templates/deno/src/client.ts.twig

@@ -1,3 +1,5 @@
+import { {{ spec.title | caseUcfirst}}Exception } from './exception.ts';
+
 export interface DocumentData {
     [key: string]: any;
 }
@@ -87,14 +89,22 @@ export class Client {
             body: body,
         };
 
-        let response = await fetch(url.toString(), options);
-        const contentType = response.headers.get('content-type');
+        try {
+            let response = await fetch(url.toString(), options);
+            const contentType = response.headers.get('content-type');
 
-        if (contentType && contentType.includes('application/json')) {
-            return response.json()
-        }
+            if(response.status >= 400) {
+                let res = await response.json();
+                throw new {{ spec.title | caseUcfirst}}Exception(res.message, res.status, res);
+            }
 
-        return response;
+            if (contentType && contentType.includes('application/json')) {
+                return response.json()
+            }
+            return response;
+        } catch(error) {
+            throw new {{ spec.title | caseUcfirst}}Exception(error?.response?.message || error.message, error?.response?.code, error.response);
+        }
     }
 
     flatten(data: DocumentData, prefix = '') {

templates/deno/src/exception.ts.twig

@@ -0,0 +1,12 @@
+export class {{ spec.title | caseUcfirst}}Exception {
+    message: String;
+    code: Number;
+    response: any;
+
+    constructor(message: String, code: Number, response: any) {
+        this.message = message;
+        this.code = code;
+        this.response = response;
+    }
+
+}

tests/SDKTest.php

@@ -110,7 +110,7 @@ class SDKTest extends TestCase
             'envs' => [
                 'deno-1.1.3' => 'docker run --rm -v $(pwd):/app -w /app hayd/alpine-deno:1.1.3 run --allow-net --allow-read tests/languages/deno/tests.ts', // TODO: use official image when its out
             ],
-            'supportException' => false,
+            'supportException' => true,
         ],
 
         'node' => [

tests/languages/deno/tests.ts

@@ -71,6 +71,18 @@ async function start() {
   response = await general.upload('string', 123, ['string in array'], file)
   // @ts-ignore
   console.log(response.result)
+
+  try {
+    response = await general.error400();
+  }catch(error){
+    console.log(error.message);
+  }
+
+  try {
+    response = await general.error500();
+  }catch(error){
+    console.log(error.message);
+  }
 }
 
 start()