Skip to content

Commit 4ce7c8f

Browse files
committed
Don't isset/null check unnecessarily
1 parent 659f086 commit 4ce7c8f

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

templates/php/base/params.twig

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,17 @@
11
$apiParams = [];
22
{% if method.parameters.all | length %}
33
{% for parameter in method.parameters.all %}
4-
{% if parameter.required and not parameter.nullable %}
5-
if (!isset(${{ parameter.name | caseCamel | escapeKeyword }})) {
6-
throw new {{spec.title | caseUcfirst}}Exception('Missing required parameter: "{{ parameter.name | caseCamel | escapeKeyword }}"');
7-
}
8-
{% endif %}
9-
{% endfor %}
10-
{% for parameter in method.parameters.query %}
11-
if (!is_null(${{ parameter.name | caseCamel | escapeKeyword }})) {
12-
$apiParams['{{ parameter.name }}'] = ${{ parameter.name | caseCamel | escapeKeyword }};
13-
}
14-
{% endfor %}
15-
{% for parameter in method.parameters.body %}
16-
if (!is_null(${{ parameter.name | caseCamel | escapeKeyword }})) {
17-
$apiParams['{{ parameter.name }}'] = ${{ parameter.name | caseCamel | escapeKeyword }};
18-
}
19-
{% endfor %}
20-
{% for parameter in method.parameters.formData %}
4+
{% if not parameter.required and not parameter.nullable %}
5+
216
if (!is_null(${{ parameter.name | caseCamel | escapeKeyword }})) {
227
$apiParams['{{ parameter.name }}'] = ${{ parameter.name | caseCamel | escapeKeyword }};
238
}
9+
{% else %}
10+
$apiParams['{{ parameter.name }}'] = ${{ parameter.name | caseCamel | escapeKeyword }};
11+
{% endif %}
2412
{% endfor %}
2513
{% endif %}
14+
2615
$apiHeaders = [];
2716
{%~ for parameter in method.parameters.header %}
2817
$apiHeaders['{{ parameter.name }}'] = ${{ parameter.name | caseCamel | escapeKeyword }};

0 commit comments

Comments
 (0)