Skip to content

Commit 74da3b5

Browse files
committed
Remove variadic params from JS platforms for and/or queries
1 parent 3fe8910 commit 74da3b5

File tree

7 files changed

+25
-33
lines changed

7 files changed

+25
-33
lines changed

templates/deno/src/query.ts.twig

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -96,17 +96,9 @@ export class Query {
9696
static contains = (attribute: string, value: string | string[]): string =>
9797
new Query("contains", attribute, value).toString();
9898

99-
static or = (...queries: string[]) =>
100-
new Query(
101-
"or",
102-
undefined,
103-
queries.map((query) => JSON.parse(query))
104-
).toString();
105-
106-
static and = (...queries: string[]) =>
107-
new Query(
108-
"and",
109-
undefined,
110-
queries.map((query) => JSON.parse(query))
111-
).toString();
99+
static or = (queries: string[]) =>
100+
new Query("or", undefined, queries.map((query) => JSON.parse(query))).toString();
101+
102+
static and = (queries: string[]) =>
103+
new Query("and", undefined, queries.map((query) => JSON.parse(query))).toString();
112104
}

templates/node/lib/query.js.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ class Query {
7272
static contains = (attribute, value) =>
7373
new Query("contains", attribute, value).toString()
7474

75-
static or = (...queries) =>
75+
static or = (queries) =>
7676
new Query("or", undefined, queries.map((query) => JSON.parse(query))).toString()
7777

78-
static and = (...queries) =>
78+
static and = (queries) =>
7979
new Query("and", undefined, queries.map((query) => JSON.parse(query))).toString();
8080
}
8181

templates/web/src/query.ts.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ export class Query {
9393
static contains = (attribute: string, value: string | string[]): string =>
9494
new Query("contains", attribute, value).toString();
9595

96-
static or = (...queries: string[]) =>
96+
static or = (queries: string[]) =>
9797
new Query("or", undefined, queries.map((query) => JSON.parse(query))).toString();
9898

99-
static and = (...queries: string[]) =>
99+
static and = (queries: string[]) =>
100100
new Query("and", undefined, queries.map((query) => JSON.parse(query))).toString();
101101
}

tests/languages/deno/tests.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,14 +157,14 @@ async function start() {
157157
console.log(Query.offset(20));
158158
console.log(Query.contains("title", "Spider"));
159159
console.log(Query.contains("labels", "first"));
160-
console.log(Query.or(
160+
console.log(Query.or([
161161
Query.equal("released", true),
162162
Query.lessThan("releasedYear", 1990)
163-
));
164-
console.log(Query.and(
163+
]));
164+
console.log(Query.and([
165165
Query.equal("released", false),
166166
Query.greaterThan("releasedYear", 2015)
167-
));
167+
]));
168168

169169
// Permission & Role helper tests
170170
console.log(Permission.read(Role.any()));

tests/languages/node/test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,14 @@ async function start() {
122122
console.log(Query.offset(20));
123123
console.log(Query.contains("title", "Spider"));
124124
console.log(Query.contains("labels", "first"));
125-
console.log(Query.or(
125+
console.log(Query.or([
126126
Query.equal("released", true),
127127
Query.lessThan("releasedYear", 1990)
128-
));
129-
console.log(Query.and(
128+
]));
129+
console.log(Query.and([
130130
Query.equal("released", false),
131131
Query.greaterThan("releasedYear", 2015)
132-
));
132+
]));
133133

134134
// Permission & Role helper tests
135135
console.log(Permission.read(Role.any()));

tests/languages/web/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,14 @@
143143
console.log(Query.offset(20));
144144
console.log(Query.contains("title", "Spider"));
145145
console.log(Query.contains("labels", "first"));
146-
console.log(Query.or(
146+
console.log(Query.or([
147147
Query.equal("released", true),
148148
Query.lessThan("releasedYear", 1990)
149-
));
150-
console.log(Query.and(
149+
]));
150+
console.log(Query.and([
151151
Query.equal("released", false),
152152
Query.greaterThan("releasedYear", 2015)
153-
));
153+
]));
154154

155155
// Permission & Role helper tests
156156
console.log(Permission.read(Role.any()));

tests/languages/web/node.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@ async function start() {
9898
console.log(Query.offset(20));
9999
console.log(Query.contains("title", "Spider"));
100100
console.log(Query.contains("labels", "first"));
101-
console.log(Query.or(
101+
console.log(Query.or([
102102
Query.equal("released", true),
103103
Query.lessThan("releasedYear", 1990)
104-
));
105-
console.log(Query.and(
104+
]));
105+
console.log(Query.and([
106106
Query.equal("released", false),
107107
Query.greaterThan("releasedYear", 2015)
108-
));
108+
]));
109109

110110
// Permission & Role helper tests
111111
console.log(Permission.read(Role.any()));

0 commit comments

Comments
 (0)