Merge pull request #548 from appwrite/fix-python-queries

Fix bool values in queries

Author: eldadfux

templates/php/src/Query.php.twig

@@ -167,6 +167,12 @@ class Query
      */
     private static function parseValues($value): string
     {
-        return is_string($value) ? '"' . $value . '"' : $value;
+        if (is_string($value)) {
+            return '"' . $value . '"';
+        }
+        if (is_bool($value)) {
+            return $value ? 'true' : 'false';
+        }
+        return $value;
     }
 }

templates/python/package/query.py.twig

@@ -62,5 +62,7 @@ class Query:
     def parseValues(value):
         if type(value) == str:
             return f'"{value}"'
+        elif type(value) == bool:
+            return str(value).lower()
         else:
             return str(value)

tests/Base.php

@@ -59,6 +59,7 @@ abstract class Base extends TestCase
     ];
 
     const QUERY_HELPER_RESPONSES = [
+        'equal("released", [true])',
         'equal("title", ["Spiderman","Dr. Strange"])',
         'notEqual("title", ["Spiderman"])',
         'lessThan("releasedYear", [1990])',

tests/languages/android/Tests.kt

@@ -161,6 +161,7 @@ class ServiceTest {
             general.empty()
 
             // Query helper tests
+            writeToFile(Query.equal("released", listOf(true)))
             writeToFile(Query.equal("title", listOf("Spiderman", "Dr. Strange")))
             writeToFile(Query.notEqual("title", "Spiderman"))
             writeToFile(Query.lessThan("releasedYear", 1990))

tests/languages/dart/tests.dart

@@ -89,6 +89,7 @@ void main() async {
   await general.empty();
 
   // Query helper tests
+  print(Query.equal('released', [true]));
   print(Query.equal('title', ['Spiderman', 'Dr. Strange']));
   print(Query.notEqual('title', 'Spiderman'));
   print(Query.lessThan('releasedYear', 1990));

tests/languages/deno/tests.ts

@@ -98,6 +98,7 @@ async function start() {
   await general.empty();
 
   // Query helper tests
+  console.log(Query.equal('released', [true]));
   console.log(Query.equal('title', ['Spiderman', 'Dr. Strange']));
   console.log(Query.notEqual('title', 'Spiderman'));
   console.log(Query.lessThan('releasedYear', 1990));

tests/languages/flutter/tests.dart

@@ -109,6 +109,7 @@ void main() async {
   await general.empty();
 
   // Query helper tests
+  print(Query.equal('released', [true]));
   print(Query.equal('title', ['Spiderman', 'Dr. Strange']));
   print(Query.notEqual('title', 'Spiderman'));
   print(Query.lessThan('releasedYear', 1990));

tests/languages/kotlin/Tests.kt

@@ -121,6 +121,7 @@ class ServiceTest {
             general.empty()
 
             // Query helper tests
+            writeToFile(Query.equal("released", listOf(true)))
             writeToFile(Query.equal("title", listOf("Spiderman", "Dr. Strange")))
             writeToFile(Query.notEqual("title", "Spiderman"))
             writeToFile(Query.lessThan("releasedYear", 1990))

tests/languages/node/test.js

@@ -86,6 +86,7 @@ async function start() {
     await general.empty();
 
     // Query helper tests
+    console.log(Query.equal('released', [true]));
     console.log(Query.equal('title', ['Spiderman', 'Dr. Strange']));
     console.log(Query.notEqual('title', 'Spiderman'));
     console.log(Query.lessThan('releasedYear', 1990));

tests/languages/php/test.php

@@ -104,6 +104,7 @@
 $general->empty();
 
 // Query helper tests
+echo Query::equal('released', [true]) . "\n";
 echo Query::equal('title', ['Spiderman', 'Dr. Strange']) . "\n";
 echo Query::notEqual('title', 'Spiderman') . "\n";
 echo Query::lessThan('releasedYear', 1990) . "\n";