fix review comments

Author: lohanidamodar

templates/react-native/src/client.ts.twig

@@ -338,10 +338,6 @@ class Client {
             credentials: 'include'
         };
 
-        if (typeof window !== 'undefined' && window.localStorage) {
-            headers['X-Fallback-Cookies'] = window.localStorage.getItem('cookieFallback') ?? '';
-        }
-
         if (method === 'GET') {
             for (const [key, value] of Object.entries(Service.flatten(params))) {
                 url.searchParams.append(key, value);

templates/react-native/src/id.ts.twig

@@ -1,9 +1,28 @@
 export class ID {
+    // Generate an hex ID based on timestamp
+    // Recreated from https://www.php.net/manual/en/function.uniqid.php
+    static #hexTimestamp(): string {
+        const now = new Date();
+        const sec = Math.floor(now.getTime() / 1000);
+        const msec = now.getMilliseconds();
+
+        // Convert to hexadecimal
+        const hexTimestamp = sec.toString(16) + msec.toString(16).padStart(5, '0');
+        return hexTimestamp;
+    }
+
     public static custom(id: string): string {
         return id
     }
-    
-    public static unique(): string {
-        return 'unique()'
+
+    public static unique(padding: number = 7): string {
+        // Generate a unique ID with padding to have a longer ID
+        const baseId = ID.#hexTimestamp();
+        let randomPadding = '';
+        for (let i = 0; i < padding; i++) {
+            const randomHexDigit = Math.floor(Math.random() * 16).toString(16);
+            randomPadding += randomHexDigit;
+        }
+        return baseId + randomPadding;
     }
-}
+}

templates/react-native/src/services/template.ts.twig

@@ -84,11 +84,7 @@ export class {{ service.name | caseUcfirst }} extends Service {
         }
 {% endif %}
 {% if method.type == 'webAuth' %}
-        if (typeof window !== 'undefined' && window?.location) {
-            window.location.href = uri.toString();
-        } else {
-            return uri;
-        }
+        throw new {{ spec.title | caseUcfirst}}Exception('Not yet supported');
 {% elseif method.type == 'location' %}
         return uri;
 {% else %}