Merge pull request #286 from appwrite/fix-node-exception

fix(node): exception condition

Author: eldadfux

templates/node/lib/client.js.twig

@@ -115,10 +115,10 @@ class Client {
             let response = await axios(options);
             return response.data;
         } catch(error) {
-            if('response' in error) {
+            if('response' in error && error.response !== undefined) {
                 if(error.response && 'data' in error.response) {
                     if (typeof(error.response.data) === 'string') {
-                        throw new {{spec.title | caseUcfirst}}Exception(error.response.data, error.response.status, error.response.data);   
+                        throw new {{spec.title | caseUcfirst}}Exception(error.response.data, error.response.status, error.response.data);
                     } else {
                         throw new {{spec.title | caseUcfirst}}Exception(error.response.data.message, error.response.status, error.response.data);
                     }

tests/SDKTest.php

@@ -21,8 +21,8 @@ class SDKTest extends TestCase
             'build' => [
             ],
             'envs' => [
-                'php-7.0' => 'docker run --rm -v $(pwd):/app -w /app php:7.0-cli-alpine php tests/languages/php/test.php',
-                'php-8.0' => 'docker run --rm -v $(pwd):/app -w /app php:8.0.0rc1-cli-alpine php tests/languages/php/test.php',
+                'php-7.4' => 'docker run --rm -v $(pwd):/app -w /app php:7.4-cli-alpine php tests/languages/php/test.php',
+                'php-8.0' => 'docker run --rm -v $(pwd):/app -w /app php:8.0-cli-alpine php tests/languages/php/test.php',
             ],
             'supportException' => true,
         ],
@@ -142,12 +142,12 @@ class SDKTest extends TestCase
         'node' => [
             'class' => 'Appwrite\SDK\Language\Node',
             'build' => [
-                'docker run --rm -v $(pwd):/app -w /app/tests/sdks/node node:12.12-alpine npm install',
+                'docker run --rm -v $(pwd):/app -w /app/tests/sdks/node node:16-alpine npm install',
             ],
             'envs' => [
                 'nodejs-12' => 'docker run --rm -v $(pwd):/app -w /app node:12-alpine node tests/languages/node/test.js',
                 'nodejs-14' => 'docker run --rm -v $(pwd):/app -w /app node:14-alpine node tests/languages/node/test.js',
-                'nodejs-16' => 'docker run --rm -v $(pwd):/app -w /app node:14-alpine node tests/languages/node/test.js',
+                'nodejs-16' => 'docker run --rm -v $(pwd):/app -w /app node:16-alpine node tests/languages/node/test.js',
             ],
             'supportException' => true,
         ],