Skip to content

Commit e0a430a

Browse files
committed
fix: add types to lists, and fix doc blocks
1 parent 1434449 commit e0a430a

File tree

4 files changed

+23
-11
lines changed

4 files changed

+23
-11
lines changed

example.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ function getSSLPage($url) {
220220

221221
$sdk
222222
->setName('NAME')
223+
->setVersion('7.2.0')
223224
->setDescription('Repo description goes here')
224225
->setShortDescription('Repo short description goes here')
225226
->setURL('https://example.com')

src/SDK/Language/Python.php

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -231,16 +231,26 @@ public function getTypeName(array $parameter, array $spec = []): string
231231
if (!empty($parameter['enumValues'])) {
232232
return \ucfirst($parameter['name']);
233233
}
234-
return match ($parameter['type'] ?? '') {
235-
self::TYPE_FILE => 'InputFile',
236-
self::TYPE_NUMBER,
237-
self::TYPE_INTEGER => 'float',
238-
self::TYPE_BOOLEAN => 'bool',
239-
self::TYPE_STRING => 'str',
240-
self::TYPE_ARRAY => 'list',
241-
self::TYPE_OBJECT => 'dict',
242-
default => $parameter['type'],
243-
};
234+
switch ($parameter['type'] ?? '') {
235+
case self::TYPE_FILE:
236+
return 'InputFile';
237+
case self::TYPE_NUMBER:
238+
case self::TYPE_INTEGER:
239+
return 'float';
240+
case self::TYPE_BOOLEAN:
241+
return 'bool';
242+
case self::TYPE_STRING:
243+
return 'str';
244+
case self::TYPE_ARRAY:
245+
if (!empty(($parameter['array'] ?? [])['type']) && !\is_array($parameter['array']['type'])) {
246+
return 'list[' . $this->getTypeName($parameter['array']) . ']';
247+
}
248+
return 'list[str]';
249+
case self::TYPE_OBJECT:
250+
return 'dict';
251+
default:
252+
return $parameter['type'];
253+
}
244254
}
245255

246256
/**

templates/python/package/client.py.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class Client:
1313
self._endpoint = '{{spec.endpoint}}'
1414
self._global_headers = {
1515
'content-type': '',
16-
'user-agent' : '{{spec.title | caseUcfirst}}{{ language.name | caseUcfirst }}SDK/{{ sdk.version }} (${os.uname().sysname}; ${os.uname().version}; ${os.uname().machine})',
16+
'user-agent' : f'{{spec.title | caseUcfirst}}{{ language.name | caseUcfirst }}SDK/{{ sdk.version }} ({os.uname().sysname}; {os.uname().version}; {os.uname().machine})',
1717
'x-sdk-name': '{{ sdk.name }}',
1818
'x-sdk-platform': '{{ sdk.platform }}',
1919
'x-sdk-language': '{{ language.name | caseLower }}',

templates/python/package/services/service.py.twig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ class {{ service.name | caseUcfirst }}(Service):
2828
{% for method in service.methods %}
2929

3030
def {{ method.name | caseSnake }}(self{% if method.parameters.all|length > 0 %}, {% endif %}{% for parameter in method.parameters.all %}{{ parameter.name | escapeKeyword | caseSnake }}: {{ parameter | getPropertyType(method) | raw }}{% if not parameter.required %} = None{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, on_progress = None{% endif %}):
31+
"""{{method.title}}"""
3132

3233
api_path = '{{ method.path }}'
3334
{{ include('python/base/params.twig') }}

0 commit comments

Comments
 (0)