Merge pull request #755 from appwrite/fix-node-enum

Ensure pascal case used for node enums

Author: abnegate

src/SDK/Language/Deno.php

@@ -181,13 +181,4 @@ public function getParamExample(array $param): string
 
         return $output;
     }
-
-    public function getFilters(): array
-    {
-        return [
-            new TwigFilter('caseEnumKey', function (string $value) {
-                return $this->toPascalCase($value);
-            }),
-        ];
-    }
 }

src/SDK/Language/JS.php

@@ -205,7 +205,7 @@ public function getFilters(): array
     {
         return [
             new TwigFilter('caseEnumKey', function (string $value) {
-                return $this->toUpperSnakeCase($value);
+                return $this->toPascalCase($value);
             }),
         ];
     }

src/SDK/Language/Node.php

@@ -14,7 +14,7 @@ public function getName(): string
 
     /**
      * @param array $parameter
-     * @param array $nestedTypes
+     * @param array $spec
      * @return string
      */
     public function getTypeName(array $parameter, array $spec = []): string

templates/node/lib/enums/enum.js.twig

@@ -1,7 +1,7 @@
 const {{ enum.name | caseUcfirst | overrideIdentifier }} = {
 {% for value in enum.enum %}
 {% set key = enum.keys is empty ? value : enum.keys[loop.index0] %}
-    {{ key | caseCamel | replace({'-': '',' ': ''})}}: '{{value}}' {% if not loop.last %},{% endif %}
+    {{ key | replace({'-': '',' ': ''}) | caseEnumKey }}: '{{value}}' {% if not loop.last %},{% endif %}
 
 {% endfor %}
 }

templates/web/src/enums/enum.ts.twig

@@ -1,6 +1,6 @@
 export enum {{ enum.name | caseUcfirst  }} {
 {% for value in enum.enum %}
 {% set key = enum.keys is empty ? value : enum.keys[loop.index0] %}
-    {{ key | caseUcfirst | replace({'-': ''})}} = '{{ value }}',
+    {{ key | replace({'-': ''}) | caseEnumKey }} = '{{ value }}',
 {% endfor %}
 }

tests/languages/node/test.js

@@ -76,7 +76,7 @@ async function start() {
     response = await general.upload('string', 123, ['string in array'], appwrite.InputFile.fromBuffer(buffer, 'large_file.mp4'))
     console.log(response.result);
 
-    response = await general.enum(MockType.first);
+    response = await general.enum(MockType.First);
     console.log(response.result);
 
     try {