feat(cli): Hooking migration before any command

Author: byawitz

templates/cli/index.js.twig

@@ -11,7 +11,7 @@ const { version } = require("./package.json");
 const { commandDescriptions, cliConfig } = require("./lib/parser");
 const { client } = require("./lib/commands/generic");
 {% if sdk.test != "true" %}
-const { login, logout, whoami } = require("./lib/commands/generic");
+const { login, logout, whoami, migrate } = require("./lib/commands/generic");
 const { pull } = require("./lib/commands/pull");
 const { push } = require("./lib/commands/push");
 {% endif %}
@@ -28,6 +28,7 @@ program
   .version(version, "-v, --version")
   .option("--verbose", "Show complete error log")
   .option("--json", "Output in JSON format")
+  .hook('preAction',migrate)
   .on("option:json", () => {
     cliConfig.json = true;
   })

templates/cli/lib/commands/generic.js.twig

@@ -3,7 +3,7 @@ const { Command } = require("commander");
 const Client = require("../client");
 const { sdkForConsole, questionGetEndpoint } = require("../sdks");
 const { globalConfig, localConfig } = require("../config");
-const { actionRunner, success, parseBool, commandDescriptions, error, parse, drawTable } = require("../parser");
+const { actionRunner, success, parseBool, commandDescriptions, error, parse,log, drawTable } = require("../parser");
 {% if sdk.test != "true" %}
 const { questionsLogin, questionsListFactors, questionsMfaChallenge } = require("../questions");
 const { accountUpdateMfaChallenge, accountCreateMfaChallenge, accountGet, accountCreateEmailPasswordSession, accountDeleteSession } = require("./account");
@@ -161,33 +161,6 @@ login
         success(`Current account is ${accountId}`);
     }));
 
-login
-    .command('migrate')
-    .description("Migrate existing login to new scheme")
-    .action(actionRunner(async ({ accountId }) => {
-        const endpoint = globalConfig.getEndpoint();
-        const cookie = globalConfig.getCookie();
-
-        if (endpoint === '' || cookie === '') {
-            throw Error(`Couldn't find any existing account credentials`)
-        }
-
-        const id = ID.unique();
-        const data = {
-            endpoint,
-            cookie,
-            email: 'legacy'
-        };
-
-        globalConfig.addLogin(id, data);
-        globalConfig.setCurrentLogin(id);
-        globalConfig.delete('endpoint');
-        globalConfig.delete('cookie');
-
-        success(`Account was migrated and it's the current account`);
-    }));
-
-
 const logout = new Command("logout")
     .description(commandDescriptions['logout'])
     .configureHelp({
@@ -280,11 +253,35 @@ const client = new Command("client")
         success()
     }));
 
+const migrate = async ()=>{
+    if (!globalConfig.has('endpoint') || !globalConfig.has('cookie')) {
+        return;
+    }
+
+    const endpoint = globalConfig.get('endpoint');
+    const cookie = globalConfig.get('cookie');
+
+    log("Old Appwrite login settings were detected, migrating...");
+    const id = ID.unique();
+    const data = {
+        endpoint,
+        cookie,
+        email: 'legacy'
+    };
+
+    globalConfig.addLogin(id, data);
+    globalConfig.setCurrentLogin(id);
+    globalConfig.delete('endpoint');
+    globalConfig.delete('cookie');
+
+    success(`Account was migrated and it's the current account`);
+}
 module.exports = {
     {% if sdk.test != "true" %}
     whoami,
     login,
     logout,
+    migrate,
     {% endif %}
     client
 };

templates/cli/lib/config.js.twig

@@ -467,46 +467,35 @@ class Global extends Config {
         this.setTo(Global.PREFERENCE_KEY, key);
     }
 
+
     hasFrom(key) {
-        try {
-            const current = this.getCurrentLogin();
+        const current = this.getCurrentLogin();
 
-            if (current) {
-                const config = this.get(current);
+        if (current) {
+            const config = this.get(current);
 
-                return config[key] !== undefined;
-            }
-        } catch {
-            return this.has(key);
+            return config[key] !== undefined;
         }
     }
 
     getFrom(key) {
-        try {
-            const current = this.getCurrentLogin();
+        const current = this.getCurrentLogin();
 
-            if (current) {
-                const config = this.get(current);
+        if (current) {
+            const config = this.get(current);
 
-                return config[key];
-            }
-        } catch {
-            return this.get(key);
+            return config[key];
         }
     }
 
     setTo(key, value) {
-        try {
-            const current = this.getCurrentLogin();
+        const current = this.getCurrentLogin();
 
-            if (current) {
-                const config = this.get(current);
+        if (current) {
+            const config = this.get(current);
 
-                config[key] = value;
-                this.write();
-            }
-        } catch {
-            this.set(key, value);
+            config[key] = value;
+            this.write();
         }
     }
 }