Merge pull request #2016 from appwrite/fix-accidental-target-self

TorstenDittmann · web-flow · commit 838251aa30eb · 2025-05-21T19:45:30.000+02:00
Fix target attribute for non-external sidebar links
diff --git a/src/lib/layouts/SidebarNavButton.svelte b/src/lib/layouts/SidebarNavButton.svelte
@@ -9,7 +9,7 @@
     class="web-side-nav-button flex size-10 w-full items-center rounded-lg p-2 whitespace-nowrap"
     class:is-selected={page.url?.pathname === groupItem.href}
     href={groupItem.href}
-    target={groupItem.openInNewTab ? '_blank' : '_self'}
+    target={groupItem.openInNewTab ? '_blank' : undefined}
 >
     {#if groupItem.icon}
         <span class="icon {groupItem.icon}" aria-hidden="true"></span>

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`class="web-side-nav-button flex size-10 w-full items-center rounded-lg p-2 whitespace-nowrap"`
`10`	`10`	`class:is-selected={page.url?.pathname === groupItem.href}`
`11`	`11`	`href={groupItem.href}`
`12`		`- target={groupItem.openInNewTab ? '_blank' : '_self'}`
	`12`	`+ target={groupItem.openInNewTab ? '_blank' : undefined}`
`13`	`13`	`>`
`14`	`14`	`{#if groupItem.icon}`
`15`	`15`	`<span class="icon {groupItem.icon}" aria-hidden="true"></span>`