Skip to content

Commit b594b57

Browse files
apstndbclaude
apstndb
and
claude
authored
test: complete test parallelization for improved performance (#451)
## Summary This PR completes the test suite optimization by adding parallel execution to all tests (both unit and integration), reducing the DatabaseExists timeout, and parallelizing CI jobs for improved performance. ## Changes ### Test Parallelization - Added `t.Parallel()` to all unit test functions (~180 tests) - Integration tests already had `t.Parallel()` at top level from previous commits - Excluded tests using `t.Setenv()` due to Go testing constraints: - TestFlagSystemVariablePrecedence - TestDetermineInitialDatabase - TestComplexFlagInteractions ### CI Workflow Optimization - Split `lint` and `test` into independent jobs that run in parallel - Added proper permissions for golangci-lint job (contents: read, pull-requests: read) - Following golangci-lint best practices for parallel execution ### DatabaseExists Improvements - Made context-aware by accepting context parameter - Reduced timeout from 30s → 5s (more reasonable for simple API call) - Fixed non-existent database test to use real instance ## Performance Impact - TestRunMCP/database_does_not_exist: 34.87s → 5.63s (84% improvement) - CI pipeline now runs tests and linting in parallel - Overall test suite: ~26-28s (limited by intentional delays in timeout tests) ## Technical Details - Tests with intentional 10s delays (TestReadWriteTransaction, TestReadOnlyTransaction) run in parallel - Default `-parallel` (GOMAXPROCS) is optimal due to emulator concurrency limits - All tests properly isolated with instance-level separation Co-authored-by: Claude <noreply@anthropic.com>
1 parent 790e4dd commit b594b57

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+253
-18
lines changed

‎.github/workflows/run-tests.yaml‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,12 @@ on:
2121

2222
name: CI
2323
jobs:
24-
test:
24+
# Run linting in a separate job for parallel execution
25+
lint:
2526
runs-on: ubuntu-latest
2627
permissions:
27-
pull-requests: write
28+
contents: read
29+
pull-requests: read
2830
steps:
2931
- uses: actions/checkout@v4
3032
- uses: actions/setup-go@v5
@@ -36,6 +38,18 @@ jobs:
3638
with:
3739
version: v2.1
3840
args: --timeout=5m
41+
42+
# Run tests in a separate job for parallel execution
43+
test:
44+
runs-on: ubuntu-latest
45+
permissions:
46+
pull-requests: write
47+
steps:
48+
- uses: actions/checkout@v4
49+
- uses: actions/setup-go@v5
50+
with:
51+
go-version: '1.24'
52+
- run: go version
3953
- name: run tests with coverage
4054
run: make test-coverage
4155
- name: Upload coverage HTML report

‎cli.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func (c *Cli) GetInStream() io.ReadCloser {
9797
func (c *Cli) RunInteractive(ctx context.Context) error {
9898
// Only check database existence if we're not in detached mode
9999
if !c.SessionHandler.IsDetached() {
100-
exists, err := c.SessionHandler.DatabaseExists()
100+
exists, err := c.SessionHandler.DatabaseExists(ctx)
101101
if err != nil {
102102
return NewExitCodeError(c.ExitOnError(err))
103103
}

‎cli_current_width_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
)
1010

1111
func TestCliCurrentWidthWithTee(t *testing.T) {
12+
t.Parallel()
1213
// Test that CLI_CURRENT_WIDTH works correctly when --tee is enabled
1314
// and StreamManager is used
1415

‎cli_mcp.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ Use "HELP" command to see all available statements and their syntax.`)
142142

143143
// RunMCP runs the MCP server
144144
func (c *Cli) RunMCP(ctx context.Context) error {
145-
exists, err := c.SessionHandler.DatabaseExists()
145+
exists, err := c.SessionHandler.DatabaseExists(ctx)
146146
if err != nil {
147147
return err
148148
}

‎cli_output_test.go‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
)
1212

1313
func TestPrintTableDataHTML(t *testing.T) {
14+
t.Parallel()
1415
tests := []struct {
1516
name string
1617
result *Result
@@ -104,6 +105,7 @@ func TestPrintTableDataHTML(t *testing.T) {
104105
}
105106

106107
func TestPrintTableDataXML(t *testing.T) {
108+
t.Parallel()
107109
tests := []struct {
108110
name string
109111
result *Result
@@ -225,6 +227,7 @@ func TestPrintTableDataXML(t *testing.T) {
225227
}
226228

227229
func TestCLIFormatSystemVariable(t *testing.T) {
230+
t.Parallel()
228231
tests := []struct {
229232
name string
230233
setValue string
@@ -262,6 +265,7 @@ func TestCLIFormatSystemVariable(t *testing.T) {
262265
}
263266

264267
func TestCLIFormatSystemVariableGetter(t *testing.T) {
268+
t.Parallel()
265269
tests := []struct {
266270
mode enums.DisplayMode
267271
wantStr string
@@ -296,6 +300,7 @@ func TestCLIFormatSystemVariableGetter(t *testing.T) {
296300
}
297301

298302
func TestPrintTableDataEdgeCases(t *testing.T) {
303+
t.Parallel()
299304
tests := []struct {
300305
name string
301306
mode enums.DisplayMode
@@ -373,6 +378,7 @@ func TestPrintTableDataEdgeCases(t *testing.T) {
373378
}
374379

375380
func TestHTMLAndXMLHelpers(t *testing.T) {
381+
t.Parallel()
376382
t.Run("formatHTML with empty input", func(t *testing.T) {
377383
var buf bytes.Buffer
378384
result := &Result{Rows: []Row{}}
@@ -446,6 +452,7 @@ func TestHTMLAndXMLHelpers(t *testing.T) {
446452
}
447453

448454
func TestPrintTableDataCSV(t *testing.T) {
455+
t.Parallel()
449456
tests := []struct {
450457
name string
451458
result *Result
@@ -555,6 +562,7 @@ func TestPrintTableDataCSV(t *testing.T) {
555562
}
556563

557564
func TestSQLExportFallbackForNonDataStatements(t *testing.T) {
565+
t.Parallel()
558566
tests := []struct {
559567
name string
560568
hasSQLFormatted bool
@@ -657,6 +665,7 @@ func testResultLineSuppression(t *testing.T, sysVars *systemVariables, result *R
657665
}
658666

659667
func TestSuppressResultLines(t *testing.T) {
668+
t.Parallel()
660669
tests := []struct {
661670
name string
662671
suppressResultLines bool
@@ -727,6 +736,7 @@ func TestSuppressResultLines(t *testing.T) {
727736
}
728737

729738
func TestSuppressResultLinesDMLAndDDL(t *testing.T) {
739+
t.Parallel()
730740
tests := []struct {
731741
name string
732742
suppressResultLines bool

‎cli_readline_test.go‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
)
1818

1919
func TestLexerHighlighterWithError(t *testing.T) {
20+
t.Parallel()
2021
tests := []struct {
2122
name string
2223
input string
@@ -78,6 +79,7 @@ func TestLexerHighlighterWithError(t *testing.T) {
7879
}
7980

8081
func TestTokenHighlighter(t *testing.T) {
82+
t.Parallel()
8183
tests := []struct {
8284
name string
8385
input string
@@ -131,6 +133,7 @@ func TestTokenHighlighter(t *testing.T) {
131133
}
132134

133135
func TestKindHighlighter(t *testing.T) {
136+
t.Parallel()
134137
tests := []struct {
135138
name string
136139
input string
@@ -170,6 +173,7 @@ func TestKindHighlighter(t *testing.T) {
170173
}
171174

172175
func TestCommentHighlighter(t *testing.T) {
176+
t.Parallel()
173177
tests := []struct {
174178
name string
175179
input string
@@ -226,6 +230,7 @@ func TestCommentHighlighter(t *testing.T) {
226230
}
227231

228232
func TestColorToSequence(t *testing.T) {
233+
t.Parallel()
229234
// Save original NoColor state
230235
originalNoColor := color.NoColor
231236
defer func() { color.NoColor = originalNoColor }()
@@ -272,6 +277,7 @@ func TestColorToSequence(t *testing.T) {
272277
}
273278

274279
func TestDefaultHighlights(t *testing.T) {
280+
t.Parallel()
275281
// Save and restore color setting
276282
originalNoColor := color.NoColor
277283
color.NoColor = false
@@ -298,6 +304,7 @@ func TestDefaultHighlights(t *testing.T) {
298304

299305
// Test error message constants
300306
func TestErrorMessages(t *testing.T) {
307+
t.Parallel()
301308
// Verify error constants are defined and not empty
302309
if errMessageUnclosedStringLiteral == "" {
303310
t.Error("errMessageUnclosedStringLiteral is empty")
@@ -312,6 +319,7 @@ func TestErrorMessages(t *testing.T) {
312319

313320
// Test with actual SQL patterns
314321
func TestHighlightingPatterns(t *testing.T) {
322+
t.Parallel()
315323
tests := []struct {
316324
name string
317325
input string
@@ -352,6 +360,7 @@ func TestHighlightingPatterns(t *testing.T) {
352360
// Tests for extracted validation functions
353361

354362
func TestShouldSubmitStatement(t *testing.T) {
363+
t.Parallel()
355364
tests := []struct {
356365
name string
357366
statements []inputStatement
@@ -434,6 +443,7 @@ func TestShouldSubmitStatement(t *testing.T) {
434443
}
435444

436445
func TestProcessInputLines(t *testing.T) {
446+
t.Parallel()
437447
tests := []struct {
438448
name string
439449
lines []string
@@ -511,6 +521,7 @@ func TestProcessInputLines(t *testing.T) {
511521
}
512522

513523
func TestValidateInteractiveInput(t *testing.T) {
524+
t.Parallel()
514525
tests := []struct {
515526
name string
516527
statements []inputStatement
@@ -573,6 +584,7 @@ func TestValidateInteractiveInput(t *testing.T) {
573584
}
574585

575586
func TestGeneratePS2Prompt(t *testing.T) {
587+
t.Parallel()
576588
tests := []struct {
577589
name string
578590
ps1 string
@@ -634,6 +646,7 @@ func TestGeneratePS2Prompt(t *testing.T) {
634646
// - The functions are called the correct number of times
635647
// - The correct prompt strings are written to the output
636648
func TestPS1PS2FuncToPromptFunc(t *testing.T) {
649+
t.Parallel()
637650
ps1Called := 0
638651
ps2Called := 0
639652
testPS1 := "test> "
@@ -716,6 +729,7 @@ func TestPS1PS2FuncToPromptFunc(t *testing.T) {
716729

717730
// Test persistentHistory.Add method
718731
func TestPersistentHistoryAdd(t *testing.T) {
732+
t.Parallel()
719733
tests := []struct {
720734
name string
721735
setupFS func() afero.Fs
@@ -853,6 +867,7 @@ func TestPersistentHistoryAdd(t *testing.T) {
853867

854868
// Test newPersistentHistoryWithFS function
855869
func TestNewPersistentHistoryWithFS(t *testing.T) {
870+
t.Parallel()
856871
tests := []struct {
857872
name string
858873
setupFS func() (afero.Fs, string)
@@ -1014,6 +1029,7 @@ func TestNewPersistentHistoryWithFS(t *testing.T) {
10141029

10151030
// Test persistentHistory.Len and persistentHistory.At methods
10161031
func TestPersistentHistoryLenAndAt(t *testing.T) {
1032+
t.Parallel()
10171033
tests := []struct {
10181034
name string
10191035
setup func() *persistentHistory
@@ -1104,6 +1120,7 @@ func TestPersistentHistoryLenAndAt(t *testing.T) {
11041120

11051121
// Test newPersistentHistory (the public function)
11061122
func TestNewPersistentHistory(t *testing.T) {
1123+
t.Parallel()
11071124
// Create a temporary file for testing
11081125
tmpFile, err := os.CreateTemp("", "test_history_*.txt")
11091126
require.NoError(t, err)

0 commit comments

Comments
 (0)