Update HTTP(S) endpoint shared default (#391)

* Default https endpoints to shared: nil

* Fold shared option into alb option

* Bump version

Author: joshraker

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    aptible-cli (0.24.10)
+    aptible-cli (0.25.0)
       activesupport (>= 4.0, < 6.0)
       aptible-api (~> 1.8.0)
       aptible-auth (~> 1.2.5)

lib/aptible/cli/helpers/vhost/option_set_builder.rb

@@ -12,7 +12,6 @@ class OptionSetBuilder
             ports
             port
             alb
-            shared
           ).freeze
 
           def initialize(&block)
@@ -63,6 +62,13 @@ def declare_options(thor)
                           'least_outstanding_requests, and ' \
                           'weighted_random'
                   )
+
+                  option(
+                    :shared,
+                    type: :boolean,
+                    desc: "Share this Endpoint's load balancer with other " \
+                          'Endpoints'
+                  )
                 end
               end
 
@@ -123,15 +129,6 @@ def declare_options(thor)
                         'on this Endpoint'
                 )
               end
-
-              if builder.shared?
-                option(
-                  :shared,
-                  type: :boolean,
-                  desc: "Share this Endpoint's load balancer with other " \
-                        'Endpoints'
-                )
-              end
             end
           end
 
@@ -203,11 +200,7 @@ def prepare(account, options)
                 params[:load_balancing_algorithm_type] = lba_type
               end
 
-              if shared?
-                params[:shared] = options.delete(:shared) do
-                  create? ? false : nil
-                end
-              end
+              params[:shared] = options.delete(:shared)
             end
 
             options.delete(:environment)

lib/aptible/cli/subcommands/endpoints.rb

@@ -160,7 +160,6 @@ def self.included(thor)
               port!
               tls!
               alb!
-              shared!
             end
 
             desc 'endpoints:https:create [--app APP] SERVICE',
@@ -180,7 +179,6 @@ def self.included(thor)
               port!
               tls!
               alb!
-              shared!
             end
 
             desc 'endpoints:https:modify [--app APP] ENDPOINT_HOSTNAME',

lib/aptible/cli/version.rb

@@ -1,5 +1,5 @@
 module Aptible
   module CLI
-    VERSION = '0.24.10'.freeze
+    VERSION = '0.25.0'.freeze
   end
 end