Skip to content

Commit 6edbe29

Browse files
committed
minor changes
1 parent cb63780 commit 6edbe29

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.github/workflows/replay-verify-testnet.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
# TODO: Remove pull_request from the if statement after testing
5353
replay:
5454
if: |
55-
github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request'
55+
github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
5656
needs: determine-test-metadata
5757
uses: ./.github/workflows/workflow-run-replay-verify-on-archive.yaml
5858
secrets: inherit

.github/workflows/workflow-run-replay-verify-on-archive.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,16 @@ on:
5050
description: If true, the workflow will not run replay verify.
5151
default: false
5252
jobs:
53-
54-
# Should only build images if IMAGE_TAG is provided; otherwise, we will find and use the latest image
5553
build-images:
5654
uses: aptos-labs/aptos-core/.github/workflows/workflow-run-docker-rust-build.yaml@jkao97/verify-and-build-images-for-workflows # TODO: change back to main
5755
with:
58-
GIT_SHA: ${{ inputs.IMAGE_TAG }}
59-
TARGET_CACHE_ID: ${{ github.ref_name }}
56+
GIT_SHA: ${{ inputs.IMAGE_TAG || github.event.pull_request.head.sha || github.sha }}
57+
TARGET_CACHE_ID: ${{ github.event.number && format('pr-{0}', github.event.number) || github.ref_name }}
6058

6159
run-replay-verify:
6260
runs-on: ubuntu-latest-32-core # consider moving this to a smaller machien since the compute runs on GKE
6361
timeout-minutes: 420 # 7 hours
6462
needs: build-images
65-
if: ${{ inputs.DRY_RUN == false }}
6663
steps:
6764
- name: Checkout code
6865
uses: actions/checkout@v4
@@ -113,6 +110,7 @@ jobs:
113110
pyproject_directory: testsuite/replay-verify
114111

115112
- name: Schedule replay verify
113+
if: ${{ inputs.DRY_RUN == false }}
116114
env:
117115
GOOGLE_CLOUD_PROJECT: aptos-devinfra-0
118116
run: |
@@ -133,6 +131,7 @@ jobs:
133131
timeout-minutes: 420 # 7 hours
134132
# This is in case user manually cancel the step above, we still want to cleanup the resources
135133
- name: Post-run cleanup
134+
if: ${{ inputs.DRY_RUN == false }}
136135
env:
137136
GOOGLE_CLOUD_PROJECT: aptos-devinfra-0
138137
if: ${{ always() }}

0 commit comments

Comments
 (0)