From 2ea4f44b4e41aa80d5ddaa2d074b9850d0592f20 Mon Sep 17 00:00:00 2001 From: wqfish <1171005+wqfish@users.noreply.github.com> Date: Fri, 17 Oct 2025 16:01:29 -0700 Subject: [PATCH] Fix comments for AccumulatorRangeProof The comments are wrong and confused me quite a bit. The siblings are generated by [AncestorSiblingIterator](https://github.com/aptos-labs/aptos-core/blob/84df75576b9beccc33d001ed7fdec6426f257206/storage/accumulator/src/lib.rs#L453-L457) which produces siblings from bottom to the root. --- types/src/proof/definition.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/types/src/proof/definition.rs b/types/src/proof/definition.rs index 2e14d9a8b7554..18d893ea9506f 100644 --- a/types/src/proof/definition.rs +++ b/types/src/proof/definition.rs @@ -575,12 +575,12 @@ impl AccumulatorConsistencyProof { /// left and `Y` and `Z` on the right. #[derive(Clone, Deserialize, Serialize)] pub struct AccumulatorRangeProof { - /// The siblings on the left of the path from the first leaf to the root. Siblings near the root - /// are at the beginning of the vector. + /// The siblings on the left of the path from the first leaf to the root. Siblings are ordered + /// from the bottom level to the root level. left_siblings: Vec, - /// The sliblings on the right of the path from the last leaf to the root. Siblings near the root - /// are at the beginning of the vector. + /// The sliblings on the right of the path from the last leaf to the root. Siblings are ordered + /// from the bottom level to the root level. right_siblings: Vec, phantom: PhantomData,