Skip to content

Commit fbffc33

Browse files
authored
Fix parquet default processor (#458)
* add log * remove size info from write set changes
1 parent 7e24dd8 commit fbffc33

File tree

2 files changed

+25
-67
lines changed

2 files changed

+25
-67
lines changed

rust/processor/src/db/common/models/default_models/parquet_transactions.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,6 @@ impl Transaction {
191191
.expect("Txn Timestamp is invalid!");
192192

193193
let txn_size_info = transaction.size_info.as_ref();
194-
let empty_vec = Vec::new();
195-
let write_set_size_info = txn_size_info
196-
.as_ref()
197-
.map_or(&empty_vec, |size_info| &size_info.write_op_size_info);
198194

199195
match txn_data {
200196
TxnData::User(user_txn) => {
@@ -203,7 +199,6 @@ impl Transaction {
203199
txn_version,
204200
block_height,
205201
block_timestamp,
206-
write_set_size_info,
207202
);
208203
let request = &user_txn
209204
.request
@@ -244,7 +239,6 @@ impl Transaction {
244239
txn_version,
245240
block_height,
246241
block_timestamp,
247-
write_set_size_info,
248242
);
249243
let payload = genesis_txn.payload.as_ref().unwrap();
250244
let payload_cleaned = get_clean_writeset(payload, txn_version);
@@ -278,7 +272,6 @@ impl Transaction {
278272
txn_version,
279273
block_height,
280274
block_timestamp,
281-
write_set_size_info,
282275
);
283276
(
284277
Self::from_transaction_info_with_data(
@@ -327,7 +320,6 @@ impl Transaction {
327320
txn_version,
328321
block_height,
329322
block_timestamp,
330-
write_set_size_info,
331323
);
332324
(
333325
Self::from_transaction_info_with_data(

rust/processor/src/db/common/models/default_models/parquet_write_set_changes.rs

Lines changed: 25 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@ use allocative_derive::Allocative;
1616
use anyhow::Context;
1717
use aptos_protos::transaction::v1::{
1818
write_set_change::{Change as WriteSetChangeEnum, Type as WriteSetChangeTypeEnum},
19-
WriteOpSizeInfo, WriteSetChange as WriteSetChangePB,
19+
WriteSetChange as WriteSetChangePB,
2020
};
2121
use field_count::FieldCount;
22-
use itertools::Itertools;
2322
use parquet_derive::ParquetRecordWriter;
2423
use serde::{Deserialize, Serialize};
2524

@@ -33,9 +32,6 @@ pub struct WriteSetChange {
3332
pub change_type: String,
3433
pub resource_address: String,
3534
pub block_height: i64,
36-
pub key_bytes: i64,
37-
pub value_bytes: i64,
38-
pub total_bytes: i64,
3935
#[allocative(skip)]
4036
pub block_timestamp: chrono::NaiveDateTime,
4137
}
@@ -63,7 +59,6 @@ impl WriteSetChange {
6359
txn_version: i64,
6460
block_height: i64,
6561
block_timestamp: chrono::NaiveDateTime,
66-
write_set_size_info: &WriteOpSizeInfo,
6762
) -> anyhow::Result<Option<(Self, WriteSetChangeDetail)>> {
6863
let change_type = Self::get_write_set_change_type(write_set_change);
6964
let change = write_set_change
@@ -78,10 +73,6 @@ impl WriteSetChange {
7873
hex::encode(inner.state_key_hash.as_slice()).as_str(),
7974
),
8075
block_height,
81-
key_bytes: write_set_size_info.key_bytes as i64,
82-
value_bytes: write_set_size_info.value_bytes as i64,
83-
total_bytes: write_set_size_info.key_bytes as i64
84-
+ write_set_size_info.value_bytes as i64,
8576
change_type,
8677
resource_address: standardize_address(&inner.address),
8778
write_set_change_index,
@@ -102,10 +93,6 @@ impl WriteSetChange {
10293
hex::encode(inner.state_key_hash.as_slice()).as_str(),
10394
),
10495
block_height,
105-
key_bytes: write_set_size_info.key_bytes as i64,
106-
value_bytes: write_set_size_info.value_bytes as i64,
107-
total_bytes: write_set_size_info.key_bytes as i64
108-
+ write_set_size_info.value_bytes as i64,
10996
change_type,
11097
resource_address: standardize_address(&inner.address),
11198
write_set_change_index,
@@ -142,10 +129,6 @@ impl WriteSetChange {
142129
inner.state_key_hash.as_slice(),
143130
),
144131
block_height,
145-
key_bytes: write_set_size_info.key_bytes as i64,
146-
value_bytes: write_set_size_info.value_bytes as i64,
147-
total_bytes: write_set_size_info.key_bytes as i64
148-
+ write_set_size_info.value_bytes as i64,
149132
change_type,
150133
resource_address: standardize_address(&inner.address),
151134
write_set_change_index,
@@ -178,10 +161,6 @@ impl WriteSetChange {
178161
inner.state_key_hash.as_slice(),
179162
),
180163
block_height,
181-
key_bytes: write_set_size_info.key_bytes as i64,
182-
value_bytes: write_set_size_info.value_bytes as i64,
183-
total_bytes: write_set_size_info.key_bytes as i64
184-
+ write_set_size_info.value_bytes as i64,
185164
change_type,
186165
resource_address: standardize_address(&inner.address),
187166
write_set_change_index,
@@ -206,10 +185,6 @@ impl WriteSetChange {
206185
hex::encode(inner.state_key_hash.as_slice()).as_str(),
207186
),
208187
block_height,
209-
key_bytes: write_set_size_info.key_bytes as i64,
210-
value_bytes: write_set_size_info.value_bytes as i64,
211-
total_bytes: write_set_size_info.key_bytes as i64
212-
+ write_set_size_info.value_bytes as i64,
213188
change_type,
214189
resource_address: String::default(),
215190
write_set_change_index,
@@ -237,10 +212,6 @@ impl WriteSetChange {
237212
hex::encode(inner.state_key_hash.as_slice()).as_str(),
238213
),
239214
block_height,
240-
key_bytes: write_set_size_info.key_bytes as i64,
241-
value_bytes: write_set_size_info.value_bytes as i64,
242-
total_bytes: write_set_size_info.key_bytes as i64
243-
+ write_set_size_info.value_bytes as i64,
244215
change_type,
245216
resource_address: String::default(),
246217
write_set_change_index,
@@ -257,38 +228,33 @@ impl WriteSetChange {
257228
txn_version: i64,
258229
block_height: i64,
259230
timestamp: chrono::NaiveDateTime,
260-
size_info: &[WriteOpSizeInfo],
261231
) -> (Vec<Self>, Vec<WriteSetChangeDetail>) {
262-
let results: Vec<(Self, WriteSetChangeDetail)> = write_set_changes
232+
write_set_changes
263233
.iter()
264-
.zip_eq(size_info.iter())
265234
.enumerate()
266-
.filter_map(
267-
|(write_set_change_index, (write_set_change, write_set_size_info))| {
268-
match Self::from_write_set_change(
269-
write_set_change,
270-
write_set_change_index as i64,
271-
txn_version,
272-
block_height,
273-
timestamp,
274-
write_set_size_info,
275-
) {
276-
Ok(Some((change, detail))) => Some((change, detail)),
277-
Ok(None) => None,
278-
Err(e) => {
279-
tracing::error!(
280-
"Failed to convert write set change: {:?} with error: {:?}",
281-
write_set_change,
282-
e
283-
);
284-
panic!("Failed to convert write set change.")
285-
},
286-
}
287-
},
288-
)
289-
.collect::<Vec<(Self, WriteSetChangeDetail)>>();
290-
291-
results.into_iter().unzip()
235+
.filter_map(|(write_set_change_index, write_set_change)| {
236+
match Self::from_write_set_change(
237+
write_set_change,
238+
write_set_change_index as i64,
239+
txn_version,
240+
block_height,
241+
timestamp,
242+
) {
243+
Ok(Some((change, detail))) => Some((change, detail)),
244+
Ok(None) => None,
245+
Err(e) => {
246+
tracing::error!(
247+
"Failed to convert write set change: {:?} with error: {:?}",
248+
write_set_change,
249+
e
250+
);
251+
panic!("Failed to convert write set change.")
252+
},
253+
}
254+
})
255+
.collect::<Vec<(Self, WriteSetChangeDetail)>>()
256+
.into_iter()
257+
.unzip()
292258
}
293259

294260
fn get_write_set_change_type(t: &WriteSetChangePB) -> String {

0 commit comments

Comments
 (0)