oops, fixed SDK DST issue and update README

Author: alinush

confidential-assets/README.md

@@ -94,7 +94,7 @@ pnpm test tests/e2e/
 
 pnpm test decryption
 
-pnpm jest tests/e2e/confidentialAsset.test.ts -t "rotate Alice" --runInBand
+pnpm test tests/e2e/confidentialAsset.test.ts -t "rotate Alice" --runInBand
 ```
 
 Or, run all tests:
@@ -107,11 +107,11 @@ pnpm test
 ### Discrete log / decryption benchmarks
 
 ```bash
-pnpm jest tests/units/discrete-log.test.ts
+pnpm test tests/units/discrete-log.test.ts
 ```
 
 ### Range proof tests
 
 ```bash
-pnpm jest tests/units/confidentialProofs.test.ts
+pnpm test tests/units/confidentialProofs.test.ts
 ```

confidential-assets/src/crypto/sigmaProtocol.ts

@@ -33,7 +33,7 @@ export const APTOS_EXPERIMENTAL_ADDRESS = (() => {
 /**
  * Matches the Move `DomainSeparator` struct:
  * ```move
- * struct DomainSeparator { contract_address: address, chain_id: u8, protocol_id: vector<u8>, session_id: vector<u8> }
+ * enum DomainSeparator { V1 { contract_address: address, chain_id: u8, protocol_id: vector<u8>, session_id: vector<u8> } }
  * ```
  */
 export interface DomainSeparator {
@@ -44,14 +44,15 @@ export interface DomainSeparator {
 }
 
 /**
- * BCS-serializable DomainSeparator.
+ * BCS-serializable DomainSeparator (enum with V1 variant).
  */
 class BcsDomainSeparator extends Serializable {
   constructor(public readonly dst: DomainSeparator) {
     super();
   }
 
   serialize(serializer: Serializer): void {
+    serializer.serializeU32AsUleb128(0); // V1 variant index
     serializer.serialize(new FixedBytes(this.dst.contractAddress));
     serializer.serializeU8(this.dst.chainId);
     serializer.serializeBytes(this.dst.protocolId);

confidential-assets/src/crypto/sigmaProtocolWithdraw.ts

@@ -47,18 +47,20 @@ const TYPE_NAME = "0x7::sigma_protocol_withdraw::Withdrawal";
 /**
  * BCS-serialize a WithdrawSession matching the Move struct:
  * ```move
- * struct WithdrawSession { sender: address, asset_type: Object<Metadata>, num_chunks: u64 }
+ * struct WithdrawSession { sender: address, asset_type: Object<Metadata>, num_chunks: u64, has_auditor: bool }
  * ```
  */
 export function bcsSerializeWithdrawSession(
   senderAddress: Uint8Array,
   tokenTypeAddress: Uint8Array,
   numChunks: number,
+  hasAuditor: boolean,
 ): Uint8Array {
   const serializer = new Serializer();
   serializer.serialize(new FixedBytes(senderAddress));
   serializer.serialize(new FixedBytes(tokenTypeAddress));
   serializer.serialize(new U64(numChunks));
+  serializer.serializeBool(hasAuditor);
   return serializer.toUint8Array();
 }
 
@@ -336,7 +338,7 @@ function proveWithdrawInternal(
   const witness: bigint[] = [dkBigint, ...newAmountChunks, ...newRandomness];
 
   // Build domain separator
-  const sessionId = bcsSerializeWithdrawSession(senderAddress, tokenAddress, ell);
+  const sessionId = bcsSerializeWithdrawSession(senderAddress, tokenAddress, ell, hasAuditor);
   const dst: DomainSeparator = {
     contractAddress: APTOS_EXPERIMENTAL_ADDRESS,
     chainId,
@@ -481,7 +483,7 @@ function verifyWithdrawInternal(
     scalars: [vScalar],
   };
 
-  const sessionId = bcsSerializeWithdrawSession(senderAddress, tokenAddress, ell);
+  const sessionId = bcsSerializeWithdrawSession(senderAddress, tokenAddress, ell, hasAuditor);
   const dst: DomainSeparator = {
     contractAddress: APTOS_EXPERIMENTAL_ADDRESS,
     chainId,

confidential-assets/vitest.config.ts

@@ -6,6 +6,9 @@ export default defineConfig({
     globals: true,
     environment: "node",
     setupFiles: [path.resolve(__dirname, "../tests/setupDotenv.ts")],
+    // NOTE: We typically test confidential assets after making changes to the
+    // Aptos framework, which require a manual localnet re-deployment. So this
+    // automatic deployment before every test is disabled, as a result.
     //globalSetup: [path.resolve(__dirname, "../tests/preTest.ts")],
     include: ["tests/**/*.test.ts"],
     exclude: ["tests/units/api/**"],