Open
Conversation
hardsetting
force-pushed
the
gabriele/txn-worker-improvements
branch
from
98ab40c to
1d973c0
Compare
banool
reviewed
Apr 15, 2025
Contributor
banool
left a comment
banool
left a comment
There was a problem hiding this comment.
This looks great, much much simpler, and actually more powerful thanks to the failed seqnum handling behavior (was the previous version correctly handling gaps due to rejected txns? I don't think so).
I suppose next step is to add events / signals / etc that the caller can subscribe to?
Closed
2 tasks
hardsetting
force-pushed
the
gabriele/txn-worker-improvements
branch
2 times, most recently
from
ae1eeb4 to
56d12f8
Compare
hardsetting
changed the title
hardsetting
force-pushed
the
gabriele/txn-worker-improvements
branch
from
2de2aba to
dd334ba
Compare
hardsetting
force-pushed
the
gabriele/txn-worker-improvements
branch
from
dd334ba to
b9a91ed
Compare
Contributor
|
@hardsetting is there a plan to get this in? I'd like to use the transaction worker but assume this version is better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposal for new transaction worker design, to overcome some promise resolution issues with the current design.
Test Plan
Testing using the gas station's load tester
Will add CI later
Related Links
Checklist
pnpm fmt?CHANGELOG.md?