Merge pull request #34 from aquality-automation/support/retry-local-server-start

Retry Appium local server starting

Author: aqualityAutomation

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>com.github.aquality-automation</groupId>
     <artifactId>aquality-appium-mobile</artifactId>
-    <version>3.1.1</version>
+    <version>3.1.2</version>
 
     <packaging>jar</packaging>
     <name>Aquality Appium Mobile</name>

src/main/java/aquality/appium/mobile/application/ApplicationFactory.java

@@ -19,6 +19,10 @@
 
 public abstract class ApplicationFactory implements IApplicationFactory {
 
+    protected CustomActionRetrier getActionRetrier() {
+        return new CustomActionRetrier(Collections.singletonList(SessionNotCreatedException.class));
+    }
+
     protected IllegalArgumentException getLoggedWrongPlatformNameException(String actualPlatform) {
         String message = AqualityServices.get(ILocalizationManager.class)
                 .getLocalizedMessage("loc.platform.name.wrong", actualPlatform);
@@ -31,7 +35,7 @@ protected AppiumDriver getDriver(URL serviceUrl) {
         PlatformName platformName = AqualityServices.getApplicationProfile().getPlatformName();
         Capabilities capabilities = AqualityServices.getApplicationProfile().getDriverSettings().getCapabilities();
         Factory httpClientFactory = new ClientFactory();
-        return new CustomActionRetrier(Collections.singletonList(SessionNotCreatedException.class))
+        return getActionRetrier()
                 .doWithRetry(() -> createSession(platformName, serviceUrl, httpClientFactory, capabilities));
     }
 

src/main/java/aquality/appium/mobile/application/LocalApplicationFactory.java

@@ -3,8 +3,11 @@
 import aquality.appium.mobile.configuration.ILocalServiceSettings;
 import io.appium.java_client.AppiumDriver;
 import io.appium.java_client.service.local.AppiumDriverLocalService;
+import io.appium.java_client.service.local.AppiumServerHasNotBeenStartedLocallyException;
 import io.appium.java_client.service.local.AppiumServiceBuilder;
 
+import java.util.Collections;
+
 public class LocalApplicationFactory extends ApplicationFactory {
 
     @Override
@@ -14,7 +17,7 @@ public Application getApplication() {
                 .withCapabilities(settings.getCapabilities());
         settings.getArguments().forEach(builder::withArgument);
         AppiumDriverLocalService service = AppiumDriverLocalService.buildService(builder);
-        service.start();
+        getActionRetrier().doWithRetry(service::start, Collections.singletonList(AppiumServerHasNotBeenStartedLocallyException.class));
         AppiumDriver driver = getDriver(service.getUrl());
         logApplicationIsReady();
         return new Application(driver, service);