Fixed localization values for ComboBox

Author: mialeska

src/main/java/aquality/appium/mobile/elements/ComboBox.java

@@ -17,7 +17,7 @@
  */
 public class ComboBox extends Element implements IComboBox {
 
-    private static final String LOG_SELECTING_VALUE = "loc.selecting.value";
+    private static final String LOG_SELECTING_VALUE = "loc.combobox.select.by.value";
 
     protected ComboBox(final By locator, final String name, final ElementState state) {
         super(locator, name, state);
@@ -29,7 +29,7 @@ protected String getElementType() {
 
     @Override
     public void selectByIndex(int index) {
-        logElementAction(LOG_SELECTING_VALUE);
+        logElementAction(LOG_SELECTING_VALUE, String.format("#%d", index));
         doWithRetry(() -> new Select(getElement()).selectByIndex(index));
     }
 
@@ -40,22 +40,22 @@ public void selectByText(String value) {
     }
 
     @Override
-    public void clickAndSelectByText(String value) {
+    public void clickAndSelectByText(String text) {
         click();
-        selectByText(value);
+        selectByText(text);
     }
 
     @Override
     public void selectByContainingText(String text) {
-        logElementAction(LOG_SELECTING_VALUE);
+        logElementAction(LOG_SELECTING_VALUE, text);
         selectOptionThatContains(WebElement::getText,
                 Select::selectByVisibleText,
                 text);
     }
 
     @Override
     public void selectByContainingValue(String value) {
-        logElementAction(LOG_SELECTING_VALUE);
+        logElementAction(LOG_SELECTING_VALUE, value);
         selectOptionThatContains(element -> element.getAttribute(Attributes.VALUE.toString()),
                 Select::selectByValue,
                 value);
@@ -83,7 +83,7 @@ private void selectOptionThatContains(Function<WebElement, String> getValueFunc,
 
     @Override
     public void selectByValue(String value) {
-        logElementAction(LOG_SELECTING_VALUE);
+        logElementAction(LOG_SELECTING_VALUE, value);
         doWithRetry(() -> new Select(getElement()).selectByValue(value));
     }
 

src/main/java/aquality/appium/mobile/elements/interfaces/IComboBox.java

@@ -20,9 +20,9 @@ public interface IComboBox extends IElement {
     /**
      * Open Dropdown and select by visible text
      *
-     * @param value text to be selected
+     * @param text text to be selected
      */
-    void clickAndSelectByText(String value);
+    void clickAndSelectByText(String text);
 
     /**
      * Select by containing visible text

src/main/java/aquality/appium/mobile/elements/interfaces/ITextBox.java

@@ -9,7 +9,7 @@ public interface ITextBox extends IElement {
     void type(String value);
 
     /**
-     * Enter the text in the box, inputted value isn't logging
+     * Enter the text in the box, inputted value isn't logged
      *
      * @param value text
      */
@@ -28,7 +28,7 @@ public interface ITextBox extends IElement {
     void clearAndType(String value);
 
     /**
-     * Clears input and enters text in the box, inputted value isn't logging
+     * Clears input and enters text in the box, inputted value isn't logged
      *
      * @param value text
      */

src/main/resources/localization/be.json

@@ -20,6 +20,7 @@
   "loc.checkbox.get.state": "Атрымліваем стан",
   "loc.combobox": "Камбабокс",
   "loc.combobox.select.by.text" : "Выбіраем значэнне з тэкстам '%s'",
+  "loc.combobox.select.by.value" : "Выбіраем значэнне '%s'",
   "loc.combobox.get.texts": "Атрымліваем спіс тэкстаў опцыяў",
   "loc.combobox.get.values" : "Атрымліваем спіс значэнняў",
   "loc.combobox.impossible.to.select.contain.value.or.text" : "Немагчыма выбраць опцыю, якая змяшчае значэнне/тэкст '%1$s' у камбабоксе '%2$s'",
@@ -28,7 +29,6 @@
   "loc.label" : "Надпіс",
   "loc.link" : "Спасылка",
   "loc.radio" : "Радыёкнопка",
-  "loc.selecting.value" : "Выбіраем значэнне",
   "loc.send.text" : "Задаем тэкст - '%s'",
   "loc.setting.value" : "Задаем значэнне '%s'",
   "loc.text.clearing" : "Ачышчаем",

src/main/resources/localization/en.json

@@ -20,6 +20,7 @@
   "loc.checkbox.get.state": "Getting state",
   "loc.combobox": "ComboBox",
   "loc.combobox.select.by.text": "Selecting value by text '%s'",
+  "loc.combobox.select.by.value": "Selecting value '%s'",
   "loc.combobox.get.texts": "Getting option texts array",
   "loc.combobox.get.values": "Getting values array",
   "loc.combobox.impossible.to.select.contain.value.or.text": "It is impossible to select option that contains value/text '%1$s' from combobox '%2$s'",
@@ -28,9 +29,8 @@
   "loc.label": "Label",
   "loc.link": "Link",
   "loc.radio": "Radiobutton",
-  "loc.selecting.value": "Selecting value",
   "loc.send.text": "Setting text - '%s'",
-  "loc.setting.value": "Setting value",
+  "loc.setting.value": "Setting value '%s'",
   "loc.text.clearing": "Clearing",
   "loc.text.field": "Text Field",
   "loc.text.typing": "Typing '%s'",

src/main/resources/localization/ru.json

@@ -20,6 +20,7 @@
   "loc.checkbox.get.state": "Получение состояния",
   "loc.combobox": "Комбобокс",
   "loc.combobox.select.by.text": "Выбор значения с текстом '%s'",
+  "loc.combobox.select.by.value": "Выбор значения '%s'",
   "loc.combobox.get.texts": "Получение списка текстов опций",
   "loc.combobox.get.values": "Получение списка значений",
   "loc.combobox.impossible.to.select.contain.value.or.text": "Не удаётся выбрать значение которое содержит значение/текст '%1$s' в выпадающем списке '%2$s'",
@@ -28,9 +29,8 @@
   "loc.label": "Надпись",
   "loc.link": "Ссылка",
   "loc.radio": "Радиокнопка",
-  "loc.selecting.value": "Выбор значения",
   "loc.send.text": "Ввод текста - '%s'",
-  "loc.setting.value": "Установка значения",
+  "loc.setting.value": "Установка значения '%s'",
   "loc.text.clearing": "Очистка",
   "loc.text.field": "Текстовое поле",
   "loc.text.typing": "Ввод текста '%s'",