Add element tests (#11)

* Implement RadioButton test

* Cover CheckBox methods with test

* Reused Attributes enum

* Cover ComboBox methods and Element's findChildElement methods with tests

* Cover Link methods and ElementFactory's findChildElement method with tests, refactoring

* Add WebCheckbox and WebRadioButton tests

* Refactored CheckBox and RadioButton elements

* Replaced usage of isChecked() with super.isChecked() inside the toggle() method

* Refactored tests and add AndroidActivity handling

* Add waiting for isKeyboardShown result to WebTextBoxTest

* Increased wait for keyboard shown timeout and reordered steps in textbox test

Author: mialeska

src/main/java/aquality/appium/mobile/elements/Attributes.java

@@ -1,6 +1,7 @@
 package aquality.appium.mobile.elements;
 
 public enum Attributes {
+    CHECKED("checked"),
     CLASS("class"),
     DISABLED("disabled"),
     HREF("href"),

src/main/java/aquality/appium/mobile/elements/CheckBox.java

@@ -7,7 +7,7 @@
 /**
  * The class describing the checkbox
  */
-public class CheckBox extends Element implements ICheckBox {
+public class CheckBox extends CheckableElement implements ICheckBox {
 
     protected CheckBox(final By locator, final String name, final ElementState state) {
         super(locator, name, state);
@@ -29,12 +29,13 @@ public void uncheck() {
 
     @Override
     public boolean isChecked() {
-        return getState();
+        logElementAction("loc.checkbox.get.state");
+        return super.isChecked();
     }
 
     @Override
     public void toggle() {
-        setState(!isChecked());
+        setState(!super.isChecked());
     }
 
     /**
@@ -44,13 +45,8 @@ public void toggle() {
      */
     private void setState(boolean state) {
         logElementAction("loc.setting.value", state);
-        if (state != getState()) {
+        if (state != super.isChecked()) {
             click();
         }
     }
-
-    private boolean getState() {
-        logElementAction("loc.checkbox.get.state");
-        return getElement().isSelected();
-    }
 }

src/main/java/aquality/appium/mobile/elements/CheckableElement.java

@@ -0,0 +1,27 @@
+package aquality.appium.mobile.elements;
+
+import aquality.selenium.core.elements.ElementState;
+import org.openqa.selenium.By;
+
+public abstract class CheckableElement extends Element {
+    /**
+     * The main constructor
+     *
+     * @param loc     By Locator
+     * @param nameOf  Output in logs
+     * @param stateOf desired ElementState
+     */
+    protected CheckableElement(By loc, String nameOf, ElementState stateOf) {
+        super(loc, nameOf, stateOf);
+    }
+
+    public boolean isChecked() {
+        return doWithRetry(() -> {
+            String checked = getElement().getAttribute(Attributes.CHECKED.toString());
+            if (checked == null || checked.equals("")) {
+                return getElement().isSelected();
+            }
+            return checked.equals("true");
+        });
+    }
+}

src/main/java/aquality/appium/mobile/elements/Link.java

@@ -19,6 +19,6 @@ protected String getElementType() {
 
     @Override
     public String getHref() {
-        return getAttribute(Attributes.HREF.toString());
+        return getAttribute(Attributes.HREF);
     }
 }

src/main/java/aquality/appium/mobile/elements/RadioButton.java

@@ -7,7 +7,7 @@
 /**
  * Class describing the Radiobutton
  */
-public class RadioButton extends Element implements IRadioButton {
+public class RadioButton extends CheckableElement implements IRadioButton {
 
     protected RadioButton(final By locator, final String name, final ElementState state) {
         super(locator, name, state);
@@ -16,9 +16,4 @@ protected RadioButton(final By locator, final String name, final ElementState st
     protected String getElementType() {
         return getLocalizationManager().getLocalizedMessage("loc.radio");
     }
-
-    @Override
-    public boolean isChecked() {
-        return doWithRetry(() -> getElement().isSelected());
-    }
 }

src/main/java/aquality/appium/mobile/elements/TextBox.java

@@ -52,7 +52,7 @@ public void clearAndTypeSecret(final String value) {
 
     @Override
     public String getValue() {
-        return getAttribute(Attributes.VALUE.toString());
+        return getAttribute(Attributes.VALUE);
     }
 
     @Override

src/main/java/aquality/appium/mobile/elements/interfaces/IElement.java

@@ -1,5 +1,6 @@
 package aquality.appium.mobile.elements.interfaces;
 
+import aquality.appium.mobile.elements.Attributes;
 import aquality.appium.mobile.elements.ElementType;
 import aquality.selenium.core.elements.ElementState;
 import io.appium.java_client.MobileElement;
@@ -51,7 +52,7 @@ default <T extends IElement> T findChildElement(By childLoc, ElementType element
      * @return found child element
      */
     default <T extends IElement> T findChildElement(By childLoc, ElementType elementType) {
-        return findChildElement(childLoc, null, elementType, ElementState.DISPLAYED);
+        return findChildElement(childLoc, elementType, ElementState.DISPLAYED);
     }
 
     /**
@@ -88,4 +89,14 @@ default MobileElement getElement() {
      */
     @Override
     MobileElement getElement(Duration timeout);
+
+    /**
+     * Gets attribute value of the element.
+     *
+     * @param attribute Attribute
+     * @return Attribute value
+     */
+    default String getAttribute(Attributes attribute) {
+        return getAttribute(attribute.toString());
+    }
 }

src/main/java/aquality/appium/mobile/elements/interfaces/IElementFactory.java

@@ -256,7 +256,7 @@ default <T extends IElement> T findChildElement(IElement parentElement, By child
      * @return Child element.
      */
     default <T extends IElement> T findChildElement(IElement parentElement, By childLoc, ElementType type) {
-        return findChildElement(parentElement, childLoc, null, type, ElementState.EXISTS_IN_ANY_STATE);
+        return findChildElement(parentElement, childLoc, type, ElementState.EXISTS_IN_ANY_STATE);
     }
 
     /**

src/main/java/aquality/appium/mobile/screens/AndroidScreen.java

@@ -2,6 +2,7 @@
 
 import aquality.appium.mobile.application.AqualityServices;
 import aquality.appium.mobile.application.PlatformName;
+import io.appium.java_client.android.Activity;
 import io.appium.java_client.android.AndroidDriver;
 import io.appium.java_client.android.AndroidElement;
 import org.openqa.selenium.By;
@@ -22,4 +23,12 @@ protected AndroidDriver<AndroidElement> getDriver(){
         ensureApplicationPlatformCorrect(PlatformName.ANDROID);
         return (AndroidDriver<AndroidElement>) AqualityServices.getApplication().getDriver();
     }
+
+    protected void startActivity(Activity activity) {
+        AqualityServices.getLogger().info(
+                String.format("Starting the '%s' activity of the android app at package '%s'",
+                        activity.getAppActivity(),
+                        activity.getAppPackage()));
+        getDriver().startActivity(activity);
+    }
 }

src/main/resources/localization/be.json

@@ -15,6 +15,7 @@
   "loc.platform.name.wrong": "Платформа '%s' не падтрымліваецца.",
   "loc.application.ready": "Праграма на платформе '%1$s' гатовая...",
   "loc.application.implicit.timeout": "Задаем таймаўт implicit(няяўнага) чакання: '%1$s' сек.",
+  "loc.application.android.activity.start": "Стартуем '%1$s' актыўнасць Android праграмы ў пакеце '%2$s'",
   "loc.button": "Кнопка",
   "loc.checkbox": "Чэкбокс",
   "loc.checkbox.get.state": "Атрымліваем стан",