Skip to content

Commit c578303

Browse files
committed
Fixed code review issues
1 parent e87bc14 commit c578303

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/main/java/aquality/appium/mobile/configuration/driversettings/DriverSettings.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212

1313
abstract class DriverSettings implements IDriverSettings {
1414

15-
private static final String appPathKey = "applicationPath";
16-
private static final String appCapabilityKey = "app";
15+
private static final String APPLICATION_PATH_KEY = "applicationPath";
16+
private static final String APP_CAPABILITY_KEY = "app";
1717
private final ISettingsFile settingsFile;
1818

1919
DriverSettings(ISettingsFile settingsFile) {
@@ -26,7 +26,7 @@ public Capabilities getCapabilities() {
2626
DesiredCapabilities capabilities = new DesiredCapabilities();
2727
capabilitiesFromSettings.forEach(capabilities::setCapability);
2828
if(hasApplicationPath()) {
29-
capabilities.setCapability(appCapabilityKey, getAbsolutePath(getApplicationPath()));
29+
capabilities.setCapability(APP_CAPABILITY_KEY, getAbsolutePath(getApplicationPath()));
3030
}
3131
return capabilities;
3232
}
@@ -47,12 +47,12 @@ private String getAbsolutePath(String relativePath) {
4747
}
4848

4949
private boolean hasApplicationPath() {
50-
return settingsFile.getMap(getDriverSettingsPath()).containsKey(appPathKey);
50+
return settingsFile.getMap(getDriverSettingsPath()).containsKey(APPLICATION_PATH_KEY);
5151
}
5252

5353
@Override
5454
public String getApplicationPath() {
55-
return String.valueOf(settingsFile.getValue(getDriverSettingsPath() + "/" + appPathKey));
55+
return String.valueOf(settingsFile.getValue(getDriverSettingsPath() + "/" + APPLICATION_PATH_KEY));
5656
}
5757

5858
private String getDriverCapabilitiesJsonPath(){

0 commit comments

Comments
 (0)