add retry for driver creation to application factory

Author: mialeska

src/main/java/aquality/appium/mobile/application/ApplicationFactory.java

@@ -2,33 +2,43 @@
 
 import aquality.selenium.core.configurations.ITimeoutConfiguration;
 import aquality.selenium.core.localization.ILocalizationManager;
+import aquality.selenium.core.utilities.ElementActionRetrier;
 import io.appium.java_client.AppiumDriver;
 import io.appium.java_client.android.AndroidDriver;
 import io.appium.java_client.android.AndroidElement;
 import io.appium.java_client.ios.IOSDriver;
 import io.appium.java_client.ios.IOSElement;
 import org.openqa.selenium.Capabilities;
+import org.openqa.selenium.SessionNotCreatedException;
 import org.openqa.selenium.remote.http.HttpClient;
 import org.openqa.selenium.remote.http.HttpClient.Builder;
 import org.openqa.selenium.remote.http.HttpClient.Factory;
 
 import java.net.URL;
 import java.time.Duration;
+import java.util.Collections;
+import java.util.List;
 
-abstract class ApplicationFactory implements IApplicationFactory {
+public abstract class ApplicationFactory implements IApplicationFactory {
 
-    private IllegalArgumentException getLoggedWrongPlatformNameException(String actualPlatform) {
+    protected IllegalArgumentException getLoggedWrongPlatformNameException(String actualPlatform) {
         String message = AqualityServices.get(ILocalizationManager.class)
                 .getLocalizedMessage("loc.platform.name.wrong", actualPlatform);
         IllegalArgumentException exception = new IllegalArgumentException(message);
         AqualityServices.getLogger().fatal(message, exception);
         return exception;
     }
 
-    AppiumDriver getDriver(URL serviceUrl) {
+    protected AppiumDriver getDriver(URL serviceUrl) {
         PlatformName platformName = AqualityServices.getApplicationProfile().getPlatformName();
         Capabilities capabilities = AqualityServices.getApplicationProfile().getDriverSettings().getCapabilities();
         Factory httpClientFactory = new ClientFactory();
+        return new CustomActionRetrier(Collections.singletonList(SessionNotCreatedException.class))
+                .doWithRetry(() -> createSession(platformName, serviceUrl, httpClientFactory, capabilities));
+    }
+
+    protected AppiumDriver createSession(PlatformName platformName, URL serviceUrl, Factory httpClientFactory,
+                                       Capabilities capabilities) {
         AppiumDriver driver;
         switch (platformName) {
             case ANDROID:
@@ -43,7 +53,21 @@ AppiumDriver getDriver(URL serviceUrl) {
         return driver;
     }
 
-    class ClientFactory implements Factory{
+    protected class CustomActionRetrier extends ElementActionRetrier {
+        private final List<Class<? extends Exception>> handledExceptions;
+
+        CustomActionRetrier(List<Class<? extends Exception>> handledExceptions) {
+            super(AqualityServices.getConfiguration().getRetryConfiguration());
+            this.handledExceptions = handledExceptions;
+        }
+
+        @Override
+        public List<Class<? extends Exception>> getHandledExceptions() {
+            return handledExceptions;
+        }
+    }
+
+    protected class ClientFactory implements Factory {
 
         private final Factory defaultClientFactory = Factory.createDefault();
         private final Duration timeoutCommand = AqualityServices.get(ITimeoutConfiguration.class).getCommand();
@@ -64,7 +88,7 @@ public void cleanupIdleClients() {
         }
     }
 
-    void logApplicationIsReady() {
+    protected void logApplicationIsReady() {
         AqualityServices.getLocalizedLogger().info("loc.application.ready", AqualityServices.getApplicationProfile().getPlatformName());
     }
 }

src/main/java/aquality/appium/mobile/application/LocalApplicationFactory.java

@@ -9,7 +9,7 @@ public class LocalApplicationFactory extends ApplicationFactory {
     @Override
     public Application getApplication() {
         AppiumServiceBuilder builder = new AppiumServiceBuilder()
-                .withArgument(() -> "--allow-insecure", " chromedriver_autodownload");
+                .withArgument(() -> "--allow-insecure", "chromedriver_autodownload");
         AppiumDriverLocalService service = AppiumDriverLocalService.buildService(builder);
         service.start();
         AppiumDriver driver = getDriver(service.getUrl());