[Visualization] Avoid error "Cannot take screenshot with 0 width." (#127)

* [Visualization] Avoid error "Cannot take screenshot with 0 width."
Stabilize FormDumpTests

* Update azure-pipelines.yml for Azure Pipelines

* fix coding issues

Author: mialeska

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Visualization/DumpManager.cs

@@ -118,7 +118,7 @@ public virtual void Save(string dumpName = null)
 
         protected virtual List<KeyValuePair<string, T>> FilterElementsForVisualization()
         {
-            return ElementsForVisualization.Where(element => element.Value.State.IsDisplayed).ToList();
+            return ElementsForVisualization.Where(element => element.Value.State.IsDisplayed && element.Value.Visual.Size.Width > 0).ToList();
         }
 
         protected virtual DirectoryInfo CleanUpAndGetDumpDirectory(string dumpName = null)

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Visualization/ImageExtensions.cs

@@ -40,7 +40,7 @@ public static SKImage Resize(this SKImage originalImage, int newWidth, int newHe
             using (var srcBitmap = SKBitmap.FromImage(originalImage))
             {
                 var resizeInfo = new SKImageInfo(newWidth, newHeight);
-                using (var smallVersion = srcBitmap.Resize(resizeInfo, SKFilterQuality.High))
+                using (var smallVersion = srcBitmap.Resize(resizeInfo, new SKSamplingOptions(SKCubicResampler.Mitchell)))
                 {
                     return SKImage.FromBitmap(smallVersion);
                 }

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Visualization/VisualStateProvider.cs

@@ -33,7 +33,7 @@ public SKImage Image
         private T GetLoggedValue<T>(string name, Func<WebElement, T> getValue, Func<T, string> toString = null)
         {
             logVisualState($"loc.el.visual.get{name.ToLower()}");
-            var value = actionRetrier.DoWithRetry(() => getValue(getElement()));
+            var value = actionRetrier.DoWithRetry(() => getValue(getElement()), new []{ typeof(WebDriverException) });
             logVisualState($"loc.el.visual.{name.ToLower()}.value", toString == null ? value.ToString() : toString(value));
             return value;
         }
@@ -49,7 +49,7 @@ public float GetDifference(SKImage theOtherOne, float? threshold = null)
             }
             else
             {
-                logVisualState("loc.el.visual.getdifference.withthreshold", theOtherOne.Size().ToString(), threshold?.ToString("P", CultureInfo.InvariantCulture));
+                logVisualState("loc.el.visual.getdifference.withthreshold", theOtherOne.Size().ToString(), threshold.Value.ToString("P", CultureInfo.InvariantCulture));
             }
 
             if (currentImage != default)

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Visualization/FormDumpTests.cs

@@ -71,10 +71,10 @@ public void Should_BePossibleTo_CompareWithDump_WithCustomName_WhenDifferenceIsZ
         public void Should_BePossibleTo_CompareWithDump_WithCustomName_WhenDifferenceIsNotZero()
         {
             var form = new WebForm();
-            form.HoverAvatar();
             form.Dump.Save("Non-zero diff");
             AqualityServices.Application.Driver.Navigate().Refresh();
             form.WaitUntilPresent();
+            form.HoverAvatar();
             Assert.That(form.Dump.Compare("Non-zero diff"), Is.GreaterThan(0), "Difference with current page should be greater than zero");
         }
 

azure-pipelines.yml

@@ -15,29 +15,32 @@ stages:
     displayName: Analyse code with SonarQube
 
     steps:
-    - task: SonarCloudPrepare@1
+    - task: SonarCloudPrepare@3
       displayName: 'Prepare SonarCloud analysis'
       inputs:
-        SonarCloud: 'SonarCloud'
+        SonarQube: 'SonarCloud'
         organization: 'aqualityautomation'
+        scannerMode: 'dotnet'
         projectKey: 'aquality-automation_aquality-selenium-core-dotnet'
         projectName: 'aquality-selenium-core-dotnet'
         projectVersion: '$(Build.BuildNumber)'
-        extraProperties: |
-          sonar.coverage.exclusions=**/**
+        extraProperties: 'sonar.coverage.exclusions=**/**'
 
     - task: DotNetCoreCLI@2
       displayName: 'Build solution'
       inputs:
         command: 'build'
         projects: Aquality.Selenium.Core/Aquality.Selenium.Core.sln
         arguments: -c $(buildConfiguration)
-
-    - task: SonarCloudAnalyze@1
+    - task: SonarCloudAnalyze@3
+      inputs:
+        jdkversion: 'JAVA_HOME_17_X64'
       displayName: 'Run SonarCloud code analysis'
       continueOnError: true
 
-    - task: SonarCloudPublish@1
+    - task: SonarCloudPublish@3
+      inputs:
+        pollingTimeoutSec: '300'
       displayName: 'Publish SonarCloud quality gate results'
 
   - job: tests
@@ -114,15 +117,18 @@ stages:
     - script: dotnet pack Aquality.Selenium.Core\src\Aquality.Selenium.Core\Aquality.Selenium.Core.csproj -c $(buildConfiguration) -p:Version=$(GitVersion.NuGetVersion) -o $(Build.ArtifactStagingDirectory)
       displayName: 'Create NuGet package'
 
-    - task: GitHubRelease@0
+    - task: GitHubRelease@1
       displayName: 'Create tag on GitHub'
       inputs:
         gitHubConnection: 'github.com_aqualityautomation'
         repositoryName: 'aquality-automation/aquality-selenium-core-dotnet'
         action: 'create'
+        target: '$(Build.SourceVersion)'
+        tagSource: 'userSpecifiedTag'
         tag: 'v$(GitVersion.NuGetVersion)'
-        tagSource: 'manual'
-        isPreRelease: contains(variables['GitVersion.NuGetVersion'], '-')
+        isDraft: contains(variables['GitVersion.NuGetVersion'], '-')
+        changeLogCompareToRelease: 'lastFullRelease'
+        changeLogType: 'commitBased'
 
     - task: NuGetCommand@2
       displayName: 'Push NuGet package'