Fix RelativeElementFinder to throw the exception if the condition was not satisfied to fix #45 (#46)

Author: mialeska

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Elements/RelativeElementFinder.cs

@@ -31,16 +31,16 @@ public override ReadOnlyCollection<IWebElement> FindElements(By locator, Desired
             var resultElements = new List<IWebElement>();
             try
             {
-                ConditionalWait.WaitFor(() =>
+                ConditionalWait.WaitForTrue(() =>
                 {
                     foundElements = SearchContextSupplier().FindElements(locator).ToList();
                     resultElements = foundElements.Where(desiredState.ElementStateCondition).ToList();
                     return resultElements.Any();
                 }, timeout);
             }
-            catch (WebDriverTimeoutException ex)
+            catch (TimeoutException ex)
             {
-                HandleTimeoutException(ex, desiredState, locator, foundElements);
+                HandleTimeoutException(new WebDriverTimeoutException(ex.Message, ex), desiredState, locator, foundElements);
             }
             return resultElements.AsReadOnly();
         }

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/WindowsApp/Locators/CalculatorWindow.cs

@@ -18,5 +18,7 @@ public static class CalculatorWindow
         public static By EqualsButton => By.Name("=");
 
         public static By ResultsLabel => MobileBy.AccessibilityId("48");
+
+        public static By EmptyButton => By.XPath("//*[@AutomationId='7']");
     }
 }

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/WindowsApp/RelativeElementFinderTests.cs

@@ -5,6 +5,8 @@
 using Aquality.Selenium.Core.Waitings;
 using Microsoft.Extensions.DependencyInjection;
 using NUnit.Framework;
+using OpenQA.Selenium;
+using System;
 
 namespace Aquality.Selenium.Core.Tests.Applications.WindowsApp
 {
@@ -14,11 +16,23 @@ public class RelativeElementFinderTests : TestWithApplication
             AqualityServices.ServiceProvider.GetRequiredService<ILocalizedLogger>(),
             AqualityServices.ServiceProvider.GetRequiredService<ConditionalWait>(),
             () => AqualityServices.Application.Driver.FindElement(CalculatorWindow.WindowLocator));
+
+        private IElementStateProvider GetElementStateProvider(By locator) => new ElementStateProvider(
+            locator,
+            AqualityServices.ServiceProvider.GetRequiredService<ConditionalWait>(),
+            ElementFinder);
 
         [Test]
         public void Should_FindChildElements_ViaRelativeElementFinder()
         {
             Assert.IsNotNull(ElementFinder.FindElement(CalculatorWindow.OneButton));
         }
+
+        [Test]
+        public void Should_ThrowException_IfWaitForClickableEnded()
+        {
+            var emptyButtonState = GetElementStateProvider(CalculatorWindow.EmptyButton);
+            Assert.Throws<WebDriverTimeoutException>(() => emptyButtonState.WaitForClickable(TimeSpan.Zero));
+        }
     }
 }