#14 Fix sonar issues (#28)

* #14 Fix sonar issues

* #14 Fix issues with default public constructor

* #14 Add special language file

* #14 Remove ServiceProviderContainer

Author: paveliam

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Applications/ApplicationManager.cs

@@ -4,18 +4,24 @@
 
 namespace Aquality.Selenium.Core.Applications
 {
-    public abstract class ApplicationManager<TManager, TApplication> 
-        where TManager : ApplicationManager<TManager, TApplication>
+    public abstract class ApplicationManager<TApplication>
         where TApplication : class, IApplication
     {
         private static readonly ThreadLocal<TApplication> AppContainer = new ThreadLocal<TApplication>();
         private static readonly ThreadLocal<IServiceProvider> ServiceProviderContainer = new ThreadLocal<IServiceProvider>();
 
-        public static bool IsStarted => AppContainer.IsValueCreated && AppContainer.Value.Driver.SessionId != null;
+        protected ApplicationManager()
+        {
+        }
+
+        public static bool IsApplicationStarted()
+        {
+            return AppContainer.IsValueCreated && AppContainer.Value.Driver.SessionId != null;
+        }
 
         protected static TApplication GetApplication(Func<IServiceProvider, TApplication> startApplicationFunction, Func<IServiceCollection> serviceCollectionProvider = null)
         {
-            if (!IsStarted)
+            if (!IsApplicationStarted())
             {
                 AppContainer.Value = startApplicationFunction(
                     GetServiceProvider(service => GetApplication(startApplicationFunction, serviceCollectionProvider), serviceCollectionProvider));

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/ApplicationManagerTests.cs

@@ -33,8 +33,7 @@ public void Should_BePossibleTo_RegisterCustomServices_WithCustomSettingsFile()
             Assert.AreEqual(SpecialLanguageValue, ApplicationManager.ServiceProvider.GetService<ILoggerConfiguration>().Language);
         }
 
-
-        private class ApplicationManager : ApplicationManager<ApplicationManager, IApplication>
+        private class ApplicationManager : ApplicationManager<IApplication>
         {
             public static IApplication Application => GetApplication(StartApplicationFunction, () => RegisterServices(services => Application));
 

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/ApplicationManager.cs

@@ -8,7 +8,7 @@
 
 namespace Aquality.Selenium.Core.Tests.Applications.Browser
 {
-    public class ApplicationManager : ApplicationManager<ApplicationManager, ChromeApplication>
+    public class ApplicationManager : ApplicationManager<ChromeApplication>
     {
         private static readonly object downloadDriverLock = new object();
 

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/ApplicationNotStartedTests.cs

@@ -30,7 +30,7 @@ public class ApplicationNotStartedTests : TestWithBrowser
         public void Should_NotStartApplication_ForServiceResolving(Type type)
         {
             Assert.IsNotNull(ServiceProvider.GetRequiredService(type));
-            Assert.IsFalse(ApplicationManager.IsStarted);
+            Assert.IsFalse(ApplicationManager.IsApplicationStarted());
         }
     }
 }

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/TestWithBrowser.cs

@@ -22,7 +22,7 @@ public void SetUp()
         [TearDown]
         public void CleanUp()
         {
-            if (ApplicationManager.IsStarted)
+            if (ApplicationManager.IsApplicationStarted())
             {
                 ApplicationManager.Application.Quit();
             }

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/WindowsApp/ApplicationManager.cs

@@ -9,7 +9,7 @@
 
 namespace Aquality.Selenium.Core.Tests.Applications.WindowsApp
 {
-    public class ApplicationManager : ApplicationManager<ApplicationManager, WindowsApplication>
+    public class ApplicationManager : ApplicationManager<WindowsApplication>
     {
         private const string SupportedApplication = "./Resources/WindowsApp/Day Maxi Calc.exe";
         private const string DefaultDriverServer = "http://127.0.0.1:4723/";

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/WindowsApp/TestWithApplication.cs

@@ -8,7 +8,7 @@ public class TestWithApplication
         [TearDown]
         public void CleanUp()
         {
-            if (ApplicationManager.IsStarted)
+            if (ApplicationManager.IsApplicationStarted())
             {
                 ApplicationManager.Application.Driver.Quit();
             }