Skip to content

Commit 6f6dea2

Browse files
committed
Update ColorMatrix for grayscaling, stabilize tests
1 parent 5e35221 commit 6f6dea2

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Visualization/ImageExtensions.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ public static class ImageExtensions
1212
{
1313
private static readonly SKColorFilter ColorMatrix = SKColorFilter.CreateColorMatrix(new float[]
1414
{
15-
.3f, .3f, .3f, 0, 0,
16-
.59f, .59f, .59f, 0, 0,
17-
.11f, .11f, .11f, 0, 0,
18-
0, 0, 0, 1, 0
15+
0.21f, 0.72f, 0.07f, 0, 0,
16+
0.21f, 0.72f, 0.07f, 0, 0,
17+
0.21f, 0.72f, 0.07f, 0, 0,
18+
0, 0, 0, 1, 0
1919
});
2020

2121
/// <summary>

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Visualization/ImageComparatorTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using Aquality.Selenium.Core.Elements;
2+
using Aquality.Selenium.Core.Waitings;
23
using Aquality.Selenium.Core.Tests.Applications.Browser;
34
using Aquality.Selenium.Core.Tests.Applications.Browser.Elements;
45
using Aquality.Selenium.Core.Visualization;
@@ -67,6 +68,7 @@ public void Should_BePossibleTo_GetPercentageDifference_ForSimilarElements()
6768
{
6869
StartLoading();
6970
var firstImage = LoadingLabel.GetElement().GetScreenshot().AsImage();
71+
AqualityServices.ServiceProvider.GetRequiredService<IConditionalWait>().WaitFor(() => firstImage.Height < LoadingLabel.Visual.Size.Height);
7072
var secondImage = LoadingLabel.GetElement().GetScreenshot().AsImage();
7173
Assert.Multiple(() =>
7274
{

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Visualization/VisualStateProviderTests.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
using Aquality.Selenium.Core.Elements;
2+
using Aquality.Selenium.Core.Waitings;
23
using Aquality.Selenium.Core.Tests.Applications.Browser;
34
using Aquality.Selenium.Core.Tests.Applications.Browser.Elements;
45
using NUnit.Framework;
56
using OpenQA.Selenium;
67
using SkiaSharp;
78
using System;
89
using System.Drawing;
10+
using Microsoft.Extensions.DependencyInjection;
911

1012
namespace Aquality.Selenium.Core.Tests.Visualization
1113
{
@@ -85,6 +87,7 @@ public void Should_BePossibleTo_GetPercentageDifference_ForSimilarElements()
8587
{
8688
StartLoading();
8789
var firstImage = LoadingLabel.Visual.Image;
90+
AqualityServices.ServiceProvider.GetRequiredService<IConditionalWait>().WaitFor(() => firstImage.Height < LoadingLabel.Visual.Size.Height);
8891
Assert.Multiple(() =>
8992
{
9093
Assert.That(LoadingLabel.Visual.GetDifference(firstImage, threshold: 0), Is.Not.EqualTo(0));

0 commit comments

Comments
 (0)