Skip to content

Commit 8c2ce82

Browse files
authored
#37 renamed ApplicationManager to AqualityServices (#39)
+semver: minor * #37 renamed ApplicationManager to AqualityServices * made IsApplicationStarted protected * #37 fixed build * fix build
1 parent 0d2ee6c commit 8c2ce82

File tree

13 files changed

+46
-42
lines changed

13 files changed

+46
-42
lines changed

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Applications/ApplicationManager.cs renamed to Aquality.Selenium.Core/src/Aquality.Selenium.Core/Applications/AqualityServices.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
namespace Aquality.Selenium.Core.Applications
66
{
7-
public abstract class ApplicationManager<TApplication>
7+
public abstract class AqualityServices<TApplication>
88
where TApplication : class, IApplication
99
{
1010
private static readonly ThreadLocal<TApplication> AppContainer = new ThreadLocal<TApplication>();
1111
private static readonly ThreadLocal<IServiceProvider> ServiceProviderContainer = new ThreadLocal<IServiceProvider>();
1212

13-
protected ApplicationManager()
13+
protected AqualityServices()
1414
{
1515
}
1616

17-
public static bool IsApplicationStarted()
17+
protected static bool IsApplicationStarted()
1818
{
1919
return AppContainer.IsValueCreated && AppContainer.Value.Driver.SessionId != null;
2020
}
Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
namespace Aquality.Selenium.Core.Tests.Applications
1111
{
12-
public class ApplicationManagerTests
12+
public class AqualityServicesTests
1313
{
1414
private const string SpecialSettingsFile = "special";
1515
private const string SpecialLanguageValue = "special";
@@ -19,31 +19,31 @@ public class ApplicationManagerTests
1919
[Test]
2020
public void Should_BePossibleTo_RegisterCustomServices()
2121
{
22-
Assert.IsInstanceOf<TestTimeoutConfiguration>(TestApplicationManager.ServiceProvider.GetService<ITimeoutConfiguration>());
22+
Assert.IsInstanceOf<TestTimeoutConfiguration>(TestAqualityServices.ServiceProvider.GetService<ITimeoutConfiguration>());
2323
}
2424

2525
[Test]
2626
public void Should_BePossibleTo_GetCustomValues()
2727
{
28-
var timeoutConfiguration = TestApplicationManager.ServiceProvider.GetService<ITimeoutConfiguration>() as TestTimeoutConfiguration;
28+
var timeoutConfiguration = TestAqualityServices.ServiceProvider.GetService<ITimeoutConfiguration>() as TestTimeoutConfiguration;
2929
Assert.AreEqual(SpecialTimeoutValue, timeoutConfiguration.CustomTimeout);
3030
}
3131

3232
[Test]
3333
public void Should_BePossibleTo_GetCustomLoggerValues()
3434
{
35-
TestApplicationManager.SetStartup(new CustomStartup());
36-
var timeoutConfiguration = TestApplicationManager.ServiceProvider.GetService<ILoggerConfiguration>() as CustomLoggerConfiguration;
35+
TestAqualityServices.SetStartup(new CustomStartup());
36+
var timeoutConfiguration = TestAqualityServices.ServiceProvider.GetService<ILoggerConfiguration>() as CustomLoggerConfiguration;
3737
Assert.AreEqual(SpecialLogger, timeoutConfiguration.CustomLogger);
3838
}
3939

4040
[Test]
4141
public void Should_BePossibleTo_RegisterCustomServices_WithCustomSettingsFile()
4242
{
43-
Assert.AreEqual(SpecialLanguageValue, TestApplicationManager.ServiceProvider.GetService<ILoggerConfiguration>().Language);
43+
Assert.AreEqual(SpecialLanguageValue, TestAqualityServices.ServiceProvider.GetService<ILoggerConfiguration>().Language);
4444
}
4545

46-
private class TestApplicationManager : ApplicationManager<IApplication>
46+
private class TestAqualityServices : AqualityServices<IApplication>
4747
{
4848
private static ThreadLocal<TestStartup> startup = new ThreadLocal<TestStartup>();
4949

@@ -56,7 +56,7 @@ public static void SetStartup(Startup startup)
5656
{
5757
if (startup != null)
5858
{
59-
TestApplicationManager.startup.Value = (TestStartup)startup;
59+
TestAqualityServices.startup.Value = (TestStartup)startup;
6060
}
6161
}
6262

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/ApplicationNotStartedTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class ApplicationNotStartedTests : TestWithBrowser
3030
public void Should_NotStartApplication_ForServiceResolving(Type type)
3131
{
3232
Assert.IsNotNull(ServiceProvider.GetRequiredService(type));
33-
Assert.IsFalse(ApplicationManager.IsApplicationStarted());
33+
Assert.IsFalse(AqualityServices.IsApplicationStarted);
3434
}
3535
}
3636
}
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88

99
namespace Aquality.Selenium.Core.Tests.Applications.Browser
1010
{
11-
public class ApplicationManager : ApplicationManager<ChromeApplication>
11+
public class AqualityServices : AqualityServices<ChromeApplication>
1212
{
1313
private static readonly object downloadDriverLock = new object();
1414

15+
public new static bool IsApplicationStarted => IsApplicationStarted();
16+
1517
public static ChromeApplication Application => GetApplication(services => StartChrome(services));
1618

1719
public static IServiceProvider ServiceProvider => GetServiceProvider(services => Application);

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/Elements/WebElement.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ protected WebElement(By locator, string name, ElementState state) : base(locator
1515
{
1616
}
1717

18-
protected override ElementActionRetrier ActionRetrier => ApplicationManager.ServiceProvider.GetRequiredService<ElementActionRetrier>();
18+
protected override ElementActionRetrier ActionRetrier => AqualityServices.ServiceProvider.GetRequiredService<ElementActionRetrier>();
1919

20-
protected override IApplication Application => ApplicationManager.Application;
20+
protected override IApplication Application => AqualityServices.Application;
2121

22-
protected override ConditionalWait ConditionalWait => ApplicationManager.ServiceProvider.GetRequiredService<ConditionalWait>();
22+
protected override ConditionalWait ConditionalWait => AqualityServices.ServiceProvider.GetRequiredService<ConditionalWait>();
2323

24-
protected override IElementFactory Factory => ApplicationManager.ServiceProvider.GetRequiredService<IElementFactory>();
24+
protected override IElementFactory Factory => AqualityServices.ServiceProvider.GetRequiredService<IElementFactory>();
2525

26-
protected override IElementFinder Finder => ApplicationManager.ServiceProvider.GetRequiredService<IElementFinder>();
26+
protected override IElementFinder Finder => AqualityServices.ServiceProvider.GetRequiredService<IElementFinder>();
2727

28-
protected override ILocalizedLogger LocalizedLogger => ApplicationManager.ServiceProvider.GetRequiredService<ILocalizedLogger>();
28+
protected override ILocalizedLogger LocalizedLogger => AqualityServices.ServiceProvider.GetRequiredService<ILocalizedLogger>();
2929
}
3030
}

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/FindElementsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class FindElementsTests : TestWithBrowser
2121
public new void SetUp()
2222
{
2323
elementFactory = ServiceProvider.GetRequiredService<IElementFactory>();
24-
ApplicationManager.Application.Driver.Navigate().GoToUrl(HoversURL);
24+
AqualityServices.Application.Driver.Navigate().GoToUrl(HoversURL);
2525
var example = new Label(ContentLoc, "Example", ElementState.Displayed);
2626
example.Click();
2727
}

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/TestWithBrowser.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ public void SetUp()
1515
{
1616
var services = new ServiceCollection();
1717

18-
new Startup().ConfigureServices(services, serviceCollection => ApplicationManager.Application);
18+
new Startup().ConfigureServices(services, serviceCollection => AqualityServices.Application);
1919
ServiceProvider = services.BuildServiceProvider();
2020
}
2121

2222
[TearDown]
2323
public void CleanUp()
2424
{
25-
if (ApplicationManager.IsApplicationStarted())
25+
if (AqualityServices.IsApplicationStarted)
2626
{
27-
ApplicationManager.Application.Quit();
27+
AqualityServices.Application.Quit();
2828
}
2929
}
3030
}
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@
99

1010
namespace Aquality.Selenium.Core.Tests.Applications.WindowsApp
1111
{
12-
public class ApplicationManager : ApplicationManager<WindowsApplication>
12+
public class AqualityServices : AqualityServices<WindowsApplication>
1313
{
1414
private const string SupportedApplication = "./Resources/WindowsApp/Day Maxi Calc.exe";
1515
private const string DefaultDriverServer = "http://127.0.0.1:4723/";
16-
16+
17+
public new static bool IsApplicationStarted => IsApplicationStarted();
18+
1719
public static WindowsApplication Application => GetApplication(service => StartApplication(service));
1820

1921
public static IServiceProvider ServiceProvider => GetServiceProvider(services => Application);

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/WindowsApp/CalculatorTest.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ public class CalculatorTest : TestWithApplication
88
[Test]
99
public void Should_WorkWithCalculator()
1010
{
11-
ApplicationManager.Application.Driver.FindElement(CalculatorWindow.OneButton).Click();
12-
ApplicationManager.Application.Driver.FindElement(CalculatorWindow.PlusButton).Click();
13-
ApplicationManager.Application.Driver.FindElement(CalculatorWindow.TwoButton).Click();
14-
ApplicationManager.Application.Driver.FindElement(CalculatorWindow.EqualsButton).Click();
15-
var result = ApplicationManager.Application.Driver.FindElement(CalculatorWindow.ResultsLabel).Text;
11+
AqualityServices.Application.Driver.FindElement(CalculatorWindow.OneButton).Click();
12+
AqualityServices.Application.Driver.FindElement(CalculatorWindow.PlusButton).Click();
13+
AqualityServices.Application.Driver.FindElement(CalculatorWindow.TwoButton).Click();
14+
AqualityServices.Application.Driver.FindElement(CalculatorWindow.EqualsButton).Click();
15+
var result = AqualityServices.Application.Driver.FindElement(CalculatorWindow.ResultsLabel).Text;
1616
StringAssert.Contains("3", result);
1717
}
1818
}

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/WindowsApp/ConditionalWaitTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class ConditionalWaitTests : TestWithApplication
1515
[Test]
1616
public void Should_BePossibleTo_UseConditionalWait_WithDriver()
1717
{
18-
Assert.DoesNotThrow(() => ApplicationManager.ServiceProvider.GetService<ConditionalWait>().WaitFor(driver =>
18+
Assert.DoesNotThrow(() => AqualityServices.ServiceProvider.GetService<ConditionalWait>().WaitFor(driver =>
1919
{
2020
return driver.FindElements(By.XPath("//*")).Count > 0;
2121
}));
@@ -24,10 +24,10 @@ public void Should_BePossibleTo_UseConditionalWait_WithDriver()
2424
[Test]
2525
public void Should_BePossibleTo_UseConditionalWait_WithElementFinder()
2626
{
27-
bool elementFinderCondition() => ApplicationManager.ServiceProvider.GetRequiredService<IElementFinder>()
27+
bool elementFinderCondition() => AqualityServices.ServiceProvider.GetRequiredService<IElementFinder>()
2828
.FindElement(CalculatorWindow.ResultsLabel, timeout: LittleTimeout).Text.Contains("3");
2929
Assert.IsFalse(elementFinderCondition());
30-
Assert.DoesNotThrow(() => ApplicationManager.ServiceProvider.GetService<ConditionalWait>().WaitFor(driver =>
30+
Assert.DoesNotThrow(() => AqualityServices.ServiceProvider.GetService<ConditionalWait>().WaitFor(driver =>
3131
{
3232
driver.FindElement(CalculatorWindow.TwoButton).Click();
3333
driver.FindElement(CalculatorWindow.PlusButton).Click();

0 commit comments

Comments
 (0)