Update Selenium version to v4.11.0 (#109)

* Update Selenium to v4.9.1
- Update NLog dependency to v5.1.4
- Update Appium test dependency to v5.0.0-beta04
- Remove WebDriverManager test dependency as Selenium Manager could be used now

* Make web cachedElementTests only parallelizable by themselves

* Updated to latest package versions. Add GenerateLocator as additional abstraction level

* Fix logger configuration

* Fix some warnings

* Add workaround in tests for GoToUrl webDriver issue and session not created issue

* Update azure-pipelines.yml for Azure Pipelines: add retryCountOnTaskFailure: 1

Author: mialeska

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Aquality.Selenium.Core.csproj

@@ -50,9 +50,9 @@
     <PackageReference Include="DotNetSeleniumExtras.PageObjects" Version="3.11.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="7.0.0" />
-    <PackageReference Include="NLog" Version="5.1.2" />
-    <PackageReference Include="Selenium.Support" Version="4.8.1" />
-    <PackageReference Include="Selenium.WebDriver" Version="4.8.1" />
-    <PackageReference Include="SkiaSharp" Version="2.88.3" />    
+    <PackageReference Include="NLog" Version="5.2.3" />
+    <PackageReference Include="Selenium.Support" Version="4.11.0" />
+    <PackageReference Include="Selenium.WebDriver" Version="4.11.0" />
+    <PackageReference Include="SkiaSharp" Version="2.88.5" />    
   </ItemGroup>
 </Project>

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Aquality.Selenium.Core.xml

@@ -75,7 +75,7 @@ public virtual IList<T> FindElements<T>(By locator, string name = null, ElementS
             {
                 var elementIndex = index + 1;
                 var elementName = $"{name ?? "element"} {elementIndex}";
-                return elementSupplier(GenerateXpathLocator(locator, webElement, elementIndex), elementName, state);
+                return elementSupplier(GenerateLocator(locator, webElement, elementIndex), elementName, state);
             });
             return elements.ToList();
         }
@@ -85,6 +85,18 @@ public virtual T GetCustomElement<T>(ElementSupplier<T> elementSupplier, By loca
             return elementSupplier(locator, name, state);
         }
 
+        /// <summary>
+        /// Generates locator for target element
+        /// </summary>
+        /// <param name="baseLocator">locator of parent element</param>
+        /// <param name="webElement">target element</param>
+        /// <param name="elementIndex">index of target element</param>
+        /// <returns>target element's locator</returns>
+        protected virtual By GenerateLocator(By baseLocator, IWebElement webElement, int elementIndex)
+        {
+            return GenerateXpathLocator(baseLocator, webElement, elementIndex);
+        }
+
         /// <summary>
         /// Generates xpath locator for target element
         /// </summary>

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Elements/ElementFactory.cs

@@ -1,7 +1,7 @@
 using Aquality.Selenium.Core.Configurations;
 using Aquality.Selenium.Core.Logging;
 using Aquality.Selenium.Core.Utilities;
-using System.Linq;
+using System;
 using System.Reflection;
 
 namespace Aquality.Selenium.Core.Localization
@@ -24,7 +24,7 @@ public LocalizationManager(ILoggerConfiguration loggerConfiguration, Logger logg
         private static ISettingsFile GetLocalizationFile(string language, Assembly assembly)
         {
             var embeddedResourceName = string.Format(LangResource, language.ToLower());
-            var assemblyToUse = assembly.GetManifestResourceNames().Any(name => name.Contains(embeddedResourceName))
+            var assemblyToUse = Array.Exists(assembly.GetManifestResourceNames(), name => name.Contains(embeddedResourceName))
                 ? assembly 
                 : Assembly.GetExecutingAssembly();
             return new JsonSettingsFile(embeddedResourceName, assemblyToUse);

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Localization/LocalizationManager.cs

@@ -19,7 +19,7 @@ private Logger()
         {
             try
             {
-                LogManager.LoadConfiguration("NLog.config");
+                LogManager.Setup().LoadConfigurationFromFile("NLog.config", optional: false);
             }
             catch (FileNotFoundException)
             {

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Logging/Logger.cs

@@ -24,7 +24,7 @@ public static string GetVariable(string key)
                 //necessary for Azure
                 Environment.GetEnvironmentVariable(key.ToUpper().Replace('.', '_'))
             };
-            return variables.FirstOrDefault(variable => variable != null);
+            return variables.Find(variable => variable != null);
         }
     }
 }

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Utilities/EnvironmentConfiguration.cs

@@ -1,17 +1,14 @@
 using Aquality.Selenium.Core.Applications;
 using Aquality.Selenium.Core.Configurations;
+using Aquality.Selenium.Core.Utilities;
 using Microsoft.Extensions.DependencyInjection;
 using System;
-using WebDriverManager;
-using WebDriverManager.DriverConfigs.Impl;
-using WebDriverManager.Helpers;
+using System.Collections.Generic;
 
 namespace Aquality.Selenium.Core.Tests.Applications.Browser
 {
     public class AqualityServices : AqualityServices<ChromeApplication>
     {
-        private static readonly object downloadDriverLock = new object();
-
         public new static bool IsApplicationStarted => IsApplicationStarted();
 
         public static ChromeApplication Application => GetApplication(services => StartChrome(services));
@@ -26,16 +23,13 @@ public static IServiceProvider ServiceProvider
             {
                 SetServiceProvider(value);
             }
-        }            
+        }
 
         private static ChromeApplication StartChrome(IServiceProvider services)
         {
-            lock (downloadDriverLock)
-            {
-                new DriverManager().SetUpDriver(new ChromeConfig(), VersionResolveStrategy.MatchingBrowser);
-            }
-
-            return new ChromeApplication(services.GetRequiredService<ITimeoutConfiguration>());
+            // temp workaround to handle ChromeDriver issue: https://groups.google.com/g/chromedriver-users/c/Dgv9xRHZf58
+            return services.GetService<IActionRetrier>().DoWithRetry(() =>
+                new ChromeApplication(services.GetRequiredService<ITimeoutConfiguration>()), new List<Type> { typeof(InvalidOperationException) });
         }
     }
 }

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/AqualityServices.cs

@@ -10,9 +10,9 @@
 
 namespace Aquality.Selenium.Core.Tests.Applications.Browser
 {
+    [Parallelizable(ParallelScope.Children)]
     public class CachedElementTests : TestWithBrowser
     {
-        private static readonly By RemoveButtonLoc = By.XPath("//button[.='Remove']");
         private static readonly By ContentLoc = By.Id("checkbox");
         private static readonly By StartLoc = By.XPath("//*[@id='start']//button");
         private static readonly By LoadingLoc = By.Id("loading");
@@ -49,26 +49,26 @@ private static readonly Func<IElementStateProvider, bool>[] StateFunctionsThrowN
                 state => !state.WaitForNotEnabled(TimeSpan.Zero),
             };
 
-        private IConditionalWait ConditionalWait => AqualityServices.ServiceProvider.GetRequiredService<IConditionalWait>();
+        private static IConditionalWait ConditionalWait => AqualityServices.ServiceProvider.GetRequiredService<IConditionalWait>();
 
         [SetUp]
         public new void SetUp()
         {
             Environment.SetEnvironmentVariable(ElementCacheVariableName, true.ToString());
         }
 
-        private void StartLoading()
+        private static void StartLoading()
         {
-            AqualityServices.Application.Driver.Navigate().GoToUrl(DynamicLoadingUrl);
+            GoToUrl(DynamicLoadingUrl);
             new Label(StartLoc, "start", ElementState.Displayed).Click();
         }
 
-        private void OpenDynamicContent()
+        private static void OpenDynamicContent()
         {
-            AqualityServices.Application.Driver.Navigate().GoToUrl(DynamicContentUrl);
+            GoToUrl(DynamicContentUrl);
         }
 
-        private void WaitForLoading(Label loader)
+        private static void WaitForLoading(Label loader)
         {
             Assume.That(loader.State.WaitForDisplayed(), "Loader should be displayed in the beginning");
             Assume.That(loader.State.WaitForNotDisplayed(), "Loader should not be displayed in the end");
@@ -137,7 +137,7 @@ public void Should_ReturnCorrectState_True_WhenWindowIsReopened([ValueSource(nam
             AssertStateConditionAfterReopen(stateCondition, expectedValue: true);
         }
 
-        private void AssertStateConditionAfterReopen(Func<IElementStateProvider, bool> stateCondition, bool expectedValue)
+        private static void AssertStateConditionAfterReopen(Func<IElementStateProvider, bool> stateCondition, bool expectedValue)
         {
             Label testElement = null;
             AqualityServices.ServiceProvider.GetRequiredService<IActionRetrier>().DoWithRetry(() =>

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/CachedElementTests.cs

@@ -39,7 +39,7 @@ public void Should_BePossibleTo_UseConditionalWait_WithDriver()
         {
             Assert.DoesNotThrow(() => ConditionalWait.WaitFor(driver =>
             {
-                driver.Navigate().GoToUrl(WikiURL);
+                GoToUrl(WikiURL, driver);
                 return driver.FindElements(By.XPath("//*")).Count > 0;
             }));
         }
@@ -100,7 +100,7 @@ bool elementFinderCondition() => ServiceProvider.GetRequiredService<IElementFind
             Assert.IsFalse(elementFinderCondition());
             Assert.DoesNotThrow(() => ConditionalWait.WaitFor(driver =>
             {
-                driver.Navigate().GoToUrl(WikiURL);
+                GoToUrl(WikiURL, driver);
                 return elementFinderCondition();
             }));
         }

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/ConditionalWaitTests.cs

@@ -32,7 +32,7 @@ protected virtual IList<T> FindElements<T>(By locator, string name = null, Eleme
         public new void SetUp()
         {
             ElementFactory = ServiceProvider.GetRequiredService<IElementFactory>();
-            AqualityServices.Application.Driver.Navigate().GoToUrl(HoversURL);
+            GoToUrl(HoversURL);
             ParentElement = new Label(ContentLoc, "Example", ElementState.Displayed);
             ParentElement.Click();
         }